Nicholas Clark <[EMAIL PROTECTED]> writes:
> On Wed, Jan 11, 2006 at 06:30:01AM -0800, Gisle Aas wrote:
>
> > ==== //depot/perl/mg.c#402 (text) ====
> > Index: perl/mg.c
> > --- perl/mg.c#401~26781~ 2006-01-11 04:11:03.000000000 -0800
> > +++ perl/mg.c 2006-01-11 06:23:28.000000000 -0800
> > @@ -1004,15 +1004,9 @@
> > break;
> > case '(':
> > sv_setiv(sv, (IV)PL_gid);
> > -#ifdef HAS_GETGROUPS
> > - Perl_sv_setpvf(aTHX_ sv, "%"Gid_t_f, PL_gid);
> > -#endif
> > goto add_groups;
> > case ')':
> > sv_setiv(sv, (IV)PL_egid);
> > -#ifdef HAS_GETGROUPS
> > - Perl_sv_setpvf(aTHX_ sv, "%"Gid_t_f, PL_egid);
> > -#endif
>
> Those two parts aren't correct, are they?
They are. The sv_setpvf() calls are redundant because that just sets
the PV to be the same as IV is already set to be. When we later
sv_catpvf() the getgroups() gids they are appended to the
stringification of the IV.
--Gisle
