Change 27360 by [EMAIL PROTECTED] on 2006/03/02 09:08:30
Subject: [PATCH] Non-null optimizations
From: [EMAIL PROTECTED] (Andy Lester)
Date: Wed, 1 Mar 2006 22:13:45 -0600
Message-ID: <[EMAIL PROTECTED]>
Affected files ...
... //depot/perl/embed.fnc#320 edit
... //depot/perl/pod/perlapi.pod#248 edit
... //depot/perl/proto.h#667 edit
... //depot/perl/sv.c#1179 edit
Differences ...
==== //depot/perl/embed.fnc#320 (text) ====
Index: perl/embed.fnc
--- perl/embed.fnc#319~27339~ 2006-02-27 05:40:44.000000000 -0800
+++ perl/embed.fnc 2006-03-02 01:08:30.000000000 -0800
@@ -538,8 +538,8 @@
Apa |OP* |newPADOP |I32 type|I32 flags|NULLOK SV* sv
Apa |OP* |newPMOP |I32 type|I32 flags
Apa |OP* |newPVOP |I32 type|I32 flags|NULLOK char* pv
-Apa |SV* |newRV |NN SV* pref
-Apda |SV* |newRV_noinc |NN SV *sv
+Apa |SV* |newRV |NN SV* sv
+Apda |SV* |newRV_noinc |NN SV* sv
Apda |SV* |newSV |STRLEN len
Apa |OP* |newSVREF |NN OP* o
Apa |OP* |newSVOP |I32 type|I32 flags|NN SV* sv
==== //depot/perl/pod/perlapi.pod#248 (text+w) ====
Index: perl/pod/perlapi.pod
--- perl/pod/perlapi.pod#247~27334~ 2006-02-27 03:06:30.000000000 -0800
+++ perl/pod/perlapi.pod 2006-03-02 01:08:30.000000000 -0800
@@ -4529,7 +4529,7 @@
Creates an RV wrapper for an SV. The reference count for the original
SV is B<not> incremented.
- SV* newRV_noinc(SV *sv)
+ SV* newRV_noinc(SV* sv)
=for hackers
Found in file sv.c
==== //depot/perl/proto.h#667 (text+w) ====
Index: perl/proto.h
--- perl/proto.h#666~27339~ 2006-02-27 05:40:44.000000000 -0800
+++ perl/proto.h 2006-03-02 01:08:30.000000000 -0800
@@ -1517,12 +1517,12 @@
__attribute__malloc__
__attribute__warn_unused_result__;
-PERL_CALLCONV SV* Perl_newRV(pTHX_ SV* pref)
+PERL_CALLCONV SV* Perl_newRV(pTHX_ SV* sv)
__attribute__malloc__
__attribute__warn_unused_result__
__attribute__nonnull__(pTHX_1);
-PERL_CALLCONV SV* Perl_newRV_noinc(pTHX_ SV *sv)
+PERL_CALLCONV SV* Perl_newRV_noinc(pTHX_ SV* sv)
__attribute__malloc__
__attribute__warn_unused_result__
__attribute__nonnull__(pTHX_1);
==== //depot/perl/sv.c#1179 (text) ====
Index: perl/sv.c
--- perl/sv.c#1178~27351~ 2006-02-28 04:40:06.000000000 -0800
+++ perl/sv.c 2006-03-02 01:08:30.000000000 -0800
@@ -6981,10 +6981,10 @@
*/
SV *
-Perl_newRV(pTHX_ SV *tmpRef)
+Perl_newRV(pTHX_ SV *sv)
{
dVAR;
- return newRV_noinc(SvREFCNT_inc_simple(tmpRef));
+ return newRV_noinc(SvREFCNT_inc_simple_NN(sv));
}
/*
@@ -9214,6 +9214,7 @@
#define sv_dup_inc(s,t) SvREFCNT_inc(sv_dup(s,t))
+#define sv_dup_inc_NN(s,t) SvREFCNT_inc_NN(sv_dup(s,t))
#define av_dup(s,t) (AV*)sv_dup((SV*)s,t)
#define av_dup_inc(s,t) (AV*)SvREFCNT_inc(sv_dup((SV*)s,t))
#define hv_dup(s,t) (HV*)sv_dup((SV*)s,t)
@@ -10756,8 +10757,7 @@
const I32 len = av_len((AV*)proto_perl->Iregex_padav);
SV* const * const regexen = AvARRAY((AV*)proto_perl->Iregex_padav);
IV i;
- av_push(PL_regex_padav,
- sv_dup_inc(regexen[0],param));
+ av_push(PL_regex_padav, sv_dup_inc_NN(regexen[0],param));
for(i = 1; i <= len; i++) {
const SV * const regex = regexen[i];
SV * const sv =
End of Patch.
