Change 27523 by [EMAIL PROTECTED] on 2006/03/16 21:52:49
Correct the macros in the comments in hv.c. Given the improvements in
compiler optimisation, and the almost irrelevance of instructions
executed over cache misses, maybe we should just remove the comments
by putting their code back in place of the o{timis,bfuscat}ed version.
Affected files ...
... //depot/perl/hv.c#293 edit
Differences ...
==== //depot/perl/hv.c#293 (text) ====
Index: perl/hv.c
--- perl/hv.c#292~27381~ 2006-03-05 10:40:59.000000000 -0800
+++ perl/hv.c 2006-03-16 13:52:49.000000000 -0800
@@ -830,7 +830,7 @@
{
const HE *counter = HeNEXT(entry);
- xhv->xhv_keys++; /* HvKEYS(hv)++ */
+ xhv->xhv_keys++; /* HvTOTALKEYS(hv)++ */
if (!counter) { /* initial entry? */
xhv->xhv_fill++; /* HvFILL(hv)++ */
} else if (xhv->xhv_keys > (IV)xhv->xhv_max) {
@@ -1108,7 +1108,7 @@
HvLAZYDEL_on(hv);
else
hv_free_ent(hv, entry);
- xhv->xhv_keys--; /* HvKEYS(hv)-- */
+ xhv->xhv_keys--; /* HvTOTALKEYS(hv)-- */
if (xhv->xhv_keys == 0)
HvHASKFLAGS_off(hv);
}
@@ -2343,7 +2343,7 @@
xhv->xhv_fill--; /* HvFILL(hv)-- */
}
Safefree(entry);
- xhv->xhv_keys--; /* HvKEYS(hv)-- */
+ xhv->xhv_keys--; /* HvTOTALKEYS(hv)-- */
}
}
@@ -2456,7 +2456,7 @@
HeNEXT(entry) = next;
*head = entry;
- xhv->xhv_keys++; /* HvKEYS(hv)++ */
+ xhv->xhv_keys++; /* HvTOTALKEYS(hv)++ */
if (!next) { /* initial entry? */
xhv->xhv_fill++; /* HvFILL(hv)++ */
} else if (xhv->xhv_keys > (IV)xhv->xhv_max /* HvKEYS(hv) > HvMAX(hv)
*/) {
End of Patch.
