Change 29872: Given that we now do the tests in S_visit() to avoid calling the

[Nicholas Clark]

Change 29872 by [EMAIL PROTECTED] on 2007/01/18 15:48:13

        Given that we now do the tests in S_visit() to avoid calling the
        helper function when skippable, no need to retain those tests
        inside the helper functions do_clean_objs() and do_clean_named_objs().

Affected files ...

... //depot/perl/sv.c#1356 edit

Differences ...

==== //depot/perl/sv.c#1356 (text) ====
Index: perl/sv.c
--- perl/sv.c#1355~29867~       2007-01-18 03:16:09.000000000 -0800
+++ perl/sv.c   2007-01-18 07:48:13.000000000 -0800
@@ -443,7 +443,8 @@
 do_clean_objs(pTHX_ SV *ref)
 {
     dVAR;
-    if (SvROK(ref)) {
+    assert (SvROK(ref));
+    {
        SV * const target = SvRV(ref);
        if (SvOBJECT(target)) {
            DEBUG_D((PerlIO_printf(Perl_debug_log, "Cleaning object ref:\n "), 
sv_dump(ref)));
@@ -469,7 +470,8 @@
 do_clean_named_objs(pTHX_ SV *sv)
 {
     dVAR;
-    if (SvTYPE(sv) == SVt_PVGV && isGV_with_GP(sv) && GvGP(sv)) {
+    assert(SvTYPE(sv) == SVt_PVGV);
+    if (isGV_with_GP(sv) && GvGP(sv)) {
        if ((
 #ifdef PERL_DONT_CREATE_GVSV
             GvSV(sv) &&
End of Patch.