Change 30032 by [EMAIL PROTECTED] on 2007/01/27 15:36:49
newPADOP is only used under ithreads, so don't waste space by compiling
it for non-threaded builds.
Affected files ...
... //depot/perl/embed.fnc#457 edit
... //depot/perl/embed.h#661 edit
... //depot/perl/makedef.pl#217 edit
... //depot/perl/op.c#881 edit
... //depot/perl/proto.h#795 edit
Differences ...
==== //depot/perl/embed.fnc#457 (text) ====
Index: perl/embed.fnc
--- perl/embed.fnc#456~30015~ 2007-01-26 08:16:29.000000000 -0800
+++ perl/embed.fnc 2007-01-27 07:36:49.000000000 -0800
@@ -566,7 +566,9 @@
ApaR |HV* |newHVhv |NULLOK HV* hv
Apa |IO* |newIO
Apa |OP* |newLISTOP |I32 type|I32 flags|NULLOK OP* first|NULLOK OP*
last
+#ifdef USE_ITHREADS
Apa |OP* |newPADOP |I32 type|I32 flags|NULLOK SV* sv
+#endif
Apa |OP* |newPMOP |I32 type|I32 flags
Apa |OP* |newPVOP |I32 type|I32 flags|NULLOK char* pv
Apa |SV* |newRV |NN SV* sv
==== //depot/perl/embed.h#661 (text+w) ====
Index: perl/embed.h
--- perl/embed.h#660~30015~ 2007-01-26 08:16:29.000000000 -0800
+++ perl/embed.h 2007-01-27 07:36:49.000000000 -0800
@@ -562,7 +562,9 @@
#define newHVhv Perl_newHVhv
#define newIO Perl_newIO
#define newLISTOP Perl_newLISTOP
+#ifdef USE_ITHREADS
#define newPADOP Perl_newPADOP
+#endif
#define newPMOP Perl_newPMOP
#define newPVOP Perl_newPVOP
#define newRV Perl_newRV
@@ -2775,7 +2777,9 @@
#define newHVhv(a) Perl_newHVhv(aTHX_ a)
#define newIO() Perl_newIO(aTHX)
#define newLISTOP(a,b,c,d) Perl_newLISTOP(aTHX_ a,b,c,d)
+#ifdef USE_ITHREADS
#define newPADOP(a,b,c) Perl_newPADOP(aTHX_ a,b,c)
+#endif
#define newPMOP(a,b) Perl_newPMOP(aTHX_ a,b)
#define newPVOP(a,b,c) Perl_newPVOP(aTHX_ a,b,c)
#define newRV(a) Perl_newRV(aTHX_ a)
==== //depot/perl/makedef.pl#217 (text) ====
Index: perl/makedef.pl
--- perl/makedef.pl#216~29853~ 2007-01-17 10:24:50.000000000 -0800
+++ perl/makedef.pl 2007-01-27 07:36:49.000000000 -0800
@@ -746,6 +746,7 @@
Perl_sharedsv_unlock
Perl_stashpv_hvname_match
Perl_regdupe_internal
+ Perl_newPADOP
)];
}
==== //depot/perl/op.c#881 (text) ====
Index: perl/op.c
--- perl/op.c#880~30028~ 2007-01-27 04:55:31.000000000 -0800
+++ perl/op.c 2007-01-27 07:36:49.000000000 -0800
@@ -3421,6 +3421,7 @@
return CHECKOP(type, svop);
}
+#ifdef USE_ITHREADS
OP *
Perl_newPADOP(pTHX_ I32 type, I32 flags, SV *sv)
{
@@ -3442,6 +3443,7 @@
padop->op_targ = pad_alloc(type, SVs_PADTMP);
return CHECKOP(type, padop);
}
+#endif
OP *
Perl_newGVOP(pTHX_ I32 type, I32 flags, GV *gv)
==== //depot/perl/proto.h#795 (text+w) ====
Index: perl/proto.h
--- perl/proto.h#794~30015~ 2007-01-26 08:16:29.000000000 -0800
+++ perl/proto.h 2007-01-27 07:36:49.000000000 -0800
@@ -1549,10 +1549,12 @@
__attribute__malloc__
__attribute__warn_unused_result__;
+#ifdef USE_ITHREADS
PERL_CALLCONV OP* Perl_newPADOP(pTHX_ I32 type, I32 flags, SV* sv)
__attribute__malloc__
__attribute__warn_unused_result__;
+#endif
PERL_CALLCONV OP* Perl_newPMOP(pTHX_ I32 type, I32 flags)
__attribute__malloc__
__attribute__warn_unused_result__;
End of Patch.