Change 30189 by [EMAIL PROTECTED] on 2007/02/10 13:00:46
Integrate:
[ 26206]
Additional tests for B and POSIX. The POSIX ones concern me a bit,
but I don't expect any black smokes because of testing on OpenBSD,
Linux, Win32, an Cygwin.
[ 26207]
Hmmm...strftime() does work on Win32, but tzset() is having problems
on OpenBSD.
[ 26208]
Just be explicit about $TZ.
[ 26213]
Deal with differences in what clock() does between POSIX and BSD.
[ 26221]
Mac OS X/Darwin seems to have problems with tzname().
[ 26222]
Fix ext/POSIX/t/time.t on Win32
According to MSDN, "The string result produced by ctime contains
exactly 26 characters and has the form: Wed Jan 02 02:03:55 1980\n\0"
so we *do* want the leading zero on the day returned by strftime
[ 26384]
Fix for ext/POSIX/t/time.t so the strftime() test works on systems
that aren't quite up to SUS3. Based on a patch by David Dyck in
RT #37960: POSIX/t/time fails bleadperl
[ 26424]
Fix typos in regular expressions
Affected files ...
... //depot/maint-5.8/perl/MANIFEST#311 integrate
... //depot/maint-5.8/perl/ext/B/t/b.t#6 integrate
... //depot/maint-5.8/perl/ext/POSIX/t/time.t#1 branch
Differences ...
==== //depot/maint-5.8/perl/MANIFEST#311 (text) ====
Index: perl/MANIFEST
--- perl/MANIFEST#310~30187~ 2007-02-09 15:24:25.000000000 -0800
+++ perl/MANIFEST 2007-02-10 05:00:46.000000000 -0800
@@ -793,6 +793,7 @@
ext/POSIX/t/posix.t See if POSIX works
ext/POSIX/t/sigaction.t See if POSIX::sigaction works
ext/POSIX/t/taint.t See if POSIX works with taint
+ext/POSIX/t/time.t See if POSIX time-related functions work
ext/POSIX/t/waitpid.t See if waitpid works
ext/POSIX/typemap POSIX extension interface types
ext/re/hints/mpeix.pl Hints for re for named architecture
==== //depot/maint-5.8/perl/ext/B/t/b.t#6 (xtext) ====
Index: perl/ext/B/t/b.t
--- perl/ext/B/t/b.t#5~23814~ 2005-01-18 14:08:15.000000000 -0800
+++ perl/ext/B/t/b.t 2007-02-10 05:00:46.000000000 -0800
@@ -22,7 +22,7 @@
$| = 1;
use warnings;
use strict;
-use Test::More tests => 41;
+use Test::More tests => 53;
BEGIN { use_ok( 'B' ); }
@@ -147,3 +147,19 @@
is($gv_ref->NAME(), "gv", "Test NAME()");
is($gv_ref->SAFENAME(), "gv", "Test SAFENAME()");
like($gv_ref->FILE(), qr/b\.t$/, "Testing FILE()");
+
+# The following return B::SPECIALs.
+is(ref B::sv_yes(), "B::SPECIAL", "B::sv_yes()");
+is(ref B::sv_no(), "B::SPECIAL", "B::sv_no()");
+is(ref B::sv_undef(), "B::SPECIAL", "B::sv_undef()");
+
+# More utility functions
+is(B::ppname(0), "pp_null", "Testing ppname (this might break if opnames.h is
changed)");
+is(B::opnumber("null"), 0, "Testing opnumber with opname (null)");
+is(B::opnumber("pp_null"), 0, "Testing opnumber with opname (pp_null)");
+like(B::hash("wibble"), qr/0x[0-9a-f]*/, "Testing B::hash()");
+is(B::cstring("wibble"), '"wibble"', "Testing B::cstring()");
+is(B::perlstring("wibble"), '"wibble"', "Testing B::perlstring()");
+is(B::class(bless {}, "Wibble::Bibble"), "Bibble", "Testing B::class()");
+is(B::cast_I32(3.14), 3, "Testing B::cast_I32()");
+is(B::opnumber("localtime"), 294);
==== //depot/maint-5.8/perl/ext/POSIX/t/time.t#1 (text) ====
Index: perl/ext/POSIX/t/time.t
--- /dev/null 2007-01-16 11:55:45.526841103 -0800
+++ perl/ext/POSIX/t/time.t 2007-02-10 05:00:46.000000000 -0800
@@ -0,0 +1,59 @@
+#!perl -w
+
+use strict;
+
+use Config;
+use POSIX;
+use Test::More tests => 9;
+
+# go to UTC to avoid DST issues around the world when testing. SUS3 says that
+# null should get you UTC, but some environments want the explicit names.
+# Those with a working tzset() should be able to use the TZ below.
+$ENV{TZ} = "UTC0UTC";
+
+SKIP: {
+ # It looks like POSIX.xs claims that only VMS and Mac OS traditional
+ # don't have tzset(). Win32 works to call the function, but it doesn't
+ # actually do anything. Cygwin works in some places, but not others. The
+ # other Win32's below are guesses.
+ skip "No tzset()", 2
+ if $^O eq "MacOS" || $^O eq "VMS" || $^O eq "cygwin" || $^O eq "djgpp"
||
+ $^O eq "MSWin32" || $^O eq "dos" || $^O eq "interix";
+ tzset();
+ my @tzname = tzname();
+ like($tzname[0], qr/(GMT|UTC)/i, "tzset() to GMT/UTC");
+ SKIP: {
+ skip "Mac OS X/Darwin doesn't handle this", 1 if $^O =~ /darwin/i;
+ like($tzname[1], qr/(GMT|UTC)/i, "The whole year?");
+ }
+}
+
+# asctime and ctime...Let's stay below INT_MAX for 32-bits and
+# positive for some picky systems.
+
+is(asctime(localtime(0)), ctime(0), "asctime() and ctime() at zero");
+is(asctime(localtime(12345678)), ctime(12345678), "asctime() and ctime() at
12345678");
+
+# Careful! strftime() is locale sensative. Let's take care of that
+my $orig_loc = setlocale(LC_TIME, "C") || die "Cannot setlocale() to C: $!";
+my $jan_16 = 15 * 86400;
+is(ctime($jan_16), strftime("%a %b %d %H:%M:%S %Y\n", localtime($jan_16)),
+ "get ctime() equal to strftime()");
+setlocale(LC_TIME, $orig_loc) || die "Cannot setlocale() back to orig: $!";
+
+# clock() seems to have different definitions of what it does between POSIX
+# and BSD. Cygwin, Win32, and Linux lean the BSD way. So, the tests just
+# check the basics.
+like(clock(), qr/\d*/, "clock() returns a numeric value");
+ok(clock() >= 0, "...and it returns something >= 0");
+
+SKIP: {
+ skip "No difftime()", 1 if $Config{d_difftime} ne 'define';
+ is(difftime(2, 1), 1, "difftime()");
+}
+
+SKIP: {
+ skip "No mktime()", 1 if $Config{d_mktime} ne 'define';
+ my $time = time();
+ is(mktime(localtime($time)), $time, "mktime()");
+}
End of Patch.
