Change 31073: Re: [Andreas J. Koenig] C3 MRO breaks Params::Util and Graph

[Rafael Garcia-Suarez]

Change 31073 by [EMAIL PROTECTED] on 2007/04/25 12:15:55

        Subject: Re: [Andreas J. Koenig] C3 MRO breaks Params::Util and Graph
        From: "Brandon Black" <[EMAIL PROTECTED]>
        Date: Tue, 24 Apr 2007 07:58:44 -0500
        Message-ID: <[EMAIL PROTECTED]>

Affected files ...

... //depot/perl/ext/DynaLoader/t/DynaLoader.t#13 edit
... //depot/perl/lib/overload.pm#52 edit

Differences ...

==== //depot/perl/ext/DynaLoader/t/DynaLoader.t#13 (text) ====
Index: perl/ext/DynaLoader/t/DynaLoader.t
--- perl/ext/DynaLoader/t/DynaLoader.t#12~30852~        2007-04-06 
07:15:44.000000000 -0700
+++ perl/ext/DynaLoader/t/DynaLoader.t  2007-04-25 05:15:55.000000000 -0700
@@ -25,6 +25,7 @@
 
 %modules = (
    # ModuleName  => q| code to check that it was loaded |,
+    'List::Util' => q| ::is( ref List::Util->can('first'), 'CODE' ) |,  # 5.7.2
     'Cwd'        => q| ::is( ref Cwd->can('fastcwd'),'CODE' ) |,         # 5.7 
?
     'File::Glob' => q| ::is( ref File::Glob->can('doglob'),'CODE' ) |,   # 5.6
     $db_file     => q| ::is( ref $db_file->can('TIEHASH'), 'CODE' ) |,  # 5.0
@@ -32,7 +33,7 @@
     'Time::HiRes'=> q| ::is( ref Time::HiRes->can('usleep'),'CODE' ) |,  # 
5.7.3
 );
 
-plan tests => 27 + keys(%modules) * 2;
+plan tests => 22 + keys(%modules) * 3;
 
 
 # Try to load the module

==== //depot/perl/lib/overload.pm#52 (text) ====
Index: perl/lib/overload.pm
--- perl/lib/overload.pm#51~30980~      2007-04-19 07:48:20.000000000 -0700
+++ perl/lib/overload.pm        2007-04-25 05:15:55.000000000 -0700
@@ -1,6 +1,6 @@
 package overload;
 
-our $VERSION = '1.05';
+our $VERSION = '1.06';
 
 sub nil {}
 
@@ -72,7 +72,11 @@
 
 sub Method {
   my $package = shift;
-  $package = ref $package if ref $package;
+  if(ref $package) {
+    require Scalar::Util;
+    $package = Scalar::Util::blessed($package);
+    return undef if !defined $package;
+  }
   #my $meth = $package->can('(' . shift);
   ov_method mycan($package, '(' . shift), $package;
   #return $meth if $meth ne \&nil;
End of Patch.