Change 31734 by [EMAIL PROTECTED] on 2007/08/18 11:31:08
Add note to regexp.h that modifying RXf_ type flags requires a regen.pl
or regcomp.pl to update regnodes.h
Currently the *NIX makefiles are not set up to update regnodes.h
automatically when regexp.h is modified.
This at least warns people modifying the list about what they should
do. A better solution is needed.
Affected files ...
... //depot/perl/regcomp.h#129 edit
... //depot/perl/regexp.h#110 edit
... //depot/perl/regnodes.h#46 edit
Differences ...
==== //depot/perl/regexp.h#110 (text) ====
Index: perl/regexp.h
--- perl/regexp.h#109~31693~ 2007-08-09 03:10:37.000000000 -0700
+++ perl/regexp.h 2007-08-18 04:31:08.000000000 -0700
@@ -222,6 +222,10 @@
* Note that flags starting with RXf_PMf_ have exact equivalents
* stored in op_pmflags and which are defined in op.h, they are defined
* numerically here only for clarity.
+ *
+ * NOTE: if you modify any RXf flags you should run regen.pl or regcomp.pl
+ * so that regnodes.h is updated with the changes.
+ *
*/
/* Anchor and GPOS related stuff */
@@ -290,6 +294,11 @@
#define M_PAT_MODS QR_PAT_MODS LOOP_PAT_MODS
#define S_PAT_MODS M_PAT_MODS EXEC_PAT_MODS
+/*
+ * NOTE: if you modify any RXf flags you should run regen.pl or regcomp.pl
+ * so that regnodes.h is updated with the changes.
+ *
+ */
/* What we have seen */
#define RXf_LOOKBEHIND_SEEN 0x00020000
@@ -323,6 +332,11 @@
#define RXf_TAINTED_SEEN 0x20000000
#define RXf_TAINTED 0x80000000 /* this pattern is tainted */
+/*
+ * NOTE: if you modify any RXf flags you should run regen.pl or regcomp.pl
+ * so that regnodes.h is updated with the changes.
+ *
+ */
#define RX_HAS_CUTGROUP(prog) ((prog)->intflags & PREGf_CUTGROUP_SEEN)
#define RX_MATCH_TAINTED(prog) ((prog)->extflags & RXf_TAINTED_SEEN)
End of Patch.
