Steve Hay wrote:
John E. Malmberg wrote:
Steve Hay wrote:
Craig A.Berry wrote:

Change 31726 by [EMAIL PROTECTED] on 2007/08/16 17:05:48

                Subject: [EMAIL PROTECTED] fix
for VMS

        From: "John E. Malmberg" <[EMAIL PROTECTED]>
        Date: Thu, 16 Aug 2007 00:27:35 -0500
        Message-id: <[EMAIL PROTECTED]>

This breaks on Win32. File::Spec->splitpath() returns three items,
which don't necessarily have the correct flavour of slash (backslash
or forward slash) on Win32:

$INC{'Module/Load/Conditional.pm'}='../../../../Module/Load/Conditional.
pm' @rv_path = ('', '..\..\..\..\Module\Load\', 'Conditional.pm')

File::Spec::Unix->catfile(@rv_path)='..\..\..\..\Module\Load\/Conditiona
l.pm'
I've therefore put a splitdir() call back into the test to break down
that list of directories, so that they can all get joined back
together in Unix style (change #31727). Hope it's still OK on VMS!
Splitdir can only be portably used on path specifications that only
contain directories.  $rv-{file} contains a file specification, and so
does the resulting @rv_path.

This patch breaks VMS again.

Are you sure? I deliberately only ran splitdir() on $rv_path[1] (the
portion of @rv_path that contains the directories only) to try to avoid
problems like this.

I will check again when I get home. The result of that line you added changed @rv_path to contain an invalid VMS path. I may have jumped to the wrong conclusion of what specifically caused the problem.

-John
[EMAIL PROTECTED]
Personal Opinion Only

Reply via email to