Change 31742 by [EMAIL PROTECTED] on 2007/08/21 09:55:07
Use -D_CRT_NONSTDC_NO_DEPRECATE rather than -wd4996 to suppress warnings
about POSIX CRT function names being deprecated in VC8
(-wd4996 suppresses all deprecated function warnings, so is more
wide-ranging than is required)
Affected files ...
... //depot/perl/pod/perltodo.pod#185 edit
... //depot/perl/win32/Makefile#340 edit
... //depot/perl/win32/makefile.mk#379 edit
Differences ...
==== //depot/perl/pod/perltodo.pod#185 (text) ====
Index: perl/pod/perltodo.pod
--- perl/pod/perltodo.pod#184~31695~ 2007-08-09 06:41:28.000000000 -0700
+++ perl/pod/perltodo.pod 2007-08-21 02:55:07.000000000 -0700
@@ -383,7 +383,7 @@
There is also a similar issue with POSIX CRT function names like fileno having
been deprecated in favour of ISO C++ conformant names like _fileno. These
-warnings are also currently suppressed with the compiler option /wd4996. It
+warnings are also currently suppressed by adding -D_CRT_NONSTDC_NO_DEPRECATE.
It
might be nice to do as Microsoft suggest here too, although, unlike the secure
functions issue, there is presumably little or no benefit in this case.
==== //depot/perl/win32/Makefile#340 (text) ====
Index: perl/win32/Makefile
--- perl/win32/Makefile#339~31506~ 2007-06-30 08:37:41.000000000 -0700
+++ perl/win32/Makefile 2007-08-21 02:55:07.000000000 -0700
@@ -457,7 +457,7 @@
# For now, silence VC++ 8.x's warnings about "unsafe" CRT functions and POSIX
# CRT function names being deprecated.
!IF "$(CCTYPE)" == "MSVC80" || "$(CCTYPE)" == "MSVC80FREE"
-DEFINES = $(DEFINES) -D_CRT_SECURE_NO_DEPRECATE -wd4996
+DEFINES = $(DEFINES) -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NONSTDC_NO_DEPRECATE
!ENDIF
# Use the MSVCRT read() fix if the PerlCRT was not chosen, but only when using
==== //depot/perl/win32/makefile.mk#379 (text) ====
Index: perl/win32/makefile.mk
--- perl/win32/makefile.mk#378~31539~ 2007-07-06 04:08:37.000000000 -0700
+++ perl/win32/makefile.mk 2007-08-21 02:55:07.000000000 -0700
@@ -568,7 +568,7 @@
# For now, silence VC++ 8.x's warnings about "unsafe" CRT functions and POSIX
# CRT function names being deprecated.
.IF "$(CCTYPE)" == "MSVC80" || "$(CCTYPE)" == "MSVC80FREE"
-DEFINES += -D_CRT_SECURE_NO_DEPRECATE -wd4996
+DEFINES += -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NONSTDC_NO_DEPRECATE
.ENDIF
# Use the MSVCRT read() fix if the PerlCRT was not chosen, but only when using
End of Patch.
