Change 32920 by [EMAIL PROTECTED] on 2008/01/09 16:32:55
Subject: RE: compile warnings w/ PM_SETRE and ReREFCNT_inc
From: "Robin Barker" <[EMAIL PROTECTED]>
Date: Mon, 7 Jan 2008 14:10:30 -0000
Message-ID: <[EMAIL PROTECTED]>
Affected files ...
... //depot/perl/pp_ctl.c#653 edit
Differences ...
==== //depot/perl/pp_ctl.c#653 (text) ====
Index: perl/pp_ctl.c
--- perl/pp_ctl.c#652~32912~ 2008-01-09 03:34:41.000000000 -0800
+++ perl/pp_ctl.c 2008-01-09 08:32:55.000000000 -0800
@@ -212,7 +212,8 @@
if(old != rx) {
if(old)
ReREFCNT_dec(old);
- PM_SETRE(pm,ReREFCNT_inc(rx));
+ ReREFCNT_inc(rx);
+ PM_SETRE(pm,rx);
}
rxres_restore(&cx->sb_rxres, rx);
@@ -309,7 +310,7 @@
mg->mg_len = i;
}
if (old != rx)
- (void)ReREFCNT_inc(rx);
+ ReREFCNT_inc(rx);
cx->sb_rxtainted |= RX_MATCH_TAINTED(rx);
rxres_save(&cx->sb_rxres, rx);
RETURNOP(pm->op_pmstashstartu.op_pmreplstart);
@@ -3828,7 +3829,8 @@
{
dVAR;
PMOP *matcher = (PMOP *) newPMOP(OP_MATCH, OPf_WANT_SCALAR | OPf_STACKED);
- PM_SETRE(matcher, ReREFCNT_inc(re));
+ ReREFCNT_inc(re);
+ PM_SETRE(matcher, re);
SAVEFREEOP((OP *) matcher);
ENTER; SAVETMPS;
End of Patch.
