Change 32928 by [EMAIL PROTECTED] on 2008/01/09 21:18:39

        Only code paths in hv_store either XSRETURN_NO or XSRETURN_YES.
        Change the prototype to return void, remove the output to RETVAL
        (which isn't set anyway), and fix a typo in the code.

Affected files ...

... //depot/perl/ext/Hash/Util/Util.xs#2 edit

Differences ...

==== //depot/perl/ext/Hash/Util/Util.xs#2 (text) ====
Index: perl/ext/Hash/Util/Util.xs
--- perl/ext/Hash/Util/Util.xs#1~27180~ 2006-02-14 09:08:08.000000000 -0800
+++ perl/ext/Hash/Util/Util.xs  2008-01-09 13:18:39.000000000 -0800
@@ -87,7 +87,7 @@
             XPUSHs( key );
         }
 
-SV*
+void
 hv_store(hvref, key, val)
        SV* hvref
        SV* key
@@ -98,7 +98,7 @@
     CODE:
     {
        if (!SvROK(hvref) || SvTYPE(SvRV(hvref)) != SVt_PVHV)
-          croak("First argument to alias_hv() must be a hash reference");
+          croak("First argument to hv_store() must be a hash reference");
        hv = (HV*)SvRV(hvref);
         SvREFCNT_inc(val);
        if (!hv_store_ent(hv, key, val, 0)) {
@@ -107,7 +107,5 @@
        } else {
            XSRETURN_YES;
        }
-
     }
-    OUTPUT:
-        RETVAL
\ No newline at end of file
+
End of Patch.

Reply via email to