Change 33004 by [EMAIL PROTECTED] on 2008/01/18 18:00:56
Avoid an unused argument in S_sv_2iuv_non_preserve() by using
conditional compilation to only pass it in if it's needed.
Affected files ...
... //depot/perl/embed.fnc#561 edit
... //depot/perl/embed.h#744 edit
... //depot/perl/proto.h#895 edit
... //depot/perl/sv.c#1487 edit
Differences ...
==== //depot/perl/embed.fnc#561 (text) ====
Index: perl/embed.fnc
--- perl/embed.fnc#560~33001~ 2008-01-18 07:28:09.000000000 -0800
+++ perl/embed.fnc 2008-01-18 10:00:56.000000000 -0800
@@ -1503,7 +1503,11 @@
s |void |del_sv |NN SV *p
# endif
# if !defined(NV_PRESERVES_UV)
+# ifdef DEBUGGING
s |int |sv_2iuv_non_preserve |NN SV *sv|I32 numtype
+# else
+s |int |sv_2iuv_non_preserve |NN SV *sv
+# endif
# endif
sR |I32 |expect_number |NN char** pattern
#
==== //depot/perl/embed.h#744 (text+w) ====
Index: perl/embed.h
--- perl/embed.h#743~33000~ 2008-01-18 06:27:36.000000000 -0800
+++ perl/embed.h 2008-01-18 10:00:56.000000000 -0800
@@ -1481,9 +1481,15 @@
#endif
# endif
# if !defined(NV_PRESERVES_UV)
+# ifdef DEBUGGING
#ifdef PERL_CORE
#define sv_2iuv_non_preserve S_sv_2iuv_non_preserve
#endif
+# else
+#ifdef PERL_CORE
+#define sv_2iuv_non_preserve S_sv_2iuv_non_preserve
+#endif
+# endif
# endif
#ifdef PERL_CORE
#define expect_number S_expect_number
@@ -3792,9 +3798,15 @@
#endif
# endif
# if !defined(NV_PRESERVES_UV)
+# ifdef DEBUGGING
#ifdef PERL_CORE
#define sv_2iuv_non_preserve(a,b) S_sv_2iuv_non_preserve(aTHX_ a,b)
#endif
+# else
+#ifdef PERL_CORE
+#define sv_2iuv_non_preserve(a) S_sv_2iuv_non_preserve(aTHX_ a)
+#endif
+# endif
# endif
#ifdef PERL_CORE
#define expect_number(a) S_expect_number(aTHX_ a)
==== //depot/perl/proto.h#895 (text+w) ====
Index: perl/proto.h
--- perl/proto.h#894~33001~ 2008-01-18 07:28:09.000000000 -0800
+++ perl/proto.h 2008-01-18 10:00:56.000000000 -0800
@@ -3972,9 +3972,15 @@
# endif
# if !defined(NV_PRESERVES_UV)
+# ifdef DEBUGGING
STATIC int S_sv_2iuv_non_preserve(pTHX_ SV *sv, I32 numtype)
__attribute__nonnull__(pTHX_1);
+# else
+STATIC int S_sv_2iuv_non_preserve(pTHX_ SV *sv)
+ __attribute__nonnull__(pTHX_1);
+
+# endif
# endif
STATIC I32 S_expect_number(pTHX_ char** pattern)
__attribute__warn_unused_result__
==== //depot/perl/sv.c#1487 (text) ====
Index: perl/sv.c
--- perl/sv.c#1486~32990~ 2008-01-17 06:23:48.000000000 -0800
+++ perl/sv.c 2008-01-18 10:00:56.000000000 -0800
@@ -1862,10 +1862,13 @@
/* For sv_2nv these three cases are "SvNOK and don't bother casting" */
STATIC int
-S_sv_2iuv_non_preserve(pTHX_ register SV *sv, I32 numtype)
+S_sv_2iuv_non_preserve(pTHX_ register SV *sv
+# ifdef DEBUGGING
+ , I32 numtype
+# endif
+ )
{
dVAR;
- PERL_UNUSED_ARG(numtype); /* Used only under DEBUGGING? */
DEBUG_c(PerlIO_printf(Perl_debug_log,"sv_2iuv_non '%s', IV=0x%"UVxf"
NV=%"NVgf" inttype=%"UVXf"\n", SvPVX_const(sv), SvIVX(sv), SvNVX(sv),
(UV)numtype));
if (SvNVX(sv) < (NV)IV_MIN) {
(void)SvIOKp_on(sv);
@@ -2143,7 +2146,11 @@
1 1 already read UV.
so there's no point in sv_2iuv_non_preserve() attempting
to use atol, strtol, strtoul etc. */
+# ifdef DEBUGGING
sv_2iuv_non_preserve (sv, numtype);
+# else
+ sv_2iuv_non_preserve (sv);
+# endif
}
}
#endif /* NV_PRESERVES_UV */
End of Patch.
