Change 33193: Remove the _ prototype, as Maintainers is used by makemeta, and in turn

[Nicholas Clark]

Change 33193 by [EMAIL PROTECTED] on 2008/02/02 17:01:43

        Remove the _ prototype, as Maintainers is used by makemeta, and in turn
        that has to be run with the newly built perl. Which can be 5.8.x.

Affected files ...

... //depot/perl/Porting/Maintainers.pm#6 edit

Differences ...

==== //depot/perl/Porting/Maintainers.pm#6 (text) ====
Index: perl/Porting/Maintainers.pm
--- perl/Porting/Maintainers.pm#5~32297~        2007-11-12 15:20:11.000000000 
-0800
+++ perl/Porting/Maintainers.pm 2008-02-02 09:01:43.000000000 -0800
@@ -7,7 +7,9 @@
 use strict;
 
 use lib "Porting";
-use 5.010;
+# Please don't use post 5.008 features as this module is used by
+# Porting/makemeta, and that in turn has to be run by the perl just built.
+use 5.008;
 
 require "Maintainers.pl";
 use vars qw(%Modules %Maintainers);
@@ -249,7 +251,6 @@
     }
 }
 
-sub warn_maintainer(_);
 my %files;
 
 sub maintainers_files {
@@ -270,19 +271,21 @@
     }
 }
 
+sub warn_maintainer {
+    my $name = shift;
+    warn "File $name has no maintainer\n" if not $files{$name};
+}
+
 sub missing_maintainers {
     my($check, @path) = @_;
     maintainers_files();
     my @dir;
-    for (@path) { if( -d ) { push @dir, $_ } else { warn_maintainer() } }
+    for my $d (@path) {
+       if( -d $d ) { push @dir, $d } else { warn_maintainer($d) }
+    }
     find sub { warn_maintainer($File::Find::name) if /$check/; }, @dir
        if @dir;
 }
 
-sub warn_maintainer(_) {
-    my $name = shift;
-    warn "File $name has no maintainer\n" if not $files{$name};
-}
-
 1;
 
End of Patch.