On Tue, Mar 11, 2008 at 12:42:11PM -0400, Jerry D. Hedden wrote:

> >  ... //depot/maint-5.8/perl/perl.h#180 edit
> >
> 
> 
> >  ==== //depot/maint-5.8/perl/perl.h#180 (text) ====
> >  Index: perl/perl.h
> >  --- perl/perl.h#179~33454~      2008-03-08 15:09:00.000000000 -0800
> >  +++ perl/perl.h 2008-03-11 08:56:33.000000000 -0700
> >  @@ -3633,12 +3633,9 @@
> >
> >   #define YYMAXDEPTH 300
> >
> >  -#ifndef assert  /* <assert.h> might have been included somehow */
> >  -#define assert(what)   PERL_DEB(                                       \
> >  -       ((what) ? ((void) 0) :                                          \
> >  -           (Perl_croak_nocontext("Assertion %s failed: file \"" __FILE__ \
> >  -                       "\", line %d", STRINGIFY(what), __LINE__),      \
> >  -           (void) 0)))
> >  +
> >  +#if defined(DEBUGGING)
> >  +#  include <assert.h>
> >   #endif
> >
> >   struct ufuncs {
> >  End of Patch.
> 
> 
> Not sure where you might have picked this up, Nick.  It's not
> part of any of the patches listed above, and it totally breaks
> the build:

By mistake. I totally forgot that I had that file open for edit.
I was trying to work out what on earth perlio.c does.

I'm still not totally the wiser :-(

I reverted it in change 33474.

On the bright side, it looks like we're not failing any assertions on
platforms that have assert.

Nicholas Clark

Reply via email to