Change 33557: Re: [PATCH] Double warning with perl -we 'my $a; substr $a, 0, 10,

[Rafael Garcia-Suarez]

Change 33557 by [EMAIL PROTECTED] on 2008/03/25 09:17:28

        Subject: Re: [PATCH] Double warning with perl -we 'my $a; substr $a, 0, 
10,
        From: Vincent Pit <[EMAIL PROTECTED]>
        Date: Sat, 22 Mar 2008 13:37:42 +0100
        Message-ID: <[EMAIL PROTECTED]>

Affected files ...

... //depot/perl/pp.c#624 edit
... //depot/perl/t/lib/warnings/9uninit#22 edit

Differences ...

==== //depot/perl/pp.c#624 (text) ====
Index: perl/pp.c
--- perl/pp.c#623~33304~        2008-02-14 00:09:36.000000000 -0800
+++ perl/pp.c   2008-03-25 02:17:28.000000000 -0700
@@ -3178,6 +3178,8 @@
                repl = SvPV_const(repl_sv_copy, repl_len);
                repl_is_utf8 = DO_UTF8(repl_sv_copy) && SvCUR(sv);
            }
+           if (!SvOK(sv))
+               sv_setpvs(sv, "");
            sv_insert(sv, pos, rem, repl, repl_len);
            if (repl_is_utf8)
                SvUTF8_on(sv);

==== //depot/perl/t/lib/warnings/9uninit#22 (text) ====
Index: perl/t/lib/warnings/9uninit
--- perl/t/lib/warnings/9uninit#21~33544~       2008-03-20 08:55:19.000000000 
-0700
+++ perl/t/lib/warnings/9uninit 2008-03-25 02:17:28.000000000 -0700
@@ -873,7 +873,6 @@
 Use of uninitialized value $m2 in substr at - line 7.
 Use of uninitialized value $g1 in substr at - line 7.
 Use of uninitialized value $m1 in substr at - line 7.
-Use of uninitialized value $m1 in substr at - line 7.
 Use of uninitialized value $g1 in substr at - line 8.
 Use of uninitialized value $m1 in substr at - line 8.
 Use of uninitialized value in scalar assignment at - line 8.
End of Patch.