Change 33566 by [EMAIL PROTECTED] on 2008/03/25 16:23:46
Subject: RE: [PATCH revised] Fix ExtUtils::Install under Cygwin
From: "Steve Hay" <[EMAIL PROTECTED]>
Message-ID: <[EMAIL PROTECTED]>
Date: Mon, 17 Mar 2008 14:36:54 -0000
"OK, so how about the attached. This fixes up -w for all compilers so
that it is symmetrical with chmod(), and adds a note to perltodo on
fixing POSIX::access() and chdir()."
The whole long thread started here:
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-03/msg00056.html
Affected files ...
... //depot/perl/lib/ExtUtils/Install.pm#59 edit
... //depot/perl/pod/perlport.pod#164 edit
... //depot/perl/pod/perltodo.pod#215 edit
... //depot/perl/win32/win32.c#298 edit
Differences ...
==== //depot/perl/lib/ExtUtils/Install.pm#59 (text) ====
Index: perl/lib/ExtUtils/Install.pm
--- perl/lib/ExtUtils/Install.pm#58~33460~ 2008-03-10 06:58:15.000000000
-0700
+++ perl/lib/ExtUtils/Install.pm 2008-03-25 09:23:46.000000000 -0700
@@ -38,11 +38,11 @@
=head1 VERSION
-1.50
+1.50_01
=cut
-$VERSION = '1.50';
+$VERSION = '1.50_01';
$VERSION = eval $VERSION;
=pod
@@ -358,7 +358,8 @@
sub _have_write_access {
my $dir=shift;
unless (defined $has_posix) {
- $has_posix= (!$Is_cygwin && eval 'local $^W; require POSIX; 1') ||
0;
+ $has_posix= (!$Is_cygwin && !$Is_Win32
+ && eval 'local $^W; require POSIX; 1') || 0;
}
if ($has_posix) {
return POSIX::access($dir, POSIX::W_OK());
==== //depot/perl/pod/perlport.pod#164 (text) ====
Index: perl/pod/perlport.pod
--- perl/pod/perlport.pod#163~33485~ 2008-03-11 15:28:09.000000000 -0700
+++ perl/pod/perlport.pod 2008-03-25 09:23:46.000000000 -0700
@@ -1581,6 +1581,11 @@
and applications are executable, and there are no uid/gid
considerations. C<-o> is not supported. (S<Mac OS>)
+C<-w> only inspects the read-only file attribute (FILE_ATTRIBUTE_READONLY),
+which determines whether the directory can be deleted, not whether it can
+be written to. Directories always have read and write access unless denied
+by discretionary access control lists (DACLs). (S<Win32>)
+
C<-r>, C<-w>, C<-x>, and C<-o> tell whether the file is accessible,
which may not reflect UIC-based file protections. (VMS)
==== //depot/perl/pod/perltodo.pod#215 (text) ====
Index: perl/pod/perltodo.pod
--- perl/pod/perltodo.pod#214~33462~ 2008-03-10 07:48:29.000000000 -0700
+++ perl/pod/perltodo.pod 2008-03-25 09:23:46.000000000 -0700
@@ -484,6 +484,31 @@
might be nice to do as Microsoft suggest here too, although, unlike the secure
functions issue, there is presumably little or no benefit in this case.
+=head2 Fix POSIX::access() and chdir() on Win32
+
+These functions currently take no account of DACLs and therefore do not behave
+correctly in situations where access is restricted by DACLs (as opposed to the
+read-only attribute).
+
+Furthermore, POSIX::access() behaves differently for directories having the
+read-only attribute set depending on what CRT library is being used. For
+example, the _access() function in the VC6 and VC7 CRTs (wrongly) claim that
+such directories are not writable, whereas in fact all directories are writable
+unless access is denied by DACLs. (In the case of directories, the read-only
+attribute actually only means that the directory cannot be deleted.) This CRT
+bug is fixed in the VC8 and VC9 CRTs (but, of course, the directory may still
+not actually be writable if access is indeed denied by DACLs).
+
+For the chdir() issue, see ActiveState bug #74552:
+http://bugs.activestate.com/show_bug.cgi?id=74552
+
+Therefore, DACLs should be checked both for consistency across CRTs and for
+the correct answer.
+
+(Note that perl's -w operator should not be modified to check DACLs. It has
+been written so that it reflects the state of the read-only attribute, even
+for directories (whatever CRT is being used), for symmetry with chmod().)
+
=head2 strcat(), strcpy(), strncat(), strncpy(), sprintf(), vsprintf()
Maybe create a utility that checks after each libperl.a creation that
==== //depot/perl/win32/win32.c#298 (text) ====
Index: perl/win32/win32.c
--- perl/win32/win32.c#297~33506~ 2008-03-13 07:31:21.000000000 -0700
+++ perl/win32/win32.c 2008-03-25 09:23:46.000000000 -0700
@@ -1510,9 +1510,22 @@
errno = ENOTDIR;
return -1;
}
+ if (S_ISDIR(sbuf->st_mode)) {
+ /* Ensure the "write" bit is switched off in the mode for
+ * directories with the read-only attribute set. Borland (at least)
+ * switches it on for directories, which is technically correct
+ * (directories are indeed always writable unless denied by DACLs),
+ * but we want stat() and -w to reflect the state of the read-only
+ * attribute for symmetry with chmod(). */
+ DWORD r = GetFileAttributesA(path);
+ if (r != 0xffffffff && (r & FILE_ATTRIBUTE_READONLY)) {
+ sbuf->st_mode &= ~S_IWRITE;
+ }
+ }
#ifdef __BORLANDC__
- if (S_ISDIR(sbuf->st_mode))
- sbuf->st_mode |= S_IWRITE | S_IEXEC;
+ if (S_ISDIR(sbuf->st_mode)) {
+ sbuf->st_mode |= S_IEXEC;
+ }
else if (S_ISREG(sbuf->st_mode)) {
int perms;
if (l >= 4 && path[l-4] == '.') {
End of Patch.
