Change 33654 by [EMAIL PROTECTED] on 2008/04/06 20:27:34
A macro used only once isn't a typing saving, and 3 macro definitions
never used are more obfuscation than clarification, so inline the only
use of SAVECOPLABEL_FREE(), and remove the unthreaded variant and
both SAVECOPLABEL()s. Exterminate! Exterminate! Exterminate!
Affected files ...
... //depot/perl/cop.h#177 edit
... //depot/perl/scope.h#90 edit
Differences ...
==== //depot/perl/cop.h#177 (text) ====
Index: perl/cop.h
--- perl/cop.h#176~33232~ 2008-02-04 05:59:21.000000000 -0800
+++ perl/cop.h 2008-04-06 13:27:34.000000000 -0700
@@ -196,7 +196,7 @@
# ifdef NETWARE
# define CopSTASH_free(c) SAVECOPSTASH_FREE(c)
# define CopFILE_free(c) SAVECOPFILE_FREE(c)
-# define CopLABEL_free(c) SAVECOPLABEL_FREE(c)
+# define CopLABEL_free(c) SAVESHAREDPV(CopLABEL(c))
# define CopLABEL_alloc(pv) ((pv)?savepv(pv):NULL)
# else
# define CopSTASH_free(c) PerlMemShared_free(CopSTASHPV(c))
==== //depot/perl/scope.h#90 (text) ====
Index: perl/scope.h
--- perl/scope.h#89~33080~ 2008-01-26 09:54:29.000000000 -0800
+++ perl/scope.h 2008-04-06 13:27:34.000000000 -0700
@@ -227,15 +227,11 @@
# define SAVECOPSTASH_FREE(c) SAVESHAREDPV(CopSTASHPV(c))
# define SAVECOPFILE(c) SAVEPPTR(CopFILE(c))
# define SAVECOPFILE_FREE(c) SAVESHAREDPV(CopFILE(c))
-# define SAVECOPLABEL(c) SAVEPPTR(CopLABEL(c))
-# define SAVECOPLABEL_FREE(c) SAVESHAREDPV(CopLABEL(c))
#else
# define SAVECOPSTASH(c) SAVESPTR(CopSTASH(c))
# define SAVECOPSTASH_FREE(c) SAVECOPSTASH(c) /* XXX not refcounted */
# define SAVECOPFILE(c) SAVESPTR(CopFILEGV(c))
# define SAVECOPFILE_FREE(c) SAVEGENERICSV(CopFILEGV(c))
-# define SAVECOPLABEL(c) SAVEPPTR(CopLABEL(c))
-# define SAVECOPLABEL_FREE(c) SAVEPPTR(CopLABEL(c))
#endif
#define SAVECOPLINE(c) SAVEI32(CopLINE(c))
End of Patch.
