Change 34918 by [EMAIL PROTECTED] on 2008/11/26 15:41:49
"If it's not private, it's public somehow." states Rafael. The most
reliable way I can see to keep our (unsupported) privates private is
to make them static whenever we can.
Affected files ...
... //depot/perl/embed.fnc#633 edit
... //depot/perl/embed.h#770 edit
... //depot/perl/op.c#1026 edit
... //depot/perl/proto.h#967 edit
Differences ...
==== //depot/perl/embed.fnc#633 (text) ====
Index: perl/embed.fnc
--- perl/embed.fnc#632~34917~ 2008-11-26 03:57:59.000000000 -0800
+++ perl/embed.fnc 2008-11-26 07:41:49.000000000 -0800
@@ -445,7 +445,7 @@
EXp |void |op_clear |NN OP* o
Ap |void |op_refcnt_lock
Ap |void |op_refcnt_unlock
-p |OP* |linklist |NN OP* o
+s |OP* |linklist |NN OP *o
p |OP* |list |NULLOK OP* o
p |OP* |listkids |NULLOK OP* o
Apd |void |load_module|U32 flags|NN SV* name|NULLOK SV* ver|...
==== //depot/perl/embed.h#770 (text+w) ====
Index: perl/embed.h
--- perl/embed.h#769~34917~ 2008-11-26 03:57:59.000000000 -0800
+++ perl/embed.h 2008-11-26 07:41:49.000000000 -0800
@@ -395,7 +395,7 @@
#define op_refcnt_lock Perl_op_refcnt_lock
#define op_refcnt_unlock Perl_op_refcnt_unlock
#ifdef PERL_CORE
-#define linklist Perl_linklist
+#define linklist S_linklist
#define list Perl_list
#define listkids Perl_listkids
#endif
@@ -2710,7 +2710,7 @@
#define op_refcnt_lock() Perl_op_refcnt_lock(aTHX)
#define op_refcnt_unlock() Perl_op_refcnt_unlock(aTHX)
#ifdef PERL_CORE
-#define linklist(a) Perl_linklist(aTHX_ a)
+#define linklist(a) S_linklist(aTHX_ a)
#define list(a) Perl_list(aTHX_ a)
#define listkids(a) Perl_listkids(aTHX_ a)
#endif
==== //depot/perl/op.c#1026 (text) ====
Index: perl/op.c
--- perl/op.c#1025~34917~ 2008-11-26 03:57:59.000000000 -0800
+++ perl/op.c 2008-11-26 07:41:49.000000000 -0800
@@ -786,7 +786,7 @@
#define LINKLIST(o) ((o)->op_next ? (o)->op_next : linklist((OP*)o))
OP *
-Perl_linklist(pTHX_ OP *o)
+S_linklist(pTHX_ OP *o)
{
OP *first;
==== //depot/perl/proto.h#967 (text+w) ====
Index: perl/proto.h
--- perl/proto.h#966~34917~ 2008-11-26 03:57:59.000000000 -0800
+++ perl/proto.h 2008-11-26 07:41:49.000000000 -0800
@@ -1446,7 +1446,7 @@
PERL_CALLCONV void Perl_op_refcnt_lock(pTHX);
PERL_CALLCONV void Perl_op_refcnt_unlock(pTHX);
-PERL_CALLCONV OP* Perl_linklist(pTHX_ OP* o)
+STATIC OP* S_linklist(pTHX_ OP *o)
__attribute__nonnull__(pTHX_1);
#define PERL_ARGS_ASSERT_LINKLIST \
assert(o)
End of Patch.
