In perl.git, the branch blead has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/50e225a377de7c314b13cbaf39b6b423215d84a7?hp=c901ad27dd1d818a2db33784bb3bad9f83c98e34>

- Log -----------------------------------------------------------------
commit 50e225a377de7c314b13cbaf39b6b423215d84a7
Author: Nicholas Clark <[email protected]>
Date:   Tue Oct 13 18:05:09 2009 +0100

    Sort MANIFEST following commit 9bc662c9c4c134e4.

M       MANIFEST

commit 08063926ad82ca2ea65fb34336bffad9b58f1ed7
Author: Nicholas Clark <[email protected]>
Date:   Tue Oct 13 18:02:46 2009 +0100

    Note that a test that regen.pl was run is TODO.

M       pod/perltodo.pod

commit c4f5d98d2d6ff10afb22794c7ca5417b71c4c306
Author: Nicholas Clark <[email protected]>
Date:   Tue Oct 13 16:51:09 2009 +0100

    Minor podification nit. *2 legs bad* B<4 legs good>.

M       pod/perlpolicy.pod
-----------------------------------------------------------------------

Summary of changes:
 MANIFEST           |    2 +-
 pod/perlpolicy.pod |    2 +-
 pod/perltodo.pod   |   18 ++++++++++++++++++
 3 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/MANIFEST b/MANIFEST
index 05ae845..64fa131 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1720,8 +1720,8 @@ cpan/Parse-CPAN-Meta/t/data/sample.yml                    
Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/data/Spreadsheet-Read.yml       Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/data/Template-Provider-Unicode-Japanese.yml     
Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/data/toolbar.yml                        
Parse::CPAN::Meta
-cpan/Parse-CPAN-Meta/t/data/utf_16_le_bom.yml.packed   Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/data/utf_16_le_bom.yml  Parse::CPAN::Meta - manually 
generated; see Porting/Maintainers.pl
+cpan/Parse-CPAN-Meta/t/data/utf_16_le_bom.yml.packed   Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/data/vanilla.yml                        
Parse::CPAN::Meta
 cpan/Parse-CPAN-Meta/t/lib/Parse/CPAN/Meta/Test.pm     Parse::CPAN::Meta 
testing library
 cpan/Parse-CPAN-Meta/uupacktool.pl                     Parse::CPAN::Meta
diff --git a/pod/perlpolicy.pod b/pod/perlpolicy.pod
index 22e0764..5f61e2f 100644
--- a/pod/perlpolicy.pod
+++ b/pod/perlpolicy.pod
@@ -91,7 +91,7 @@ different from the vision of the pumpkin holder and 
perl5-porters as a
 whole so as to cause serious problems for Perl, the pumpkin holder may
 choose to formally fork the version of the module in the core from the
 one maintained by the author.  This should not be done lightly and
-should *always* if at all possible be done only after direct input
+should B<always> if at all possible be done only after direct input
 from Larry.  If this is done, it must then be made explicit in the
 module as distributed with Perl core that it is a forked version and
 that while it is based on the original author's work, it is no longer
diff --git a/pod/perltodo.pod b/pod/perltodo.pod
index 3dbc923..b48782c 100644
--- a/pod/perltodo.pod
+++ b/pod/perltodo.pod
@@ -36,6 +36,24 @@ instead there is an intentionally simpler library, 
F<t/test.pl>. However,
 quite a few tests in F<t/> have not been refactored to use it. Refactoring
 any of these tests, one at a time, is a useful thing TODO.
 
+=head2 Test that regen.pl was run
+
+There are various generated files shipped with the perl distribution, for
+things like header files generate from data. The generation scripts are
+written in perl, and all can be run by F<regen.pl>. However, because they're
+written in perl, we can't run them before we've built perl. We can't run them
+as part of the F<Makefile>, because changing files underneath F<make> confuses
+it completely, and we don't want to run them automatically anyway, as they
+change files shipped by the distribution, something we seek not do to.
+
+If someone changes the data, but forgets to re-run F<regen.pl> then the
+generated files are out of sync. It would be good to have a test in
+F<t/porting> that checks that the generated files are in sync, and fails
+otherwise, to alert someone before they make a poor commit. I suspect that this
+would require adapting the scripts run from F<regen.pl> to have dry-run
+options, and invoking them with these, or by refactoring them into a library
+that does the generation, which can be called by the scripts, and by the test.
+
 =head2 Automate perldelta generation
 
 The perldelta file accompanying each release summaries the major changes.

--
Perl5 Master Repository

Reply via email to