In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/3e2f783e67807d5cec489704325d99148992cf37?hp=1c2c5f8e76ec81406f2cf2adeeadbd2a42dc5549>
- Log ----------------------------------------------------------------- commit 3e2f783e67807d5cec489704325d99148992cf37 Author: Nicholas Clark <[email protected]> Date: Tue Oct 20 08:11:07 2009 +0100 MAD-only code in S_swallow_bom() duplicated the actions of sv_setpvn() Remove it. All its writes were byte-for-byte identical with the memory they overwrote. The bugs it attempts to fix are real, but caused by the design and implementation of other parts of this routine and S_utf16_textfilter(). ----------------------------------------------------------------------- Summary of changes: toke.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/toke.c b/toke.c index c7ec476..610cc24 100644 --- a/toke.c +++ b/toke.c @@ -12714,18 +12714,9 @@ S_swallow_bom(pTHX_ U8 *s) PL_bufend - (char*)s - 1, &newlen); sv_setpvn(PL_linestr, (const char*)news, newlen); -#ifdef PERL_MAD - s = (U8*)SvPVX(PL_linestr); - Copy(news, s, newlen, U8); - s[newlen] = '\0'; -#endif Safefree(news); SvUTF8_on(PL_linestr); s = (U8*)SvPVX(PL_linestr); -#ifdef PERL_MAD - /* FIXME - is this a general bug fix? */ - s[newlen] = '\0'; -#endif PL_bufend = SvPVX(PL_linestr) + newlen; } #else -- Perl5 Master Repository
