In perl.git, the branch maint-5.12 has been updated <http://perl5.git.perl.org/perl.git/commitdiff/2bd95abe0891bd0dc195faba8e7a62bed14df7ea?hp=765c7045405cdf0f0fd923088ca05f84574e6b08>
- Log ----------------------------------------------------------------- commit 2bd95abe0891bd0dc195faba8e7a62bed14df7ea Author: Ãvar Arnfjörð Bjarmason <[email protected]> Date: Thu May 13 20:05:35 2010 +0000 Skip suid File::Copy tests on a nosuid partition These tests were being skipped on OpenBSD, but nosuid partitions can exist on other systems too. Now it just checks if it can create a suid directory, if not the tests are skipped. Perl builds without errors in a nosuid /tmp with this patch. M lib/File/Copy.t commit ffba991b12f173f40fd2b2ab3721aeb672282a74 Author: Ãvar Arnfjörð Bjarmason <[email protected]> Date: Sun May 9 12:38:29 2010 +0000 Clarify that mail to perlbug also goes to p5p The wording added in 64a8e22bd3 didn't clarify that mail to perlbug is also forwarded to perl5-porters. Make this section clearer so that it now explains that perlbug is just perl5-porters + RT tracking. See the discussion after Craig A. Berry's comment in RT #73914 for reference. M pod/perlrepository.pod ----------------------------------------------------------------------- Summary of changes: lib/File/Copy.t | 13 ++++++++++--- pod/perlrepository.pod | 11 +++++++---- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/lib/File/Copy.t b/lib/File/Copy.t index b6e4a19..63c99d1 100644 --- a/lib/File/Copy.t +++ b/lib/File/Copy.t @@ -237,6 +237,14 @@ for my $cross_partition_test (0..1) { } } +my $can_suidp = sub { + my $dir = "suid-$$"; + my $ok = 1; + mkdir $dir or die "Can't mkdir($dir) for suid test"; + $ok = 0 unless chmod 2000, $dir; + rmdir $dir; + return $ok; +}; SKIP: { my @tests = ( @@ -251,9 +259,8 @@ SKIP: { my $skips = @tests * 6 * 8; - # TODO - make this skip fire if we're on a nosuid filesystem rather than guessing by OS - skip "OpenBSD filesystems default to nosuid breaking these tests", $skips - if $^O eq 'openbsd'; + my $can_suid = $can_suidp->(); + skip "Can't suid on this $^O filesystem", $skips unless $can_suid; skip "-- Copy preserves RMS defaults, not POSIX permissions.", $skips if $^O eq 'VMS'; skip "Copy doesn't set file permissions correctly on Win32.", $skips diff --git a/pod/perlrepository.pod b/pod/perlrepository.pod index f13be01..d24b574 100644 --- a/pod/perlrepository.pod +++ b/pod/perlrepository.pod @@ -359,10 +359,13 @@ Now you should create a patch file for all your local changes: % git format-patch origin 0001-Rename-Leon-Brocard-to-Orange-Brocard.patch -You should now send an email to either [email protected] or [email protected] with a description of your changes, and include -this patch file as an attachment. The perlbug address is preferred, -but use perl5-porters for patches intended for discussion. +You should now send an email to to +L<[email protected]|mailto:[email protected]> with a description of your +changes, and include this patch file as an attachment. In addition to +being tracked by RT, mail to perlbug will automatically be forwarded +to perl5-porters. You should only send patches to +L<[email protected]|mailto:[email protected]> directly if the +patch is not ready to be applied, but intended for discussion. See the next section for how to configure and use git to send these emails for you. -- Perl5 Master Repository
