In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/ef9721fc60cacaeb74316653681a979701a8eb30?hp=7cdf3308efb26eafabf57652e17fccd59e61076e>
- Log ----------------------------------------------------------------- commit ef9721fc60cacaeb74316653681a979701a8eb30 Author: Craig A. Berry <[email protected]> Date: Mon Dec 13 07:21:28 2010 -0600 Explicitly close filehandle in ExtUtils::CBuilder::have_compiler(). A recent change removed the lexical scope that would have caused the lexical filehandle on the temporary source file to get closed automatically. If the filehandle is still open for write, you can't compile it or delete unless it's open for shared access, which is not the default on VMS (and deleting an open fle might be a problem on Windows as well). Without deleting the .c files, a subsequent make (even after a make realclean) will identify CBuilder as an XS extension and fail when it can't compile the non-existent CBuilder.c, which breaks the build for second and subsequent runs of a smoke test. ----------------------------------------------------------------------- Summary of changes: .../lib/ExtUtils/CBuilder/Base.pm | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpan/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm b/cpan/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm index b1c5dc5..3249032 100644 --- a/cpan/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm +++ b/cpan/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm @@ -198,6 +198,7 @@ sub have_compiler { else { print $FH "int boot_compilet() { return 1; }\n"; } + close $FH; my ($obj_file, @lib_files); eval { -- Perl5 Master Repository
