In perl.git, the branch smoke-me/re-tests has been created
<http://perl5.git.perl.org/perl.git/commitdiff/655249ccc4f6de3fea4449d8d3a16e7a9fd16d2c?hp=0000000000000000000000000000000000000000>
at 655249ccc4f6de3fea4449d8d3a16e7a9fd16d2c (commit)
- Log -----------------------------------------------------------------
commit 655249ccc4f6de3fea4449d8d3a16e7a9fd16d2c
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 15:23:42 2011 +0000
Now that pat_{advanced,rt_report}.t use test.pl, use skip_all_if_miniperl().
Neither can run during minitest as miniperl can't load support code for %+
and
%-. If your build is so unwell that it's fallen back to minitest, your
problems
are bigger than "advanced" regular expression features not working.
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
commit d4dec1b4dd0cce339ea77fb681dbb9ffd1eb2e00
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 15:13:17 2011 +0000
Eliminate t/re/ReTest.pl. require './test.pl' directly in its 3 (former)
users.
M MANIFEST
D t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
commit 1b70a17d3ad1c63a4bab05b4203addc1164e5b7e
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 14:54:11 2011 +0000
Move setting $IS_ASCII and $IS_EBCDIC from ReTest.pl to test.pl
As test.pl doesn't C<use vars> for either (and shouldn't start), modify the
users to fully qualify the variables, to avoid strict vars errors.
M t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
M t/test.pl
commit 6639cfca9bbfd294ea57d7f9b8f492cd026d1667
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 14:43:33 2011 +0000
Eliminate $::ordA from ReTest.pl, inlining its constant value in its only
user.
M t/re/ReTest.pl
M t/re/pat_advanced.t
commit aaa45cde70eee034912457eb6398374113d47871
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 14:39:23 2011 +0000
Eliminate eval_ok() from ReTest.pl by inlining the logic in the only caller.
Refactor the 19 remaining calls into a data driven loop in pat.t, inlining
the
eval logic.
M t/re/ReTest.pl
M t/re/pat.t
commit ad90de9dfbf8b9e2205e6db17d8449e86c8e078d
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 13:48:43 2011 +0000
Replace three uses of eval_ok() with is() as the tested code doesn't die.
It's not clear whether the code ever threw exceptions. Not using eval_ok()
here
makes subsequent refactoring a lot simpler.
M t/re/pat_rt_report.t
commit 621458a0780de8e7a21f2195c6cfc435a678856c
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 13:30:48 2011 +0000
Refactor some calls to eval_ok() into is(eval $foo ...) and is($@, '')
pairs.
This gives better diagnostics on failure.
M t/re/pat.t
M t/re/pat_advanced.t
commit a0f0babe3205764a5f641825259cc82fdc49300f
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 13:03:03 2011 +0000
Add warnings_like() in test.pl to replace must_warn() in ReTest.pl.
warnings_like() provides a subset of the functionality of the routine of the
same name in Test::Warn.
M t/re/ReTest.pl
M t/re/pat_advanced.t
M t/test.pl
commit 2e049bdae5aaa2311a6569ad8a745fc20391a2b2
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 12:19:53 2011 +0000
Add warning_like() in test.pl to replace some uses of ReTest.pl's
must_warn().
warning_like() provides a subset of the functionality of the routine of the
same name in Test::Warn. Remove the definition of must_warn() in
t/re/subst.t,
which had been copied from t/re/ReTest.pl from when ReTest.pl and test.pl
clashed.
M t/re/pat_advanced.t
M t/re/subst.t
M t/test.pl
commit aa5052ea08171f73069b70128fc12b4f089d3d35
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 12:04:03 2011 +0000
In pat_advanced.t, refactor 6 calls to must_warn() into a loop.
M t/re/pat_advanced.t
commit 7a9cb3cd902f8962b3a4f476ad7d6b58e798ff6e
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 11:04:44 2011 +0000
Improve warning_is() to verify that exactly 0 or 1 warning has been seen.
M t/test.pl
commit 7052b5686d831d2d5a9877ff35c2e09c069ce300
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 10:57:43 2011 +0000
Add warning_is() in test.pl to replace may_not_warn() in ReTest.pl.
warning_is() provides a subset of the functionality of the routine of the
same
name in Test::Warn.
M t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/test.pl
commit c7fca11892516061ef943a173065e365c81f0c6e
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 10:44:50 2011 +0000
Eliminate must_die() from ReTest.pl, which is only used 3 times in pat.t
Replace it with is(eval ..., undef); like($@, $error);
It's not viable to emulate Test::Exception's throws_ok() in test.pl, as it
only takes a code reference, whereas these tests are for compilation errors
and so use string eval.
M t/re/ReTest.pl
M t/re/pat.t
commit eaea7250e86659765e02ca4bb2e67ba1f4fb09cc
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 10:07:01 2011 +0000
Move the loading of %Config from ReTest.pl to the only use point in pat.t
M t/re/ReTest.pl
M t/re/pat.t
commit df8f470053083b047ccd6c8b33ab0aa03dec531e
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 06:42:00 2011 +0000
Prune redundant blank lines.
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
commit 93b530dfcb5871bf1fa2e4e3479a8a776ef837c5
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 06:32:07 2011 +0000
t/re/pat_{psycho,re_eval,special_cc}.t can use test.pl direct.
They no longer use any of the extra functions of ReTest.pl
M t/re/pat_psycho.t
M t/re/pat_re_eval.t
M t/re/pat_special_cc.t
commit c54c653e9095bfc764a0d4f24ab1d87352536601
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 06:23:18 2011 +0000
Eliminate the placeholder text 'Noname test'.
It's no longer needed now that the migration from ReTest.pl's TAP generation
functions is completed.
M t/re/pat_re_eval.t
M t/re/pat_rt_report.t
commit 1cfc148ada668c550a129db333e8a89182dccfa9
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 06:08:18 2011 +0000
Eliminate iseq() from ReTest.pl by changing all callers to use is().
M t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_re_eval.t
M t/re/pat_rt_report.t
M t/re/pat_special_cc.t
commit fbe6cc8830c059f5b6ea8c8a5dd2f58abdb1b5c3
Author: Nicholas Clark <[email protected]>
Date: Sat Mar 5 05:38:18 2011 +0000
Eliminate nok() from ReTest.pl by refactoring all uses to other test
functions.
M t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
commit 4a4963e9d0db5befa4bf36ffd79a7eafc0fc148e
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 22:32:24 2011 +0000
Refactor ReTest.pl to use test.pl for testing functions and TAP generation.
Provide compatibility implementations of nok(), and iseq(), which will be
removed once their callers are refactored. Eliminate isneq(), which is now
unused.
M t/re/ReTest.pl
commit 6ab91edd3a4e6b151d49e108d91d2bf5e249cf5b
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 21:55:46 2011 +0000
Slight tweaks to regexp tests so that they still produce sane TAP with
test.pl
Explicitly escape non-printable characters in test descriptions, instead of
relying on some part of the TAP generation code to do so. Use diag()
instead of
passing 3 arguments to ok(). Add a mininal diag() implementation to
ReTest.pl
M t/re/ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
commit dfb063bebbc203898df933234ea4d77365fee135
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 22:02:23 2011 +0000
Use $::TODO, instead of $TODO, and relying on use vars '$TODO' in ReTest.pl
M t/re/pat.t
M t/re/pat_advanced.t
M t/re/pat_rt_report.t
commit 0b778bd8e624eea6f7ab365b80b6ca13eeac1f01
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 20:47:28 2011 +0000
Remove the line number from the test description output by ReTest.pl
This means that the TAP it generates is much closer to that generated by
test.pl
M t/re/ReTest.pl
commit d5351f68343997fae2cf3d9d675e15232b214654
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 18:25:15 2011 +0000
Eliminate the global override $BugId from t/re/ReTest.pl
M t/re/ReTest.pl
commit 508fe898571122c2cef8a2d2d97aa95864a6e7e5
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 18:24:19 2011 +0000
Eliminate use of $::BugId in t/re/pat_rt_report.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
tests, and adding the seemingly useless 'Noname test;', as that was what
t/re/ReTest.pl's _ok() was defaulting to)
M t/re/pat_rt_report.t
commit 828b1fa4d8cadf24916e7350fe815f29b4882f65
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 16:14:20 2011 +0000
Eliminate use of $::BugId in t/re/pat_re_eval.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
tests, and adding the seemingly useless 'Noname test;', as that was what
t/re/ReTest.pl's _ok() was defaulting to)
M t/re/pat_re_eval.t
commit fa091353dc3384196d7a08e115727e971ad77b7a
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 16:04:21 2011 +0000
Eliminate the global override $Message from t/re/ReTest.pl
M t/re/ReTest.pl
commit 21f4bd7108fbdb1e7cbd18582a727b892e6da8a0
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 16:03:37 2011 +0000
Eliminate use of $::Message in t/re/pat_re_eval.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
tests.)
M t/re/pat_re_eval.t
commit a74a6169dafd87509452de85bb9e573838050ff8
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 15:31:17 2011 +0000
Eliminate use of $::Message in t/re/pat_rt_report.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
tests.)
M t/re/pat_rt_report.t
commit 6f9b758887385fd053a12ec684246f4920e750ca
Author: Nicholas Clark <[email protected]>
Date: Fri Mar 4 10:02:36 2011 +0000
Eliminate use of $::Message in t/re/pat_advanced.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
tests.)
M t/re/pat_advanced.t
commit 496c1ad19e3b266831488e2b7ebf4771d4b3084b
Author: Nicholas Clark <[email protected]>
Date: Thu Mar 3 14:45:25 2011 +0000
Eliminate use of $::Message in t/re/pat.t
Pass the message in explicitly to the test functions. Change to use test.pl
compatible functions where appropriate. For now avoid renumbering lines, or
any other change that changes the generated TAP output. (Hence no splitting
of
tests.)
M t/re/pat.t
commit 0936e8b6f5384b6cc58c88ac295f5c9c2ec06dcc
Author: Nicholas Clark <[email protected]>
Date: Thu Mar 3 14:44:31 2011 +0000
In ReTest.pl, provide is(), isnt(), like() and unlike(), equivalent to
test.pl
This will ease the migration of the users of ReTest.pl to test.pl
M t/re/ReTest.pl
commit 154439eeee77f5036a93ef1ee7a5282985be447f
Author: Nicholas Clark <[email protected]>
Date: Wed Mar 2 16:23:17 2011 +0000
In ReTest.pl, convert iseq() and isneq() to the same logic as test.pl's
is/isnt
Previously both would stringify first, then compare, which would mean that
any overloaded objects would have their stringify method called, instead of
'eq' or 'ne'.
M t/re/ReTest.pl
commit d04250213acc93444664c3cfd81f04e872c96d56
Author: Nicholas Clark <[email protected]>
Date: Thu Mar 3 08:30:16 2011 +0000
In test.pl, change like() and unlike() to avoid copying the tested scalar.
This means that side effects of matching regexps on it are maintained,
specifically the value of pos, making test.pl more useful for tests in t/re.
This is a subtle divergence from the behaviour of Test::More::{like,unlike}
M t/test.pl
-----------------------------------------------------------------------
--
Perl5 Master Repository
