In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/c65895fd5522f4f86bf15255ed3d9f701cde751d?hp=84f0440554c1fed2981f0ba8a4b2785919f5d734>
- Log ----------------------------------------------------------------- commit c65895fd5522f4f86bf15255ed3d9f701cde751d Author: Jan Dubois <[email protected]> Date: Fri Mar 11 12:34:39 2011 -0800 Don't run crashing TODO tests for release builds. Crashes on Windows will display an error dialog that has to be manually dismissed. This is a bad experience for casual users not familiar with the practice of TODO tests and might create doubt in the overall quality of the release. ----------------------------------------------------------------------- Summary of changes: t/re/reg_eval_scope.t | 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/t/re/reg_eval_scope.t b/t/re/reg_eval_scope.t index 43af443..7bec654 100644 --- a/t/re/reg_eval_scope.t +++ b/t/re/reg_eval_scope.t @@ -126,15 +126,25 @@ on; fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{die})'; eval { my $a=4; my $b=5; "a" =~ /(?{die})a/ }; print $a,$b" CODE -fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{last})'; - { my $a=4; my $b=5; "a" =~ /(?{last})a/ }; print $a,$b + +SKIP: { + # The remaining TODO tests crash, which will display an error dialog + # on Windows that has to be manually dismissed. We don't want this + # to happen for release builds: 5.14.x, 5.16.x etc. + skip "Don't run crashing TODO test on release build", 3 + if $::TODO && $^O eq "MSWin32" && (int($]*1000) & 1) == 0; + + fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{last})'; + { my $a=4; my $b=5; "a" =~ /(?{last})a/ }; print $a,$b CODE -fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{next})'; - { my $a=4; my $b=5; "a" =~ /(?{last})a/ }; print $a,$b + fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{next})'; + { my $a=4; my $b=5; "a" =~ /(?{last})a/ }; print $a,$b CODE -fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{return})'; - print sub { my $a=4; my $b=5; "a" =~ /(?{return $a.$b})a/ }->(); + fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{return})'; + print sub { my $a=4; my $b=5; "a" =~ /(?{return $a.$b})a/ }->(); CODE +} + fresh_perl_is <<'CODE', '45', { stderr => 1 }, '(?{goto})'; my $a=4; my $b=5; "a" =~ /(?{goto _})a/; die; _: print $a,$b CODE -- Perl5 Master Repository
