In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/040d2336f034a9225639af9abaec69a2e6da4301?hp=4899916ae02f106df163459798ebe3b2a863afb6>
- Log ----------------------------------------------------------------- commit 040d2336f034a9225639af9abaec69a2e6da4301 Author: Father Chrysostomos <[email protected]> Date: Thu Jun 30 19:19:14 2011 -0700 Add another address for Claes Jakobsson M Porting/checkAUTHORS.pl commit f39335f980be44f86fada26f29f9aa7e50e2e686 Author: Claes Jakobsson <[email protected]> Date: Thu Jun 30 22:09:13 2011 +0200 Report a better error when trying to use negative version numbers instead of 'Invalid version format (non-numeric data)' as it currently does. Also update documentation that version should be a positive number. M pod/perlmodlib.PL M util.c ----------------------------------------------------------------------- Summary of changes: Porting/checkAUTHORS.pl | 1 + pod/perlmodlib.PL | 2 +- util.c | 3 +++ 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/Porting/checkAUTHORS.pl b/Porting/checkAUTHORS.pl index 2d4c50c..266bee3 100755 --- a/Porting/checkAUTHORS.pl +++ b/Porting/checkAUTHORS.pl @@ -536,6 +536,7 @@ brian.d.foy\100gmail.com bdfoy\100cpan.org BQW10602\100nifty.com sadahiro\100cpan.org chromatic\100wgz.org chromatic\100rmci.net +claes\100surfar.nu claes\100versed.se clintp\100geeksalad.org cpierce1\100ford.com clkao\100clkao.org clkao\100bestpractical.com corion\100corion.net corion\100cpan.org diff --git a/pod/perlmodlib.PL b/pod/perlmodlib.PL index a82f22f..26f69cb 100644 --- a/pod/perlmodlib.PL +++ b/pod/perlmodlib.PL @@ -1328,7 +1328,7 @@ Give the module a version/issue/release number. To be fully compatible with the Exporter and MakeMaker modules you should store your module's version number in a non-my package -variable called $VERSION. This should be a floating point +variable called $VERSION. This should be a positive floating point number with at least two digits after the decimal (i.e., hundredths, e.g, C<$VERSION = "0.01">). Don't use a "1.3.2" style version. See L<Exporter> for details. diff --git a/util.c b/util.c index 318c965..093b70e 100644 --- a/util.c +++ b/util.c @@ -4494,6 +4494,9 @@ dotted_decimal_version: /* found just an integer */ goto version_prescan_finish; } + else if ( *d == '-') { + BADVERSION(s,errstr,"Invalid version format (negative version number)"); + } else if ( d == s ) { /* didn't find either integer or period */ BADVERSION(s,errstr,"Invalid version format (non-numeric data)"); -- Perl5 Master Repository
