In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/42932e1a33ce479972ea1398a41965265d8fb06b?hp=bdba49ad065980ae3ab85147a822d5b9098d33ca>
- Log ----------------------------------------------------------------- commit 42932e1a33ce479972ea1398a41965265d8fb06b Author: Father Chrysostomos <[email protected]> Date: Sat Dec 3 09:36:38 2011 -0800 Remove SvTAINT from sv_sethek This was copied from sv_usepvn_flags in commit 58b643af9. It is unnecessary, and probably incorrect, as heks are not tainted. Why sv_sethek used sv_usepvn_flags to begin with I donât know, but I imagine it was for brevityâs sake. This code was ultimately derived from newSVhek, which doesnât use sv_usepvn_flags. Because of that, and because it is now far enough removed from sv_usepvn_flags, I have removed the comment referring to it. ----------------------------------------------------------------------- Summary of changes: sv.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/sv.c b/sv.c index a2df6f5..0aebda2 100644 --- a/sv.c +++ b/sv.c @@ -4583,13 +4583,9 @@ Perl_sv_sethek(pTHX_ register SV *const sv, const HEK *const hek) return; } { - /* Emulate what sv_usepvn_flags does; it can't be called - directly, because it assumes that the data for the PV is at the - start of a malloced block */ SV_CHECK_THINKFIRST_COW_DROP(sv); SvUPGRADE(sv, SVt_PV); SvPV_set(sv,(char *)HEK_KEY(share_hek_hek(hek))); - SvTAINT(sv); SvCUR_set(sv, HEK_LEN(hek)); SvLEN_set(sv, 0); SvREADONLY_on(sv); -- Perl5 Master Repository
