In perl.git, the branch sprout/misc-post-5.16 has been created
<http://perl5.git.perl.org/perl.git/commitdiff/c6de567bc511eb66ecd0e11ac485fd63bdcc9fc1?hp=0000000000000000000000000000000000000000>
at c6de567bc511eb66ecd0e11ac485fd63bdcc9fc1 (commit)
- Log -----------------------------------------------------------------
commit c6de567bc511eb66ecd0e11ac485fd63bdcc9fc1
Author: jkeenan <[email protected]>
Date: Fri May 11 22:32:38 2012 -0700
Document hashref_locked() and hashref_unlocked(). Add tests for them,
include debugging by Father C++.
Make lock_hash_recurse() unlock_hash_recurse() exportable; include them in
SYNOPSIS; write tests for them.
Revise 'carp test' test. In general, tests of error messages should be
written
with like() rather than is(). Why? Because we rarely want to test for the
complete error message if that requires us to exactly calculate strings such
as the line number at which an error occurred.
M ext/Hash-Util/lib/Hash/Util.pm
M ext/Hash-Util/t/Util.t
commit 57f26aff6127fc54a1e833e94a03589d89e32ca9
Author: Father Chrysostomos <[email protected]>
Date: Mon Apr 30 17:07:31 2012 -0700
Correct comment typo in op.h
M op.h
commit cc7c82798881d8cc55dcad08cdf39f138bc43f40
Author: Father Chrysostomos <[email protected]>
Date: Sat Apr 28 14:33:17 2012 -0700
DosGlob.pm: Fix pod syntax
M lib/File/DosGlob.pm
commit e0a465fe243992158eae0f0ae5f8ed809fc11763
Author: Father Chrysostomos <[email protected]>
Date: Fri Apr 27 13:18:36 2012 -0700
Remove obsolete comment from DosGlob.pm
This comment was added by commit 37248846, without explanation.
DosGlob.pm already had âuse strictâ three days before that, added in
commit b75c8c73, three days earlier.
I can only assume that 37248846 was written before b75c8c73 was
applied, and that simply adding âuse strictâ didnât work, considering
that b75c8c73 changed quite a few things to make things strict-safe.
M lib/File/DosGlob.pm
commit c61787090bcc903ddb3bf16d9b74961aa23ba502
Author: Father Chrysostomos <[email protected]>
Date: Fri Apr 27 13:18:07 2012 -0700
Increase $File::DosGlob::VERSION to 1.07
M lib/File/DosGlob.pm
commit 8eb5a31cfdc342267148b05a597fb85e94a84ba5
Author: Father Chrysostomos <[email protected]>
Date: Wed Apr 25 18:29:12 2012 -0700
Make lvalue subs copy returned PADTMPs in rvalue cx
I was trying to write a JAPH, but did not get what I expected:
$ ./perl -Ilib -e '@UNIVERSAL::ISA = CORE; print "just another "->ucfirst,
"perl hacker,\n"->ucfirst'
Perl hacker,
Perl hacker,
This happened because coresubs use leavesublv, to avoid copying the
return value wastefully.
But since this is exactly the same ucfirst op being called each time
(the one in &CORE::ucfirstâs op tree), and since ucfirst uses TARG, we
end up with the same scalar.
We have the same problem with lvalue subs:
$ ./perl -Ilib -e 'sub UNIVERSAL::ucfirst :lvalue { ucfirst $_[0] } print
"just another "->ucfirst, "perl hacker,\n"->ucfirst'
Perl hacker,
Perl hacker,
(This is not a regression, as 5.14 gave âCan't modify ucfirst in
lvalue subroutine returnâ.)
So âfixingâ coresubs would not be a solution, but a workaround.
The solution therefore is for leavesublv to copy PADTMPs in
rvalue context.
Commit 80422e24c fixed this for potential lvalue list context (i.e.,
for(lvsub()) {...}), but it wasnât sufficient.
M pp_ctl.c
M t/op/coresubs.t
M t/op/sub_lval.t
commit b8060ab1fffe9a5b33689574bb551b451026b633
Author: Father Chrysostomos <[email protected]>
Date: Wed Apr 25 14:08:48 2012 -0700
scope.c: Simplify and clarify comment
This comment seems to imply that this code is just working around a
problem in gv.c, which we could simply correct there. Iâve already
tried making the quoted code in gv.c handle *^H without a hash, but it
doesnât actually solve the problem. The real problem is that rv2hv
could also add a hash to *^H, via GvHVn, and that is simply not set up
to deal with autovivifying magic at all, and probably shouldnât be.
Also, quoting a piece of code that occurs elsewhere is just asking for
it to drift apart. By this time, the code in gv.c that is quoted in
scope.c is actually three times the length now, and looks completely
different.
M scope.c
commit 9c7f2e22b324d322ffc6a1f795b8cfe557ea8a19
Author: Dagfinn Ilmari Mannsåker <[email protected]>
Date: Mon Apr 16 01:05:52 2012 +0100
Don't warn about "ambiguous without parens" for ctrl-glob
This fixes the following bogus warning [perl #112456]:
$ perl -e 'undef *^H'
Warning: Use of "undef" without parentheses is ambiguous at -e line 1.
Compare to the non-warning variant:
$ perl -e 'undef *{^H}'
M t/lib/warnings/toke
M toke.c
commit 46dbc87f2c2a38bd5e02ac48f3b0a5f416249f30
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 18:10:21 2012 -0700
[perl #112418] Fix POD paragraph formatting
There was no empty line before a verbatim paragraph, making it
not verbatim.
M pod/perlfunc.pod
commit 8a6b6d0d0f582ba15f1a1e0941ab8f46f13a9f3f
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 18:01:50 2012 -0700
Increase $Hash::Util::VERSION to 0.12
M ext/Hash-Util/lib/Hash/Util.pm
commit f58e2df4237f8745623719f64eb002c0048f2c7b
Author: jkeenan <[email protected]>
Date: Sun Apr 22 20:59:33 2012 -0400
Add subroutines hash_locked() and hashref_locked() to Hash::Util.
Make @EXPORT_OK, synopsis, and list of functions tested with
can_ok() consistent with one another. Rationalize the way
functions are grouped within @EXPORT_OK and the other locations.
Add tests for hash_locked(), hashref_locked(), hash_unlocked() and
hashref_unlocked(). Add descriptions for several unit tests which
lacked them.
For RT #112126.
M ext/Hash-Util/lib/Hash/Util.pm
M ext/Hash-Util/t/Util.t
commit ac21a34c96d7a679e6587c0bf19edde0517f64bd
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 17:58:04 2012 -0700
File::Find: typo
M lib/File/Find.pm
commit 8ec39639bd414dff96af8e05a0cfa7efa751f341
Author: jkeenan <[email protected]>
Date: Fri Apr 6 20:20:59 2012 -0400
Individual files may appear in list of directories to be searched.
Document that, then demonstrate that with additional tests.
For RT #59750.
M lib/File/Find.pm
commit bf12b6cf2d6e39ef548ba5dfa5835deebb3db155
Author: jkeenan <[email protected]>
Date: Thu Apr 5 20:41:14 2012 -0400
Individual files may appear in list of directories to be searched.
Document that, then demonstrate that with additional tests.
For RT #59750.
M lib/File/Find/t/find.t
commit 357be75edb88bca2fc1bb54d7de1ac7f39b57125
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 17:01:00 2012 -0700
Increase $File::Find::VERSION to 1.21
M lib/File/Find.pm
commit 0ed4589757df32b3c198b40142d502b25d881649
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 16:00:36 2012 -0700
[perl #112358] Storable: Donât create RV with no refcnt
Otherwise assigning to it will cause the referent to be freed, because
nothing but Storable knows that it has no reference count.
Storable.xs was creating a new RV without increasing the refe-
rence count on the referent. It was then using it to call the
STORABLE_freeze method on the object. Since Perl passes arguments
by reference, it was possible to unref the reference by assigning to
$_[0] within STORABLE_freeze. That would cause the objectâs reference
count to go down.
M dist/Storable/Storable.xs
M dist/Storable/t/blessed.t
commit 07e3dde80453bbb544409f0bff758e043ed14752
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 16:00:13 2012 -0700
Increase $Storable::VERSION to 2.35
M dist/Storable/Storable.pm
commit 35c2ccf9d084375999c6d53d4c7420b76cf1f9e3
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 13:48:19 2012 -0700
Remove todo for UTF8 source filters
Source filters donât really make sense on character streams. They are
designed for streams of bytes coming straight from a file. Things
stop making sense if you have âuse utf8â in a UTF-8 scalar (does that
mean double-decode?).
Itâs for this reason that evalbytes respects source filters, while
eval does not. (It doesnât outside the unicode_eval feature, because
it was never really thought about and the implementation didnât take
it into account, resulting in strange behaviour. It doesnât with the
unicode_eval feature, because it was intentionally prohibited.)
M Porting/todo.pod
commit 42be8f14391c28fab4d445a41055fc692a4d6ae6
Author: Father Chrysostomos <[email protected]>
Date: Tue Apr 24 13:31:45 2012 -0700
[perl #112184] Handle $^N in Perl_magic_set
$^N is a magical variable, like $1 and $2, with the usual âsvâ
magic. So it is handled by Perl_magic_get and Perl_magic_set. But
Perl_magic_set didnât have a case for it, so it simply ignored it and
did nothing, like a tied variable with an empty STORE method.
Now assigning to $^N has the same affect as assigned to the numbered
variable to which it corresponds. If there is no corresponding cap-
ture from the last match, or in the absence of regexp plugins, it
croaks with âModification of a read-only valueâ.
M mg.c
M t/re/pat.t
commit a4379928f5e3463aea335d2baf51df4ba5fad0dc
Author: Father Chrysostomos <[email protected]>
Date: Mon Apr 23 23:03:17 2012 -0700
perldata: Consistent spaces after dots
M pod/perldata.pod
commit fc5a599e3cb21b6bdd89bb609cf9e0254d43d6f0
Author: Father Chrysostomos <[email protected]>
Date: Mon Apr 23 20:29:13 2012 -0700
Copy call checker when cloning closure prototype
Otherwise cv_set_call_checker has no effect inside an attribute han-
dler for a closure.
M embed.fnc
M embed.h
M ext/XS-APItest/t/call_checker.t
M mg.c
M mg_raw.h
M mg_vtable.h
M op.c
M pad.c
M pod/perlguts.pod
M proto.h
M regen/mg_vtable.pl
commit 5c1cf5ec1de44fcce2028707c3cee391b92495d0
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 22:32:09 2012 -0700
[perl #111000] Let hv_store work on hint hashes
Magic attached to hash elements has its key stored differently depend-
ing on how it was supplied to hv_common. hv_store passes a string/
length pair to hv_common, while hv_store_ent passes an SV.
magic_clearhint wasnât able to handle string/length pairs, and only
worked with SVs, resulting in assertion failures or crashes.
This commit fixes magic_clearhint, so that XS code can use hv_store on
hint hashes.
M ext/XS-APItest/t/hash.t
M mg.c
commit 55fa5f85a7d13997f38f76e4ca2ad4386b240284
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 22:27:50 2012 -0700
mg.c:magic_clearhint: remove redundant PERL_UNUSED_ARG
M mg.c
commit 6e94168592fddc42627db8f2606ba92e994f3fe6
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 22:06:57 2012 -0700
XS-APItest/t/hash.t: comment typo
M t/op/hash.t
commit f89d0af6dfd1ee9cd8c3df4708bb40199647b472
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 22:05:24 2012 -0700
Increase $XS::APItest::VERSION to 0.39
M ext/XS-APItest/APItest.pm
commit ea187c79477a1488aafe86ccbc8db829a97680a5
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 20:35:43 2012 -0700
pp_ctl.c:pp_goto: Donât repeat yourself
No need to say DIE three times.
M pp_ctl.c
commit b7325b154f891f78e86d4fc293b6b8a344cea1a9
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 20:34:24 2012 -0700
Produce the right error for goto "\0"
Since we have supported for embedded nulls in strings, we shouldnât
be using if(*label) to see whether label has a non-zero length.
Itâs probably not possible to get a null into a label, but we should
still say âcanât findâ rather than âmust haveâ in that case.
M op.c
M pp_ctl.c
M t/op/goto.t
commit d7d4778bfd35726feddd98b277f9eae6c8e3eee2
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 20:19:15 2012 -0700
[perl #111794] Make goto "" like goto ${\""}
The logic was written in such a way that goto "" just happened to slip
past all the checks and cause pp_goto to return NULL for the next op,
which means the end of the program.
goto ${\""} dies with âgoto must have labelâ, so goto ""
should as well.
This also adds other tests for that error, which was apparently
untested till now.
M pp_ctl.c
M t/op/goto.t
commit f45d2b7f56c55f080fcf10532ba207a7aa86319f
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 20:00:14 2012 -0700
Teach B::Concise about UTF8 labels
M ext/B/B/Concise.pm
commit 16f120893b01d07af022f1637a35716c2267f3fd
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 19:58:26 2012 -0700
Increase $B::Concise::VERSION to 0.90
M ext/B/B/Concise.pm
commit 56de27c71802e9aa6a737b54e3cf8ff2173e15f3
Author: Father Chrysostomos <[email protected]>
Date: Sun Apr 22 15:47:38 2012 -0700
Corrections to AUTHORS should go to perlbug
M AUTHORS
commit 9e6b0f09042bfabec1d4673f434b4329f6c9a03c
Author: Father Chrysostomos <[email protected]>
Date: Sat Apr 21 23:28:51 2012 -0700
regen/opcodes: Rmv evalonce comment
This goes all the way back to when perl 5.0 was being polished up.
The idea behind evalonce is that eval "constant string" should be
optimisable by being compiled ahead of time, just like eval { ... }.
But this could never work properly, because BEGIN blocks would only
fire once. Also, eval '$x .. $y' is an easy way to create two separ-
ate flip-flops. There are undoubtedly many other reasons why this
could never work.
So there is no reason to keep this comment any longer, as it is not
(or should not be) a to-do item.
M regen/opcodes
commit 91892ce66101d320d02fcf11d13b2b8031075b10
Author: Father Chrysostomos <[email protected]>
Date: Sat Apr 21 23:25:33 2012 -0700
pp_hot.c:pp_entersub: Rmv comment about setting PL_compcv
PL_compcv is meant to point to the currently compiling sub, even dur-
ing an evalâs run time. (See commit 676a678.) Therefore, this com-
mentâs suggestion is incorrect.
M pp_hot.c
commit e6cfa5b960fb0c4a58d776b8b1e1cb4fc0e6d882
Author: Father Chrysostomos <[email protected]>
Date: Thu Apr 19 22:30:00 2012 -0700
podcheck.t: Allow usually-skipped files on cmd line
M t/porting/podcheck.t
commit 18756a5278af861e4f5eeffd80e14239579ed6cb
Author: Alan Haggai Alavi <[email protected]>
Date: Tue Feb 28 21:18:58 2012 +0530
Removed a redundant 'once'
M pod/perlhist.pod
-----------------------------------------------------------------------
--
Perl5 Master Repository
