In perl.git, the branch maint-5.10 has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/27a6588a70ffa9e9000ca20f266a92f93cbf1a78?hp=2d84cf1abfd062a682bdf4511087de0e1edc73c0>

- Log -----------------------------------------------------------------
commit 27a6588a70ffa9e9000ca20f266a92f93cbf1a78
Author: Chris 'BinGOs' Williams <[email protected]>
Date:   Thu Mar 7 20:51:50 2013 +0000

    Fix memory leak in Encode.xs
-----------------------------------------------------------------------

Summary of changes:
 ext/Encode/Encode.xs |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ext/Encode/Encode.xs b/ext/Encode/Encode.xs
index 1424071..9f9dc9c 100644
--- a/ext/Encode/Encode.xs
+++ b/ext/Encode/Encode.xs
@@ -410,7 +410,6 @@ CODE:
     STRLEN slen;
     U8 *s = (U8 *) SvPV(src, slen);
     U8 *e = (U8 *) SvEND(src);
-    SV *dst = newSV(slen>0?slen:1); /* newSV() abhors 0 -- inaba */
 
     /* 
      * PerlIO check -- we assume the object is of PerlIO if renewed
@@ -443,6 +442,7 @@ CODE:
     }
     }
 
+    SV *dst = sv_2mortal(newSV(slen>0?slen:1));
     s = process_utf8(aTHX_ dst, s, e, check, 0, strict_utf8(aTHX_ obj), 
renewed);
 
     /* Clear out translated part of source unless asked not to */
@@ -454,7 +454,7 @@ CODE:
     SvCUR_set(src, slen);
     }
     SvUTF8_on(dst);
-    ST(0) = sv_2mortal(dst);
+    ST(0) = dst;
     XSRETURN(1);
 }
 
@@ -468,7 +468,7 @@ CODE:
     STRLEN slen;
     U8 *s = (U8 *) SvPV(src, slen);
     U8 *e = (U8 *) SvEND(src);
-    SV *dst = newSV(slen>0?slen:1); /* newSV() abhors 0 -- inaba */
+    SV *dst = sv_2mortal(newSV(slen>0?slen:1));
     if (SvUTF8(src)) {
     /* Already encoded */
     if (strict_utf8(aTHX_ obj)) {
@@ -507,7 +507,7 @@ CODE:
     }
     SvPOK_only(dst);
     SvUTF8_off(dst);
-    ST(0) = sv_2mortal(dst);
+    ST(0) = dst;
     XSRETURN(1);
 }
 

--
Perl5 Master Repository

Reply via email to