In perl.git, the branch smoke-me/salva/Storable has been updated <http://perl5.git.perl.org/perl.git/commitdiff/0b2583a5f8620b940ed4a24f6d3cdb66d9c155cc?hp=81af16c1db1cae60ae74a8914c3a4bedeef1cade>
- Log ----------------------------------------------------------------- commit 0b2583a5f8620b940ed4a24f6d3cdb66d9c155cc Author: Salvador <[email protected]> Date: Thu Jun 13 13:37:55 2013 +0200 remove several unused variables M dist/Storable/Storable.xs commit 872561601e20227f35f4e7f42db0bcf51b14d182 Author: Salvador <[email protected]> Date: Thu Jun 13 13:36:26 2013 +0200 remove unused variable M dist/Storable/Storable.xs commit 7a090afabd316dbe780d78043fbb4d26bf26d1e7 Author: Salvador <[email protected]> Date: Thu Jun 13 13:34:13 2013 +0200 remove unused variable M dist/Storable/Storable.xs commit 65b1e3406d68f776e482940772c3497586618f0c Author: Salvador <[email protected]> Date: Thu Jun 13 13:17:59 2013 +0200 remove implicit conversion of void* to char* M dist/Storable/Storable.xs commit 83755d7ef15bd84c07af43587c27719948043ca3 Author: Salvador <[email protected]> Date: Thu Jun 13 13:17:27 2013 +0200 remove some warning related to implicit conversion of const char * to char * M dist/Storable/Storable.xs ----------------------------------------------------------------------- Summary of changes: dist/Storable/Storable.xs | 15 +++++---------- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/dist/Storable/Storable.xs b/dist/Storable/Storable.xs index ddfe410..e99e902 100644 --- a/dist/Storable/Storable.xs +++ b/dist/Storable/Storable.xs @@ -352,8 +352,8 @@ struct st_retrieve_cxt { #endif static void -croak_io_error(pTHX_ SSize_t rc, retrieve_cxt_t *retrieve_cxt, char *str) { - char *error; +croak_io_error(pTHX_ SSize_t rc, retrieve_cxt_t *retrieve_cxt, const char *str) { + const char *error; if (rc < 0) { SV *ioe = GvSV(gv_fetchpvs("!", GV_ADDMULTI, SVt_PV)); error = SvPV_nolen(ioe); @@ -367,7 +367,7 @@ croak_io_error(pTHX_ SSize_t rc, retrieve_cxt_t *retrieve_cxt, char *str) { (retrieve_cxt->input_fh ? "file" : "string"), error); else - Perl_croak(aTHX_ "%s: %s", str, error); + Perl_croak(aTHX_ "%s: %s", (char *)str, (char*)error); } #define READ_ERROR(bytes) \ @@ -1109,7 +1109,7 @@ downgrade_restricted(pTHX) { */ static int known_class(pTHX_ store_cxt_t *store_cxt, HV *pkg, I32 *classnum) { - char *tag1; + void *tag1; TRACEME(("known_class (%s)", HvNAME_get(pkg))); @@ -1395,7 +1395,6 @@ static void store_array(pTHX_ store_cxt_t *store_cxt, AV *av) SV **sav; I32 len = av_len(av) + 1; I32 i; - int ret; TRACEME(("store_array (0x%"UVxf")", PTR2UV(av))); @@ -2038,7 +2037,6 @@ static int store_hook(pTHX_ store_cxt_t *store_cxt, SV *sv, int type, HV *pkg, S I32 ax; char *classname; STRLEN frozenlen; - SV *ref; int count, i; unsigned char flags; char *frozenpv; @@ -2589,7 +2587,6 @@ static int sv_type(pTHX_ SV *sv) static void store(pTHX_ store_cxt_t *store_cxt, SV *sv) { void *tag1; - int ret; int type; PTR_TBL_t *pseen = store_cxt->pseen; @@ -2863,7 +2860,6 @@ static SV *retrieve_idx_blessed(pTHX_ retrieve_cxt_t *retrieve_cxt, const char * I32 idx; const char *classname; SV **sva; - SV *sv; PERL_UNUSED_ARG(cname); TRACEME(("retrieve_idx_blessed (#%d)", retrieve_cxt->tagnum)); @@ -3098,7 +3094,7 @@ static SV *retrieve_hook(pTHX_ retrieve_cxt_t *retrieve_cxt, const char *cname) load_module(PERL_LOADMOD_NOIMPORT, newSVsv(class_sv), Nullsv); } for (is_thaw = 0; is_thaw < 2; is_thaw++) { - char *method = (is_thaw ? "STORABLE_thaw" : "STORABLE_attach"); + const char *method = (is_thaw ? "STORABLE_thaw" : "STORABLE_attach"); GV *gv = gv_fetchmethod_autoload(gv_stashsv(class_sv, GV_ADD), method, FALSE); if (gv && isGV(gv)) { @@ -3626,7 +3622,6 @@ static SV *retrieve_lutf8str(pTHX_ retrieve_cxt_t *retrieve_cxt, const char *cna static SV *retrieve_vstring_any(pTHX_ retrieve_cxt_t *retrieve_cxt, const char *cname, int l) { #ifdef SvVOK SV *sv, *s; - MAGIC *mg; I32 len; READ_VARINT(l, len); READ_SVPV(s, len); -- Perl5 Master Repository
