On Sat, 26 Jul 2014 17:32:17 +0200, "H.Merijn Brand" <[email protected]> wrote:
> On Fri, 25 Jul 2014 21:53:45 +0200, Brian Fraser <[email protected]> > wrote: > > I find this patch overly complicated and would suggest to replace it > with this: > > # Maybe put other stuff here too. > ./tr '-' '_' <<EOSH >>Cppsym.know > $osname > EOSH > ./tr '[a-z]' '[A-Z]' < Cppsym.know > Cppsym.a > ./tr '[A-Z]' '[a-z]' < Cppsym.know > Cppsym.b > $cat Cppsym.know > Cppsym.c > $cat Cppsym.a Cppsym.b Cppsym.c | $tr ' ' $trnl | $sort | $uniq > Cppsym.know > $rm -f Cppsym.a Cppsym.b Cppsym.c > > Doing it like this is not only shorter and simpler, but also makes it > way more obvious that this tr is *ONLY* for the $osname, as all symbols > stated just above do not have a dash. The comment just above the large > list could state this explicitely > > If you agree, I'll commit that to meta and regen > > > diff --git a/Configure b/Configure > > index 8d802fd..c86e42f 100755 > > --- a/Configure > > +++ b/Configure > > @@ -22066,11 +22066,13 @@ EOSH > > cat <<EOSH >>Cppsym.know > > $osname > > EOSH > > +./tr '-' '_' < Cppsym.know > Cppsym.know.tmp > > +$cat Cppsym.know.tmp > Cppsym.know > > ./tr '[a-z]' '[A-Z]' < Cppsym.know > Cppsym.a > > ./tr '[A-Z]' '[a-z]' < Cppsym.know > Cppsym.b > > $cat Cppsym.know > Cppsym.c > > $cat Cppsym.a Cppsym.b Cppsym.c | $tr ' ' $trnl | $sort | $uniq > > > Cppsym.know > > -$rm -f Cppsym.a Cppsym.b Cppsym.c > > +$rm -f Cppsym.a Cppsym.b Cppsym.c Cppsym.know.tmp > > cat <<EOSH > Cppsym > > $startsh > > if $test \$# -gt 0; then The meta-change I suggest to commit is: --8<--- diff --git a/U/modified/Cppsym.U b/U/modified/Cppsym.U index ce0de1e..fb09952 100644 --- a/U/modified/Cppsym.U +++ b/U/modified/Cppsym.U @@ -148,7 +148,10 @@ XPG2_EXTENDED XPG3 XPG3_EXTENDED XPG4 XPG4_EXTENDED z8000 zarch EOSH # Maybe put other stuff here too. -cat <<EOSH >>Cppsym.know +?X:Some OS's will have a dash in their $osname +?X:e.g. Android is known as linux-android +?X:The preprocessor will interpret the dash as a minus +./tr '-' '_' <<EOSH >>Cppsym.know $osname EOSH ./tr '[a-z]' '[A-Z]' < Cppsym.know > Cppsym.a -->8--- -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
signature.asc
Description: PGP signature
