In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/dd369969a58d736f281ffebe36fc24ab45b29fa6?hp=c4125715f8ee8caa13f08097fd26b383f0507d4c>
- Log ----------------------------------------------------------------- commit dd369969a58d736f281ffebe36fc24ab45b29fa6 Author: Andy Dougherty <[email protected]> Date: Thu Sep 4 12:24:42 2014 -0400 Correct usage of memEQs in attributes.xs [perl #122701] Reported and diagnosed by Reini Urban <[email protected]>. The call to memEQs(name, 6, "shared") could fail if name were shorter than 6 bytes, or if name were longer than 6, but started with "shared". ----------------------------------------------------------------------- Summary of changes: ext/attributes/attributes.pm | 2 +- ext/attributes/attributes.xs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/attributes/attributes.pm b/ext/attributes/attributes.pm index 7c3c0b0..ebca214 100644 --- a/ext/attributes/attributes.pm +++ b/ext/attributes/attributes.pm @@ -1,6 +1,6 @@ package attributes; -our $VERSION = 0.22; +our $VERSION = 0.23; @EXPORT_OK = qw(get reftype); @EXPORT = (); diff --git a/ext/attributes/attributes.xs b/ext/attributes/attributes.xs index dbb644d..6b36812 100644 --- a/ext/attributes/attributes.xs +++ b/ext/attributes/attributes.xs @@ -97,7 +97,7 @@ modify_SV_attributes(pTHX_ SV *sv, SV **retlist, SV **attrlist, int numattrs) } break; default: - if (memEQs(name, 6, "shared")) { + if (memEQs(name, len, "shared")) { if (negated) Perl_croak(aTHX_ "A variable may not be unshared"); SvSHARE(sv); -- Perl5 Master Repository
