In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/f93695f990c755bfd70a59f0ac4caf55173fdb4a?hp=d98e5cdeb3ac2db8525660fbbbe91c811785588c>
- Log ----------------------------------------------------------------- commit f93695f990c755bfd70a59f0ac4caf55173fdb4a Author: David Mitchell <[email protected]> Date: Thu Mar 5 10:28:28 2015 +0000 document why S_maybe_multideref is Coverity-safe ----------------------------------------------------------------------- Summary of changes: op.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/op.c b/op.c index 5adc788..5f25121 100644 --- a/op.c +++ b/op.c @@ -12227,7 +12227,13 @@ S_maybe_multideref(pTHX_ OP *start, OP *orig_o, UV orig_action, U8 hints) * determines whether the op chain is convertible and calculates the * buffer size; the second pass populates the buffer and makes any * changes necessary to ops (such as moving consts to the pad on - * threaded builds) + * threaded builds). + * + * NB: for things like Coverity, note that both passes take the same + * path through the logic tree (except for 'if (pass)' bits), since + * both passes are following the same op_next chain; and in + * particular, if it would return early on the second pass, it would + * already have returned early on the first pass. */ for (pass = 0; pass < 2; pass++) { OP *o = orig_o; -- Perl5 Master Repository
