In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/d732c5e56eaadd9e872e725ac0481273c58f319f?hp=c82de78e3ba0184f85b5b49245e5da32d1cb3fcc>
- Log ----------------------------------------------------------------- commit d732c5e56eaadd9e872e725ac0481273c58f319f Author: Jarkko Hietaniemi <[email protected]> Date: Tue Aug 16 19:15:50 2016 -0400 Coverity CID #15149: Missing varargs init or cleanup The return was returning after va_start but before va_end. M perlio.c commit dd1dbff095629118e73a48a2a6008f03418a07f6 Author: Jarkko Hietaniemi <[email protected]> Date: Tue Aug 16 19:06:31 2016 -0400 Revert "Check against negative uid/gid for fchown()." This reverts commit f95ba548a286b17c260cc168715a9d0d441b14a6. [rt.perl.org #128967] The negative arguments to fchown depend on the platform, so Coverity should not claim it knows what is acceptable. M doio.c ----------------------------------------------------------------------- Summary of changes: doio.c | 12 +----------- perlio.c | 3 ++- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/doio.c b/doio.c index 2dc7082..b8f3c28 100644 --- a/doio.c +++ b/doio.c @@ -1845,18 +1845,8 @@ Perl_apply(pTHX_ I32 type, SV **mark, SV **sp) int fd = PerlIO_fileno(IoIFP(GvIOn(gv))); APPLY_TAINT_PROPER(); if (fd < 0) { - SETERRNO(EBADF,RMS_IFI); - tot--; -#if Uid_t_sign == 1 - } else if (val < 0) { - SETERRNO(EINVAL,LIB_INVARG); - tot--; -#endif -#if Gid_t_sign == 1 - } else if (val2 < 0) { - SETERRNO(EINVAL,LIB_INVARG); + SETERRNO(EBADF,RMS_IFI); tot--; -#endif } else if (fchown(fd, val, val2)) tot--; #else diff --git a/perlio.c b/perlio.c index d44c67f..e60f3bb 100644 --- a/perlio.c +++ b/perlio.c @@ -350,11 +350,12 @@ PerlIO_debug(const char *fmt, ...) { va_list ap; dSYS; - va_start(ap, fmt); if (!DEBUG_i_TEST) return; + va_start(ap, fmt); + if (!PL_perlio_debug_fd) { if (!TAINTING_get && PerlProc_getuid() == PerlProc_geteuid() && -- Perl5 Master Repository
