In perl.git, the branch blead has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/877b982928bd23c44e063a6506419b9c5e214b15?hp=245c138eeeb54c68f594609593a6d05004ef4d82>

- Log -----------------------------------------------------------------
commit 877b982928bd23c44e063a6506419b9c5e214b15
Author: Jarkko Hietaniemi <j...@iki.fi>
Date:   Thu Oct 13 22:04:20 2016 -0400

    If a unit test doesn't finish in 5 minutes, it's not a unit test.
    
    These tests seem to often be outliers in execution time.  In faster
    modern machines the slowness is not noticeable, but in slower machines
    these are excruciatingly slow.
    
    In slow machines these tests may grind for hours, but that is not
    that useful information.  We know the machine is slow, already.
    
    The uniprops.t could also use the watchdog, except that TestProp.pl
    seems to be purposefully avoiding using test.pl.
-----------------------------------------------------------------------

Summary of changes:
 t/re/fold_grind.t | 1 +
 t/re/pat_psycho.t | 1 +
 t/re/uniprops.t   | 8 ++++++--
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/t/re/fold_grind.t b/t/re/fold_grind.t
index 6358165..bf5c9fd 100644
--- a/t/re/fold_grind.t
+++ b/t/re/fold_grind.t
@@ -11,6 +11,7 @@ BEGIN {
     if ($^O eq 'dec_osf') {
       skip_all("$^O cannot handle this test");
     }
+    watchdog(5 * 60);
     require './loc_tools.pl';
 }
 
diff --git a/t/re/pat_psycho.t b/t/re/pat_psycho.t
index c0f855f..e136c12 100644
--- a/t/re/pat_psycho.t
+++ b/t/re/pat_psycho.t
@@ -24,6 +24,7 @@ BEGIN {
     if ($^O eq 'dec_osf') {
         skip_all("$^O cannot handle this test");
     }
+    watchdog(5 * 60);
 }
 
 
diff --git a/t/re/uniprops.t b/t/re/uniprops.t
index f53a9c2..5214c41 100644
--- a/t/re/uniprops.t
+++ b/t/re/uniprops.t
@@ -3,10 +3,14 @@ use warnings;
 no warnings 'once';
 
 if ($^O eq 'dec_osf') {
-   print "1..0 # $^O cannot handle this test\n";
-   exit(0);
+    print "1..0 # $^O cannot handle this test\n";
+    exit(0);
 }
 
+# TODO: it would be good to have watchdog(5 * 60) in here
+# for slow machines, but unfortunately we cannot trivially
+# use test.pl because the TestProp.pl avoids using that.
+
 # This is a wrapper for a generated file.  Assumes being run from 't'
 # directory.
 

--
Perl5 Master Repository

Reply via email to