In perl.git, the branch smoke-me/khw-smoke has been created
<http://perl5.git.perl.org/perl.git/commitdiff/83df4dcaea3d1d38bf45dec9479514d71d02efb0?hp=0000000000000000000000000000000000000000>
at 83df4dcaea3d1d38bf45dec9479514d71d02efb0 (commit)
- Log -----------------------------------------------------------------
commit 83df4dcaea3d1d38bf45dec9479514d71d02efb0
Author: Karl Williamson <[email protected]>
Date: Sat Dec 17 17:25:29 2016 -0700
utf8.c Extract common code into macros
The 3 case changing functions: to upper, lower, and title case are
essentially identical except for what they call to actually do the
change; those being different macros or functions.
The fourth function, to fold, is identical to the other three for the
first part of its code, but diverges at the end in order to handle some
special cases.
This commit replaces the first part of the bodies of these 4 functions
by a common macro. And it replaces the remainder of the first 3
functions by another common macro.
I'm not a fan of this kind of macro to use in generating code, but it
seems the best way to keep these definitions in sync.
This commit just moved the code to the macro, and I manually verified
that there were no logic changes.
M utf8.c
commit b79142e80fde3981f1a66e6504aead3c182a3463
Author: Karl Williamson <[email protected]>
Date: Sun Dec 18 13:38:01 2016 -0700
APItest/t/handy.t: Bring final special case into loop
All the tests in this file are now in two loops, one for the isFOO()
macros, and the other for the toFOO() macros. Thus the main logic
applies to all, and tests can be added or changed easily.
M ext/XS-APItest/t/handy.t
commit 9e97588b7b05160aaac07ea56eb9d84f59bb085f
Author: Karl Williamson <[email protected]>
Date: Sun Dec 18 13:17:45 2016 -0700
APItest/t/handy.t: White-space only
Indent newly formed block
M ext/XS-APItest/t/handy.t
commit 1b833442dcc39e6389816c729b6506ee1913cce7
Author: Karl Williamson <[email protected]>
Date: Sun Dec 18 12:40:06 2016 -0700
APItest/t/handy.t: Add more tests
Macros with the '_uvchr' suffix were not being tested at all. Instead,
the undocumented backwards-compatibility-only macros with the suffixes
_uni were being tested, but these might diverge, and the tests wouldn't
find that.
M ext/XS-APItest/APItest.xs
M ext/XS-APItest/t/handy.t
commit 02c4360c4ce6168b8ad971973b37e623dd308a9b
Author: Karl Williamson <[email protected]>
Date: Sun Dec 18 11:55:49 2016 -0700
APItest/t/handy.t: Add more tests
The macros like isALPHA() were not getting tested; instead the theory
being that testing isALPHA_A() was good enough because they are #defined
to be the same. But that might change and the tests wouldn't uncover
that. And it turned out that some things wern't getting tested at all
if there was no _A version of the macro, for example isALNUM(). This
commit adds test for the version of the isFOO() macros with no suffix.
M ext/XS-APItest/APItest.pm
M ext/XS-APItest/APItest.xs
M ext/XS-APItest/t/handy.t
commit d12f6f24cee4736f869acac6ee50e28efe050371
Author: Karl Williamson <[email protected]>
Date: Sat Dec 17 19:43:28 2016 -0700
APItest/t/handy.t: Use abbrev. char name in test names
I got tired of seeing all these long character names fly by on my screen
while testing, so this changes to use any official Unicode abbreviation
when available. It's kind of silly to do this in this test, but I might
extract and improve this for more general use in tests of characters in
the future.
This also changes some imports so that the full module name need not
always be specified.
M ext/XS-APItest/t/handy.t
commit 2fa93055ec2162e9d655291d8ffaeb4df499310f
Author: Karl Williamson <[email protected]>
Date: Sat Dec 17 19:22:14 2016 -0700
APItest/t/handy.t: White-space only
indent newly formed block.
M ext/XS-APItest/t/handy.t
commit 933c0f2efca6830d60e511532345b3d6bae25fef
Author: Karl Williamson <[email protected]>
Date: Sat Dec 17 19:19:39 2016 -0700
APItest/t/handy.t: Fold in another special case
The previous commit revamped this .t to make most things
part of a single loop. This adds another thing that was outside it.
M ext/XS-APItest/t/handy.t
commit 0478bc2c7d2daaec26be2e2a2ddd47e9a4b82ad8
Author: Karl Williamson <[email protected]>
Date: Thu Dec 15 16:12:30 2016 -0700
APItest/t/handy.t: Refactor for maintenance
Over the years code has kept getting copied and modified slightly in
each new place. And a future commit would create still more. This cuts
down the number of slightly different versions to the minimum reasonably
attainable.
M ext/XS-APItest/t/handy.t
commit 7668d9a1d74143b32309de4a3d611d38a9fa953d
Author: Karl Williamson <[email protected]>
Date: Tue Dec 20 13:07:23 2016 -0700
toke.c: Simplify finding mirror-image close delimiter
This is the code that figures out what the matching closing delimiter is
for the few ones recognized by Perl has having a mirror-image delimiter.
I have had to figure out multiple times how these couple lines of code
works. This time, as I started to comment it, so I wouldn't have to do
so again, I realized that its cleverness wasn't really saving anything,
and my slow things down. So split into two parallel strings, with one
string containing the opening delimiters which have mirror image closing
ones, and the other containing those closing delimiters, in the same
order.
M toke.c
commit d89ddac1478a869e644e152af5ff8e66027576bf
Author: Karl Williamson <[email protected]>
Date: Tue Dec 20 11:43:08 2016 -0700
toke.c: Skip some work for UTF-8 invariant
Since these chars are the same when encoded in UTF-8 as when not, no
need to do the extra UTF-8 work.
M toke.c
commit 2823d30443efd3f34c118202fca482177f9290b5
Author: Karl Williamson <[email protected]>
Date: Tue Dec 20 14:37:11 2016 -0700
pod/perlop: Note that need space between op and \w delim
You can't say qqXfooX because it thinks it is all one bareword. Note
this, and that
qq XfooX
works.
M pod/perlop.pod
-----------------------------------------------------------------------
--
Perl5 Master Repository
