In perl.git, the branch blead has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/f0d3f5ace1d11ecf4dd9aea61c56e4f69e5c76e4?hp=abd07ec01964fc49e914e765cdba6f27072decda>

- Log -----------------------------------------------------------------
commit f0d3f5ace1d11ecf4dd9aea61c56e4f69e5c76e4
Author: David Mitchell <[email protected]>
Date:   Tue Jan 24 15:23:24 2017 +0000

    S_do_pmop_dump_bar() reduce scope of ch variable
    
    trivial bit of tidy-up
-----------------------------------------------------------------------

Summary of changes:
 dump.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/dump.c b/dump.c
index 349a3e42cd..fedea3cd1b 100644
--- a/dump.c
+++ b/dump.c
@@ -770,7 +770,6 @@ S_do_op_dump_bar(pTHX_ I32 level, UV bar, PerlIO *file, 
const OP *o);
 static void
 S_do_pmop_dump_bar(pTHX_ I32 level, UV bar, PerlIO *file, const PMOP *pm)
 {
-    char ch;
     UV kidbar;
 
     if (!pm)
@@ -778,14 +777,11 @@ S_do_pmop_dump_bar(pTHX_ I32 level, UV bar, PerlIO *file, 
const PMOP *pm)
 
     kidbar = ((bar << 1) | cBOOL(pm->op_flags & OPf_KIDS)) << 1;
 
-    if (pm->op_pmflags & PMf_ONCE)
-       ch = '?';
-    else
-       ch = '/';
-
-    if (PM_GETRE(pm))
+    if (PM_GETRE(pm)) {
+        char ch = (pm->op_pmflags & PMf_ONCE) ? '?' : '/';
        S_opdump_indent(aTHX_ (OP*)pm, level, bar, file, "PMf_PRE %c%.*s%c\n",
             ch,(int)RX_PRELEN(PM_GETRE(pm)), RX_PRECOMP(PM_GETRE(pm)), ch);
+    }
     else
        S_opdump_indent(aTHX_ (OP*)pm, level, bar, file, "PMf_PRE (RUNTIME)\n");
 

--
Perl5 Master Repository

Reply via email to