In perl.git, the branch smoke-me/khw-locale has been created
<http://perl5.git.perl.org/perl.git/commitdiff/22ee85908acd50d61df9e312c104d8c9d6eee395?hp=0000000000000000000000000000000000000000>
at 22ee85908acd50d61df9e312c104d8c9d6eee395 (commit)
- Log -----------------------------------------------------------------
commit 22ee85908acd50d61df9e312c104d8c9d6eee395
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:35:39 2017 -0600
smoke
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M perl.h
M proto.h
commit 65a94fd89b794d004d2713b1adf266e1b9582ab8
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:25:43 2017 -0600
Change locale-related #define name
This tells whether or not to use the locale functions from POSIX 2008,
so name it accordingly. The previous name, concerning thread safety
may eventually be implemented without these functions, so it is wrong to
use it.
M locale.c
M perl.h
commit 3e5e009aa11208bd051abb24d5fb234362f31526
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:19:13 2017 -0600
locale.c: Add a branch prediction
M locale.c
commit 6a868859ac5dc54ef22f976eff4f988a546e1831
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:16:38 2017 -0600
handy.h: White space only
ALign some things vertically for easier reading
M handy.h
commit 352ecac512e888d9a11b1fdba4f42a89bffda659
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:15:08 2017 -0600
locale.c: Avoid recalculating string lengths
We have put this C string into a Perl variable. We thus know the
length, so can use that instead of recalculating
M locale.c
commit f4bc6fe5e78aeef1c383816cb30f97c2006488f3
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 15:09:28 2017 -0600
util.c: atos_symbolize: Don't use locale-dependent fcns
It very likely isn't an issue here, but the core should not have
unintentional locale-dependent code .
M util.c
commit d06eb8396112cc1c5ab5c98619e65003e24d74ef
Author: Karl Williamson <[email protected]>
Date: Sat Jul 22 12:44:16 2017 -0600
locale.c: Don't be too clever in strlcat
This code I wrote was attempting to avoid multiple calls to strlen in
constructing the catenation of various components of a string. It did
this by keeping track of how far it got each iteration, and using that
as a starting point for the next. I now realize that the return value
of strlcat is as if it succeeds, even if there isn't enough room. That
means that if there were a problem, this could start out an iteration
such that it would be writing beyond the end of the buffer. It is safer
to not do this, so this commit removes it.
The use of strlcat is a safety measure, as there should be a sufficient
amount of space calculated for things to fit, so there is no bug here.
But one should be safe.
M locale.c
commit 43eebc507067e38e01e0aa2389c77728741c285a
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 19:46:39 2017 -0600
XXX why?: locale.c: Convert calls to my_setlocale into regularFOO
M locale.c
commit 11a340563fb3631e582252ab8bf1171724c077a2
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 19:16:55 2017 -0600
locale.c: Convert setlocale() calls to macros
This will be useful in future commits
M locale.c
commit b064b946e745dd1a071bd3b69085330a609bb01d
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 18:21:13 2017 -0600
locale.c: Use %z to specify printf format for length
This is the better way to do this.
M locale.c
commit a5e03a21be85a9dc355d1cfa5497964109fa6bfb
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 16:55:27 2017 -0600
locale.c: White space only
This outdents some code whose enclosing block was removed by the
previous commit, and does a few other white space changes for ease of
reading.
M locale.c
commit 88388e134c833b3232a2272c35df33f90330179a
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 16:20:01 2017 -0600
locale.c: Refactor static fcn to save work
This adds a parameter to the function that sets the radix character for
floating point numbers. We know that the radix by default is a dot, so
no need to calculate it in that case.
M embed.fnc
M embed.h
M locale.c
M proto.h
commit e32695adf4ff27f2ea696bf0e14dfe86b2903e8f
Author: Karl Williamson <[email protected]>
Date: Thu Jul 20 16:24:42 2017 -0600
locale.c: Rmv redundant fcn call
This function is called as part of the call made in the line before. No
need to do it twice.
M locale.c
commit 1fbede18010b77b0bbf375a132a5c5ec4dc40c36
Author: Karl Williamson <[email protected]>
Date: Wed Jul 19 11:34:08 2017 -0600
locale.c: Change static fcn name
The new name more closely reflects what it does
M embed.fnc
M embed.h
M locale.c
M proto.h
commit c5f742b54e018bc5b33db15aa3c73ca94ad04571
Author: Karl Williamson <[email protected]>
Date: Mon Jul 17 15:40:42 2017 -0600
lib/local.t: TODO some netbsd defective locales
This is part of [perl #131735]
The ISO 8859-2 locales on netbsd 7.1 tend to have the defect of thinking
an NBSP is a graphic character. This commit tells lib/locale.t to TODO
these failures, so that they don't fail our smokes.
These are defects in the locale furnished by the vendor, and not a Perl
bug.
M lib/locale.t
commit abad7cbe06e986821554ac8ad2a68f31e7dcaef3
Author: Karl Williamson <[email protected]>
Date: Sat Jul 15 18:19:48 2017 -0600
locale.c: White-space, comment, rearrange some #else
This file is full of conditional compilation, due to the fact that
locale support has been highly variable in the OSes Perl has operated
on. This commit properly indents nested compiler directives, and makes
sure there is a blank line between the directives and real code. I find
that much easier to read. It also re-orders some
#ifdef some_feature
Many lines of code handling feature
#else
1 to 3 lines of trivial code to avoid compilation warnings
#endif
to
#ifndef some_feature
1 to 3 lines of trivial code to avoid compilation warnings
#else
Many lines of code handling feature
#endif
Otherwise the trivial code may be hundreds of lines from the original
'#if', which makes it hard to grok.
M locale.c
commit bf0d6c6800aff761b0527ab157a18ff30acc1ff5
Author: Karl Williamson <[email protected]>
Date: Sat Jul 15 18:18:47 2017 -0600
locale.c: Use strerror_l if platform has it
strerror_l makes the my_strerror function trivial, as it doesn't have to
worry about critical sections, etc. Even on unthreaded perls, it avoids
having to change the current locale, and then change it back.
M locale.c
commit 5aa54b2dff8ef64f5edd9f32ac9a68a5611d3043
Author: Karl Williamson <[email protected]>
Date: Sat Jul 15 17:53:02 2017 -0600
locale.c: Refactor some #if clauses
This moves all the handling of the case where there are no locale
messages, instead of splitting it up across long stretches of
conditionally compiled code. This code is essentially trivial, and seen
to be when it isn't split up, and this prepares for the next commit.
The final return of the function is still split off so that all branches
go through it, and the debugging code adjacent to it.
M locale.c
commit 2d026c239cd003110416af4188585c0a5e5593dd
Author: Karl Williamson <[email protected]>
Date: Sat Jul 15 17:29:35 2017 -0600
locale.c: Move some DEBUGGING code
The code is moved so that it gets executed from all the #if #else
branches
M locale.c
commit 68ccc7137837879c68169c617ee7d0f420a866c7
Author: Karl Williamson <[email protected]>
Date: Sat Jul 15 17:25:28 2017 -0600
XXX wrong about 5.25: Initialize locale object even in unthreaded perls
... and even if not all the thread-safe components are available.
5.25, in order to avoid race conditions.
This commit will now initialize the thread-safe C locale object if the
function to do so is available, instead of only if all functions for any
manipulation are needed. This will allow for a future commit that needs
only a subset of them, and which is a win on unthreaded builds.
M makedef.pl
M perl.c
M perl.h
M perlvars.h
-----------------------------------------------------------------------
--
Perl5 Master Repository
