In perl.git, the branch blead has been updated
<https://perl5.git.perl.org/perl.git/commitdiff/187a41620b03725e88921c72501b2e72a66ed313?hp=b779ca972eaf5422e5c55efaf30370ea4bd97cde>
- Log -----------------------------------------------------------------
commit 187a41620b03725e88921c72501b2e72a66ed313
Author: James E Keenan <jkee...@cpan.org>
Date: Sun Jan 20 15:48:19 2019 -0500
Provide defined value for $TODO only where test should not run.
Some tests should not be run on older perls. To indicate that, provide
an undef rather than a defined but false value.
This reflects Test::Builder synch with CPAN for upstream bug fix:
https://github.com/Test-More/test-more/commit/9c269ff6e2b8a7be223ef1df7a254a09ec4dad2d
Note that these should really be SKIPs rather than TODOs (but we can handle
that later).
commit 682600244fff4af0e080e503dac9bdd3778e179c
Author: James E Keenan <jkee...@cpan.org>
Date: Sun Jan 20 15:23:13 2019 -0500
Provide defined value for $TODO only where test is still failing.
Reflecting Test::Builder synch with CPAN for upstream bug fix:
https://github.com/Test-More/test-more/commit/9c269ff6e2b8a7be223ef1df7a254a09ec4dad2d
Provide description for previously TODO-ed test.
-----------------------------------------------------------------------
Summary of changes:
ext/Devel-Peek/t/Peek.t | 19 +++++++++----------
ext/XS-APItest/t/call_checker.t | 8 +++++---
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/ext/Devel-Peek/t/Peek.t b/ext/Devel-Peek/t/Peek.t
index 2c0c849cf6..f3f781ac6b 100644
--- a/ext/Devel-Peek/t/Peek.t
+++ b/ext/Devel-Peek/t/Peek.t
@@ -286,8 +286,7 @@ do_test('reference to hash',
MAX = 7
Elt "123" HASH = $ADDR' . $c_pattern,
'',
- $] < 5.015
- && 'The hash iterator used in dump.c sets the OOK flag');
+ ($] < 5.015) ? 'The hash iterator used in dump.c sets the OOK flag' :
undef);
do_test('reference to anon sub with empty prototype',
sub(){@_},
@@ -457,7 +456,7 @@ do_test('reference to blessed hash',
FILL = 0
MAX = 7', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
do_test('typeglob',
@@ -535,7 +534,7 @@ do_test('reference to hash containing Unicode',
COW_REFCNT = 1 # $] < 5.019007
', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
} else {
do_test('reference to hash containing Unicode',
@@ -562,7 +561,7 @@ do_test('reference to hash containing Unicode',
COW_REFCNT = 1 # $] < 5.019007
', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
}
@@ -767,7 +766,7 @@ do_test('blessing to a class with embedded NUL characters',
FILL = 0
MAX = 7', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
do_test('ENAME on a stash',
@@ -928,7 +927,7 @@ do_test('small hash after keys and scalar',
# Dump with arrays, hashes, and operator return values
@array = 1..3;
-do_test('Dump @array', '@array', <<'ARRAY', '', '', 1);
+do_test('Dump @array', '@array', <<'ARRAY', '', undef, 1);
SV = PVAV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(\)
@@ -953,7 +952,7 @@ SV = PVAV\($ADDR\) at $ADDR
IV = 3
ARRAY
-do_test('Dump @array,1', '@array,1', <<'ARRAY', '', '', 1);
+do_test('Dump @array,1', '@array,1', <<'ARRAY', '', undef, 1);
SV = PVAV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(\)
@@ -969,7 +968,7 @@ SV = PVAV\($ADDR\) at $ADDR
ARRAY
%hash = 1..2;
-do_test('Dump %hash', '%hash', <<'HASH', '', '', 1);
+do_test('Dump %hash', '%hash', <<'HASH', '', undef, 1);
SV = PVHV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(SHAREKEYS\)
@@ -986,7 +985,7 @@ SV = PVHV\($ADDR\) at $ADDR
HASH
$_ = "hello";
-do_test('rvalue substr', 'substr $_, 1, 2', <<'SUBSTR', '', '', 1);
+do_test('rvalue substr', 'substr $_, 1, 2', <<'SUBSTR', '', undef, 1);
SV = PV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(PADTMP,POK,pPOK\)
diff --git a/ext/XS-APItest/t/call_checker.t b/ext/XS-APItest/t/call_checker.t
index 9367096b16..d39a059c22 100644
--- a/ext/XS-APItest/t/call_checker.t
+++ b/ext/XS-APItest/t/call_checker.t
@@ -5,9 +5,11 @@ use Test::More tests => 78;
use XS::APItest;
{
- local $TODO = $^O eq "cygwin" ? "[perl #78502] function pointers don't
match on cygwin" : "";
- ok( eval { XS::APItest::test_cv_getset_call_checker(); 1 })
- or diag $@;
+ local $TODO = "[perl #78502] function pointers don't match on cygwin"
+ if $^O eq "cygwin";
+ ok( eval { XS::APItest::test_cv_getset_call_checker(); 1 },
+ "test_cv_getset_call_checker() works as expected")
+ or diag $@;
}
my @z = ();
--
Perl5 Master Repository
