In perl.git, the branch blead has been updated <https://perl5.git.perl.org/perl.git/commitdiff/a79c258cf539dc7cba437fc32a30cea417a228fe?hp=966b4e4752e107a969ce19fbdbdb819547d41137>
- Log ----------------------------------------------------------------- commit a79c258cf539dc7cba437fc32a30cea417a228fe Author: Karl Williamson <[email protected]> Date: Mon Mar 4 11:28:13 2019 -0700 regcomp.c: Silence compiler warning msg. Some compilers aren't smart enough to realize there is no path through this function that doesn't set the return value. So initialize to an illegal value. Spotted by atoomic commit 3a732259e3184810c5c5422afdec6fae9ef54977 Author: Karl Williamson <[email protected]> Date: Mon Mar 4 11:26:04 2019 -0700 locale.c: Fix grammar in comment commit 7a58225f9b0f8d0d6fea71beed099880df9861bc Author: Karl Williamson <[email protected]> Date: Mon Mar 4 11:25:22 2019 -0700 lib/locale.t: Improve wording of test name ----------------------------------------------------------------------- Summary of changes: lib/locale.t | 2 +- locale.c | 2 +- regcomp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/locale.t b/lib/locale.t index 57bc418ae8..0f43dff6bd 100644 --- a/lib/locale.t +++ b/lib/locale.t @@ -2551,7 +2551,7 @@ unless ( $os =~ m!^(dragonfly|openbsd|bitrig|mirbsd)$! ) { $warned = $_[0] =~ /uninitialized/; }; my $z = "y" . setlocale(&POSIX::LC_ALL, "xyzzy"); - ok($warned, "variable set to setlocale(BAD LOCALE) is considered uninitialized"); + ok($warned, "variable set to setlocale(\"invalid locale name\") is considered uninitialized"); } # Test that tainting and case changing works on utf8 strings. These tests are diff --git a/locale.c b/locale.c index c8f0196095..3a2e49d72d 100644 --- a/locale.c +++ b/locale.c @@ -591,7 +591,7 @@ S_emulate_setlocale(const int category, { /* Internal glibc for querylocale(), but doesn't handle * empty-string ("") locale properly; who knows what other - * glitches. Check it for now, under debug. */ + * glitches. Check for it now, under debug. */ char * temp_name = nl_langinfo_l(_NL_LOCALE_NAME(category), uselocale((locale_t) 0)); diff --git a/regcomp.c b/regcomp.c index 5bae668075..5cb8c6a56c 100644 --- a/regcomp.c +++ b/regcomp.c @@ -16478,7 +16478,7 @@ S_regclass(pTHX_ RExC_state_t *pRExC_state, I32 *flagp, U32 depth, UV prevvalue = OOB_UNICODE, save_prevvalue = OOB_UNICODE; IV range = 0; UV value = OOB_UNICODE, save_value = OOB_UNICODE; - regnode_offset ret; + regnode_offset ret = -1; /* Initialized to an illegal value */ STRLEN numlen; int namedclass = OOB_NAMEDCLASS; char *rangebegin = NULL; -- Perl5 Master Repository
