Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 46d41ce13ae7b302e919c0aed4d900d563732085
https://github.com/Perl/perl5/commit/46d41ce13ae7b302e919c0aed4d900d563732085
Author: Karl Williamson <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M embedvar.h
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M ext/POSIX/t/mb.t
M intrpvar.h
M locale.c
M perl.h
M pod/perldelta.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
POSIX::mblen() Make thread-safe; allow shift state control
This commit changes to use mbrlen() (mostly) transparently, when
available, to achieve thread-safe operation. It is not completely
transparent because mbrlen may set errno differently upon errors, and
no effort is made to hide that difference.
This commit also changes the behavior so that it takes a scalar
parameter instead of a char *, and this might not be forceable into a
valid PV. If not a PV, mblen() is always used (with a semaphore) to
initialize the shift state. Previously the shift state was always
reinitialized with every call, which meant this could not work on
locales with shift states.
[perl #133928] showed that someone was having trouble with shift states.
Commit: 4d30d0692521af74c22fd4bfc82cb4e252078d13
https://github.com/Perl/perl5/commit/4d30d0692521af74c22fd4bfc82cb4e252078d13
Author: Karl Williamson <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M ext/POSIX/t/mb.t
Log Message:
-----------
ext/POSIX/t/mb.t: Add another mblen test
Also fix a skip count
Commit: bb793734aff997ca13e340dec92bbbd0bf9e6939
https://github.com/Perl/perl5/commit/bb793734aff997ca13e340dec92bbbd0bf9e6939
Author: Karl Williamson <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M ext/POSIX/t/mb.t
M pod/perldelta.pod
Log Message:
-----------
POSIX::mblen: Make 2nd parameter optional
Now that an SV is passed instead of a PV, its length is available
without having to have a second parameter. The second parameter is now
only used if it restricts the desired length to scan to less than that
available.
Commit: 4f7cfb2e7fc1ccf38b6ffb795e6a18047541ff0b
https://github.com/Perl/perl5/commit/4f7cfb2e7fc1ccf38b6ffb795e6a18047541ff0b
Author: Karl Williamson <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M embedvar.h
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M ext/POSIX/t/mb.t
M intrpvar.h
M locale.c
M pod/perldelta.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
Fixup POSIX::mbtowc, wctomb
This commit enhances these functions so that they use mbrtowc and
wcrtomb when available, making them thread safe. The substitution isn't
completely transparent, as no effort is made to hide any differences in
errno setting upon error.
This commit also changes the behaviors so that they take a scalar
parameter instead of a char *, and this might be 'undef' or not be
forceable into a valid PV. If not a PV, the non-r version is always
used (with a semaphore) to initialize the shift state. Previously the
shift state was always reinitialized with every call, which meant these
could not work on locales with shift states.
In addition, there were several issues in mbtowc and wctomb that this
commit fixes.
mbtowc is now run with a semaphore (when mbrtowc isn't available). This
avoids races if called at the same time in another thread.
The final parameter to mbtowc is now optional, as passing an SV allows
us to determine the length without the need for an extra parameter. It
is now used only to restrict the parsing of the string to shorter than
the actual length.
wctomb would segfault if the string parameter was shared or hadn't
been pre-allocated with a string of sufficient length to hold the
result.
wctomb is now run with a semaphore (when wcrtomb isn't available). This
avoids races if called at the same time in another thread.
Compare: https://github.com/Perl/perl5/compare/46d41ce13ae7%5E...4f7cfb2e7fc1
