Branch: refs/heads/smoke-me/khw-pr
Home: https://github.com/Perl/perl5
Commit: 0b36991a86f36f7cfb5e83b78f304f6de1be2563
https://github.com/Perl/perl5/commit/0b36991a86f36f7cfb5e83b78f304f6de1be2563
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move test earlier in regpiece()
Prior to this commit, the code checked if this was a particular
quantifier; if so handled that, then checked if it were some other
quantifier, returning if not.
This commit changes to check first if it is any quantifier, using the
macro that checks for all of them, returning if not.
Thus after the new code we know it is a quantifier and this allows later
commits to simplify
Commit: 4fefb9933c1a6f2b08f06927dc7148fb83805294
https://github.com/Perl/perl5/commit/4fefb9933c1a6f2b08f06927dc7148fb83805294
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Combine common code
This bit of code occurs in two places. Move it so that it gets executed
before the split, so it only has to be specified once.
Commit: beb91982d02a7924bf76b810689a2a5e0a60a406
https://github.com/Perl/perl5/commit/beb91982d02a7924bf76b810689a2a5e0a60a406
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block
Commit: 3f3b8d2d14592ae88b70014ee691e1f0300a8793
https://github.com/Perl/perl5/commit/3f3b8d2d14592ae88b70014ee691e1f0300a8793
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move some code in regpiece()
This moves some code, making it part of an else. As a result, several
gotos are eliminated, and the code is in a more logical order.
Commit: b0c2240913081ad264063300de69e78304eef8e3
https://github.com/Perl/perl5/commit/b0c2240913081ad264063300de69e78304eef8e3
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block.
Commit: 88666ce289ba84209b22063949cfadb5e3f36634
https://github.com/Perl/perl5/commit/88666ce289ba84209b22063949cfadb5e3f36634
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Rmv misleading comment
This NOTREACHED's presence just before an else would make one think
there is something funny going one, when there isn't.
Commit: 89b7015e52969ece549a3fa5b29971eecdc18427
https://github.com/Perl/perl5/commit/89b7015e52969ece549a3fa5b29971eecdc18427
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move code to earlier in regpiece()
This is in preparation for a future commit that will change things so
this would need to be done earlier than the changes.
Commit: 267a05adbee7dc562726ab09c335858555785f91
https://github.com/Perl/perl5/commit/267a05adbee7dc562726ab09c335858555785f91
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Split an 'if' and indent
This makes an && 'if' clause instead to be nested within the first
clause. This is in preparation for more code to be added that applies
to both to be added in a future commit.
Commit: 2a01972ade51371bdafec4390eadc30a58ffb8cc
https://github.com/Perl/perl5/commit/2a01972ade51371bdafec4390eadc30a58ffb8cc
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() Move some #ifdef'd out code
Splitting the 'if' in the previous commit means that this uncompiled
code would be best placed inside the outer 'if' should it ever be
re-enabled.
I suspect that this was disabled before POSTPONED existed, and that if
it were to be re-enabled, it should only be done if not postponed, so
that the whole 'if' would be removed. But I thought it best to leave
things unchanged.
Commit: 2b0da99c7117bb34ca1a0af9161b4d2f4b44e44e
https://github.com/Perl/perl5/commit/2b0da99c7117bb34ca1a0af9161b4d2f4b44e44e
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() Don't match 0 length more than once
There's no point in matching something more than once that doesn't
advance the parse, as long as there are no side effects beyond those
from the first match. Those could only happen in code blocks, which
this code doesn't have.
Commit: 0f2809a7bf72c4e5ef7706e47df2b9636a14240d
https://github.com/Perl/perl5/commit/0f2809a7bf72c4e5ef7706e47df2b9636a14240d
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() x times 0 is 0
Prior to this commit, regpiece() gave width to many quantified values.
This is wrong. If something is zero width, repeating it doesn't cause
it to gain width. I don't know if this led to wrong pattern matching
results, but I imagine it led to slower results in some cases.
Commit: f7ee2635a9a59c1c8f6efce713894b9ecf8ff3fa
https://github.com/Perl/perl5/commit/f7ee2635a9a59c1c8f6efce713894b9ecf8ff3fa
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Pass along that is a code block
regpiece was failing to pass up to its caller that a piece of code
contained a code block, if that code was quantified.
I don't know what the consequences of this are
Commit: 1f280c05c6c1259cc6592554b0c53af0a5e5440d
https://github.com/Perl/perl5/commit/1f280c05c6c1259cc6592554b0c53af0a5e5440d
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Change label name; rmv extraneous goto
The name was misleading. There are other things being done here. And
previous restructuring led to a goto immediately prior to where it went
to.
Commit: 49847d6ad5542c49f9d11b187d6ef92dfecc194a
https://github.com/Perl/perl5/commit/49847d6ad5542c49f9d11b187d6ef92dfecc194a
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece: Consolidate code
There is a common place these three occurrences can be placed at,
Commit: 018c07950f128a438b7be1e0816f8fbe388553e8
https://github.com/Perl/perl5/commit/018c07950f128a438b7be1e0816f8fbe388553e8
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Refactor two 'if's
I think this makes it clearer the commonalities of the * and +
quantifiers.
Commit: b5439f410affcaf60908928087481bc12fcae655
https://github.com/Perl/perl5/commit/b5439f410affcaf60908928087481bc12fcae655
Author: Karl Williamson <k...@cpan.org>
Date: 2020-08-10 (Mon, 10 Aug 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): More comments; white-space
Compare: https://github.com/Perl/perl5/compare/36302d6a4c1f...b5439f410aff
