Branch: refs/heads/smoke-me/khw-hvds_pr
Home: https://github.com/Perl/perl5
Commit: e7082139d0006e8d5968e0e3a9e9cb9fef82f31c
https://github.com/Perl/perl5/commit/e7082139d0006e8d5968e0e3a9e9cb9fef82f31c
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move test earlier in regpiece()
Prior to this commit, the code checked if this was a particular
quantifier; if so handled that, then checked if it were some other
quantifier, returning if not.
This commit changes to check first if it is any quantifier, using the
macro that checks for all of them, returning if not.
Thus after the new code we know it is a quantifier and this allows later
commits to simplify
Commit: fe053dc220a170a59af6b2f10a1ee805b31da7f2
https://github.com/Perl/perl5/commit/fe053dc220a170a59af6b2f10a1ee805b31da7f2
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Combine common code
This bit of code occurs in two places. Move it so that it gets executed
before the split, so it only has to be specified once.
Commit: e4e9b2187b100aa125c74220da6ed07ab79a2375
https://github.com/Perl/perl5/commit/e4e9b2187b100aa125c74220da6ed07ab79a2375
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block
Commit: 74817fe4d141d320f46d5b584d394e4fa157a247
https://github.com/Perl/perl5/commit/74817fe4d141d320f46d5b584d394e4fa157a247
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move some code in regpiece()
This moves some code, making it part of an if/else. As a result, several
gotos are eliminated, and the code is in a more logical order.
Commit: 32b9c95e9d2e4631e68035f32d84a66c82ed7cf4
https://github.com/Perl/perl5/commit/32b9c95e9d2e4631e68035f32d84a66c82ed7cf4
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block.
And convert some tabs to blanks
Commit: c19974f4ee7c6c133c08560c76093d5dfe88ed7c
https://github.com/Perl/perl5/commit/c19974f4ee7c6c133c08560c76093d5dfe88ed7c
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Rmv misleading comment
This NOTREACHED's presence just before an else would make one think
there is something funny going one, when there isn't.
Commit: 5f7fc391a44b61b86dc58e71864674f1a7b12ada
https://github.com/Perl/perl5/commit/5f7fc391a44b61b86dc58e71864674f1a7b12ada
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move code to earlier in regpiece()
This is in preparation for a future commit that will change things so
this would need to be done earlier than the changes.
Commit: b76cd960eff1e83927e91a23a1e6b2a3607aa825
https://github.com/Perl/perl5/commit/b76cd960eff1e83927e91a23a1e6b2a3607aa825
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Rmv #if 0 bitrotted code
This code has been #ifdef'd out for 20 years, and shows bit rot. It was
kept around in case there was a problem with the replacement for it, but
that hasn't happened and is very unlikely to happen; in the meantime
this is a visual distraction to the code flow.
Commit: 9c9826936046e4d5002ae5fbb0ed393e5fb4c3bc
https://github.com/Perl/perl5/commit/9c9826936046e4d5002ae5fbb0ed393e5fb4c3bc
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() Don't match 0 length more than once
There's no point in matching something more than once that doesn't
advance the parse, as long as there are no side effects beyond those
from the first match. Those could only happen in code blocks, which
this code doesn't have.
Commit: dfba37dbe0c5de2a3112d95a926a9f33385553e9
https://github.com/Perl/perl5/commit/dfba37dbe0c5de2a3112d95a926a9f33385553e9
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() 0 times anything is 0
Prior to this commit, regpiece() gave width to many quantified values.
This is wrong. If something is zero width, repeating it doesn't cause
it to gain width. I don't know if this led to wrong pattern matching
results, but I imagine it led to slower results in some cases.
Commit: 2b52db0a747b44ffa8b118d039b380133be2d3f7
https://github.com/Perl/perl5/commit/2b52db0a747b44ffa8b118d039b380133be2d3f7
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Pass along that is a code block
regpiece was failing to pass up to its caller that a piece of code
contained a code block, if that code was quantified.
I don't know what the consequences of this are
Commit: 98067f88a22592ebd1d79ac0010b4dd86a795602
https://github.com/Perl/perl5/commit/98067f88a22592ebd1d79ac0010b4dd86a795602
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Change label name; rmv extraneous goto
The name was misleading. There are other things being done here. And
previous restructuring led to a goto immediately prior to where it went
to.
Commit: a413c80f1eb51b0aefe1c9df271b034c9c5a50e9
https://github.com/Perl/perl5/commit/a413c80f1eb51b0aefe1c9df271b034c9c5a50e9
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece: Consolidate code
There is a common place these three occurrences can be placed at,
Commit: 7cfe70b3c933cd8dde257ad1c41d086528994aff
https://github.com/Perl/perl5/commit/7cfe70b3c933cd8dde257ad1c41d086528994aff
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Refactor two 'if's
I think this makes it clearer the commonalities of the * and +
quantifiers.
Commit: d1f93ad390ef2a1ae7afa06d3d06bcccc3ecfc3a
https://github.com/Perl/perl5/commit/d1f93ad390ef2a1ae7afa06d3d06bcccc3ecfc3a
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): More comments; white-space
Commit: 0130055a12516068ac79c8f49acb24fd85c30a72
https://github.com/Perl/perl5/commit/0130055a12516068ac79c8f49acb24fd85c30a72
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Convert to a switch() stmt
This makes the code easier to understand, I think.
Commit: a10f7666b9ffea3cfc528f6adb67237c09086998
https://github.com/Perl/perl5/commit/a10f7666b9ffea3cfc528f6adb67237c09086998
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Change indentation to correspond with new blocks formed by the previous
commit
Compare: https://github.com/Perl/perl5/compare/b5439f410aff...a10f7666b9ff
