Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 1442da54429bca166af716cb981dc150644ad203
https://github.com/Perl/perl5/commit/1442da54429bca166af716cb981dc150644ad203
Author: Karl Williamson <[email protected]>
Date: 2020-12-06 (Sun, 06 Dec 2020)
Changed paths:
M handy.h
Log Message:
-----------
Revert "Don't test for 16-bit inputs in inRANGE()"
This effectively reverts commit
4c2aa7c802893d0276551ade1b9d5dcd1226afc4.
That commit removed checking for 16 bit inputs because an assert in a
macro was making compilations fail in some compilers that couldn't
handle the complexity. This inadvertently broke systems which use C
language shorts in certain places, such Mingw and Win32 with their use
of UTF16, not typically found on other platforms. At the time, we
weren't smoking Mingw so we didn't know about it there, but the Win32
failures on Win32 were "fixed" by another commit which disabled
assertions of this type completely. It turns out the issue was passing
too long a string to assert(). Commits 92a0bb2 and 88086fd removed a
bunch of unnecessary and/or duplicate asserts, bringing the size down,
so that the 16 bit checks can be added back in without breaking these
compilers.
The reverted commit mentioned HP compilers as having problems. The only
such box we currently have available for testing is HP-31, and the
reversion works fine on it, even before 92a0bb2 and 88086fd.
This fixes GH #18364
Commit: bc113a9f23ba6ec568379797d3ba5382c941e062
https://github.com/Perl/perl5/commit/bc113a9f23ba6ec568379797d3ba5382c941e062
Author: Karl Williamson <[email protected]>
Date: 2020-12-06 (Sun, 06 Dec 2020)
Changed paths:
M perl.h
Log Message:
-----------
Not all Win32 compilers have a small macro buffer
Commit e7ae132ec78 consolidated PERL_SMALL_MACRO_BUFFER usages, but it
omitted the _MSC_VER number at which the buffer became large enough.
Apparently it did this because Windows compilations were failing with
the error "string too long", which doesn't happen if __ASSERT_ expands
to nothing, which it does under PERL_SMALL_MACRO_BUFFER.
However, commits 92a0bb2 and 88086fd shortened the offending strings
so later Windows compilers don't have to be considered as having small
macro buffers.
Compare: https://github.com/Perl/perl5/compare/2de541a7c621...bc113a9f23ba
