Branch: refs/heads/jkeenan/unicode-collate-mkheader-warnings
  Home:   https://github.com/Perl/perl5
  Commit: 4f58a3afca0ec26d19adb54b7e5a94bba23b0e46
      
https://github.com/Perl/perl5/commit/4f58a3afca0ec26d19adb54b7e5a94bba23b0e46
  Author: James E Keenan <[email protected]>
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
    M cpan/Unicode-Collate/mkheader

  Log Message:
  -----------
  mkheader: Prevent 'print on closed filehandle' messages

Program 'mkheader' is called from cpan/Unicode-Collate/Makefile.PL,
which was recently revised to run with both strictures and warnings.
Makefile.PL executes mkheader via a 'do'.  This was causing the
following statements to be printed during 'make' in the Perl
5 build process:

printf() on closed filehandle $fh_h at 
.../cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm line 1233.
print() on closed filehandle $fh_h at 
.../cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm line 1234.

Storing the original filehandle during select(), then restoring it at
the end of the loop, clears up those statements.

Reply via email to