Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: cd701ed57dddc0322f5dea642bb16f9e82dd26a2
https://github.com/Perl/perl5/commit/cd701ed57dddc0322f5dea642bb16f9e82dd26a2
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 6535d4cdb0f866bd974831fe9d1da22f093fef31
https://github.com/Perl/perl5/commit/6535d4cdb0f866bd974831fe9d1da22f093fef31
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 9b4967aa1630ebd3d0a15e90bddf8f682d962ec0
https://github.com/Perl/perl5/commit/9b4967aa1630ebd3d0a15e90bddf8f682d962ec0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: f62cdde85ca833875ba8cc9717e6c4594dddb756
https://github.com/Perl/perl5/commit/f62cdde85ca833875ba8cc9717e6c4594dddb756
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 6e5d6eca3bc82772a0c5f66aefdce8f308e6a7f9
https://github.com/Perl/perl5/commit/6e5d6eca3bc82772a0c5f66aefdce8f308e6a7f9
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 300444c17626dd0c9dfa75c87101fe6e343c5bbd
https://github.com/Perl/perl5/commit/300444c17626dd0c9dfa75c87101fe6e343c5bbd
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 9e229edd0c072b59046c15cd145b1c0c77ddd52f
https://github.com/Perl/perl5/commit/9e229edd0c072b59046c15cd145b1c0c77ddd52f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 4ab73f3ad7793bcc22d45e4bbdda724b64352c1c
https://github.com/Perl/perl5/commit/4ab73f3ad7793bcc22d45e4bbdda724b64352c1c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 1589b13603287214e18c379207563bc79b136ce0
https://github.com/Perl/perl5/commit/1589b13603287214e18c379207563bc79b136ce0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 1334026baa7c9f14e958bf80bcbd507dd9356460
https://github.com/Perl/perl5/commit/1334026baa7c9f14e958bf80bcbd507dd9356460
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: cd09dbd30caa581087f4b878b5c85d9c82f56fd0
https://github.com/Perl/perl5/commit/cd09dbd30caa581087f4b878b5c85d9c82f56fd0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: b1c2824789d3cd9a518680c1cead0cef9b224541
https://github.com/Perl/perl5/commit/b1c2824789d3cd9a518680c1cead0cef9b224541
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 033b78411dc0d23ce388d1b84c0e90e96ac308cc
https://github.com/Perl/perl5/commit/033b78411dc0d23ce388d1b84c0e90e96ac308cc
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: e1ae386bef24799bfe4f489e402102049bc1fba8
https://github.com/Perl/perl5/commit/e1ae386bef24799bfe4f489e402102049bc1fba8
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: e6ab95d35bb457a70e5ff4ddd759b0f1dc5abb96
https://github.com/Perl/perl5/commit/e6ab95d35bb457a70e5ff4ddd759b0f1dc5abb96
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 797ff7b251a94324a6f1222232dbd1c67c853ecb
https://github.com/Perl/perl5/commit/797ff7b251a94324a6f1222232dbd1c67c853ecb
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 721a167b6b7afb59f49e6460b54c2e7d80ba7092
https://github.com/Perl/perl5/commit/721a167b6b7afb59f49e6460b54c2e7d80ba7092
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 3083917c577ba2b5043ada678d9046ac2e538ae1
https://github.com/Perl/perl5/commit/3083917c577ba2b5043ada678d9046ac2e538ae1
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 2bd709893ea6bf5ea9d31c6cd6d173a62496fe0a
https://github.com/Perl/perl5/commit/2bd709893ea6bf5ea9d31c6cd6d173a62496fe0a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: d85c91351d44746d7e26bce0269a8a6a192195b0
https://github.com/Perl/perl5/commit/d85c91351d44746d7e26bce0269a8a6a192195b0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: f66745e970d08b65f31a2d8efe1840569d459170
https://github.com/Perl/perl5/commit/f66745e970d08b65f31a2d8efe1840569d459170
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 781803caba142de86d91a005a59b595e71a6d36b
https://github.com/Perl/perl5/commit/781803caba142de86d91a005a59b595e71a6d36b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 61eadcac535ae224898c0e0cb6ad4434c9abbb8b
https://github.com/Perl/perl5/commit/61eadcac535ae224898c0e0cb6ad4434c9abbb8b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 5d896f4ea7567461f2aa15955488c206e49046fd
https://github.com/Perl/perl5/commit/5d896f4ea7567461f2aa15955488c206e49046fd
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 84cc74210c17c5c04545a8e413f7c8ff5ea030a1
https://github.com/Perl/perl5/commit/84cc74210c17c5c04545a8e413f7c8ff5ea030a1
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: f8694632818f75a76d6a4d5cd5f3b50053d8034d
https://github.com/Perl/perl5/commit/f8694632818f75a76d6a4d5cd5f3b50053d8034d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: ee720af3b59e3530cdb1563dd76922d93ee62849
https://github.com/Perl/perl5/commit/ee720af3b59e3530cdb1563dd76922d93ee62849
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 054f78aeb12fc7cfbaec2fd7d2c60891031173e2
https://github.com/Perl/perl5/commit/054f78aeb12fc7cfbaec2fd7d2c60891031173e2
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 60a0efb7943fa679c2ffeaf8a4d7bf4fa3762858
https://github.com/Perl/perl5/commit/60a0efb7943fa679c2ffeaf8a4d7bf4fa3762858
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 6dc0d60d0ddf38b3709b951ee0107cf8ec36d3a1
https://github.com/Perl/perl5/commit/6dc0d60d0ddf38b3709b951ee0107cf8ec36d3a1
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: a0fc68d501b44324498764d30562262a2bd3b9cc
https://github.com/Perl/perl5/commit/a0fc68d501b44324498764d30562262a2bd3b9cc
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 97dbf5c5ca16e9cd1400c26042ce1b9916a3dc5d
https://github.com/Perl/perl5/commit/97dbf5c5ca16e9cd1400c26042ce1b9916a3dc5d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 49ee1721d4bb6919ad56aff1058fb5bf2b769b44
https://github.com/Perl/perl5/commit/49ee1721d4bb6919ad56aff1058fb5bf2b769b44
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 810118bd6be62c7520fe8e8b2749f8d01843dc67
https://github.com/Perl/perl5/commit/810118bd6be62c7520fe8e8b2749f8d01843dc67
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: fed2466bb3c62bb4479431f5ea921db711b84539
https://github.com/Perl/perl5/commit/fed2466bb3c62bb4479431f5ea921db711b84539
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 1c460f570f53fd9a36c2e768934526cd86319052
https://github.com/Perl/perl5/commit/1c460f570f53fd9a36c2e768934526cd86319052
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: a3d4fa50dc1e005a70c3445aa7c07a33f469506f
https://github.com/Perl/perl5/commit/a3d4fa50dc1e005a70c3445aa7c07a33f469506f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 5f1d9c35fa8df6a1360ecce1ec9726a4886d7667
https://github.com/Perl/perl5/commit/5f1d9c35fa8df6a1360ecce1ec9726a4886d7667
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 744b4ba76a188a476c406140381c75f861c05aec
https://github.com/Perl/perl5/commit/744b4ba76a188a476c406140381c75f861c05aec
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 30d1fa5535325ee2428d5b9a0116ca51603df81a
https://github.com/Perl/perl5/commit/30d1fa5535325ee2428d5b9a0116ca51603df81a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 576e20abd1cfb4c2e483fbedce9191c8546986d0
https://github.com/Perl/perl5/commit/576e20abd1cfb4c2e483fbedce9191c8546986d0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: eb94ce1b0cfb2d64ba927118402839afd4966da9
https://github.com/Perl/perl5/commit/eb94ce1b0cfb2d64ba927118402839afd4966da9
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 6fc0c44458ee9d113f03ea4795fa5fc2b553d32a
https://github.com/Perl/perl5/commit/6fc0c44458ee9d113f03ea4795fa5fc2b553d32a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 99c4e57710bc107f4f4cd014adea0972f0f42088
https://github.com/Perl/perl5/commit/99c4e57710bc107f4f4cd014adea0972f0f42088
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 7a420881df1d3c6cc826553383f3f56aad02d045
https://github.com/Perl/perl5/commit/7a420881df1d3c6cc826553383f3f56aad02d045
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 76da634647af119e3a019acc9c4bedb45c1bde30
https://github.com/Perl/perl5/commit/76da634647af119e3a019acc9c4bedb45c1bde30
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: d7ea9b1935a3eb1a1326b761a508e82c38df2f94
https://github.com/Perl/perl5/commit/d7ea9b1935a3eb1a1326b761a508e82c38df2f94
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: ba0ca14ed3524732484f8649d84982ae162e5496
https://github.com/Perl/perl5/commit/ba0ca14ed3524732484f8649d84982ae162e5496
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 4f26d2c5351bc3b553dd99f8c77a7605ecac2036
https://github.com/Perl/perl5/commit/4f26d2c5351bc3b553dd99f8c77a7605ecac2036
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 2a0968d2d226bc974ab80fb1fe25110550273174
https://github.com/Perl/perl5/commit/2a0968d2d226bc974ab80fb1fe25110550273174
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 4f8ef5b263fce4cb6d0351dbfc27d1c39ed388df
https://github.com/Perl/perl5/commit/4f8ef5b263fce4cb6d0351dbfc27d1c39ed388df
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: cea17aafdb508c10307b6ec159fe85325edcf603
https://github.com/Perl/perl5/commit/cea17aafdb508c10307b6ec159fe85325edcf603
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5565e00f7979bac86b0b72fc6c1e5c555efbeae0
https://github.com/Perl/perl5/commit/5565e00f7979bac86b0b72fc6c1e5c555efbeae0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 0b5dc1a4f6832113833181f397c23d17dd45171e
https://github.com/Perl/perl5/commit/0b5dc1a4f6832113833181f397c23d17dd45171e
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: f0b55061571d4bc1d3060485319b372fe41c150f
https://github.com/Perl/perl5/commit/f0b55061571d4bc1d3060485319b372fe41c150f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 44a0a9fd9b9849cb323c76a6fa2daa73f0a2b537
https://github.com/Perl/perl5/commit/44a0a9fd9b9849cb323c76a6fa2daa73f0a2b537
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: c4bedd57167a85198d58605e53f8235109307006
https://github.com/Perl/perl5/commit/c4bedd57167a85198d58605e53f8235109307006
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 583b0836016cddfe7b271f76b9aa6d96181f3e2d
https://github.com/Perl/perl5/commit/583b0836016cddfe7b271f76b9aa6d96181f3e2d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
XXX re-enable 2008 exclusion, rmv #if0 locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and I
don't understand why this wasn't such an egregious Windows bug that it
was allowed to fester all this time. It should be a common paradigm
that you want to toggle locales temporarily and get back to the
original. Perhaps the affected locales are uncommon. I'm told it is
fixed in the latest versions.
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I rewrote the function to handle LC_ALL, which can arise from the
Windows bug; a change in that that I think harmless is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: eecc30d75790b0c01b7d97b5ee8e30075fe315cd
https://github.com/Perl/perl5/commit/eecc30d75790b0c01b7d97b5ee8e30075fe315cd
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 001d4f6f2bbd24cd3fd6a29d8f28785d1d043092
https://github.com/Perl/perl5/commit/001d4f6f2bbd24cd3fd6a29d8f28785d1d043092
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 33c568309434dc0e57673864b627806eb3927858
https://github.com/Perl/perl5/commit/33c568309434dc0e57673864b627806eb3927858
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 1b0282f9664c0b1acca0eaaec67ea58a7797f5f2
https://github.com/Perl/perl5/commit/1b0282f9664c0b1acca0eaaec67ea58a7797f5f2
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 32e3c24140bbbda6b704a17f4fdc68fea38bbc13
https://github.com/Perl/perl5/commit/32e3c24140bbbda6b704a17f4fdc68fea38bbc13
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 3d0299832df5b418d0d9902744ade61aab11dd5a
https://github.com/Perl/perl5/commit/3d0299832df5b418d0d9902744ade61aab11dd5a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: e334280114ac8431a57afa4fe3dd1baec335419f
https://github.com/Perl/perl5/commit/e334280114ac8431a57afa4fe3dd1baec335419f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 542d11a7be99bd9d255cd5f89fc37a8e613120bf
https://github.com/Perl/perl5/commit/542d11a7be99bd9d255cd5f89fc37a8e613120bf
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: ec1a32dea58408b907102a5b29524f3f3a9e9dec
https://github.com/Perl/perl5/commit/ec1a32dea58408b907102a5b29524f3f3a9e9dec
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 68f1fed45bf3221d3b5a1a01712553888e7f4082
https://github.com/Perl/perl5/commit/68f1fed45bf3221d3b5a1a01712553888e7f4082
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 51286e0d83ead0816a126c3d23dc570fabf73714
https://github.com/Perl/perl5/commit/51286e0d83ead0816a126c3d23dc570fabf73714
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 8ee27b66fe4584c48bfab368ab53cf63895cf9f0
https://github.com/Perl/perl5/commit/8ee27b66fe4584c48bfab368ab53cf63895cf9f0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a8398b7decffb1c765fc7f3aabdccb65ac6b4899
https://github.com/Perl/perl5/commit/a8398b7decffb1c765fc7f3aabdccb65ac6b4899
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 514aa8522590735ec18b1799dd19043e3ff65dc9
https://github.com/Perl/perl5/commit/514aa8522590735ec18b1799dd19043e3ff65dc9
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 5f01464edd1b8ba8015eadd676ef9ed70d308c20
https://github.com/Perl/perl5/commit/5f01464edd1b8ba8015eadd676ef9ed70d308c20
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 85b8e23402288ff6bcda70063edbbb04978b03a4
https://github.com/Perl/perl5/commit/85b8e23402288ff6bcda70063edbbb04978b03a4
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: ca29aa8f9e301d5829127cdd09adce4040e01750
https://github.com/Perl/perl5/commit/ca29aa8f9e301d5829127cdd09adce4040e01750
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 70e03d048418b95e14c282f0ba4661d73dee5e16
https://github.com/Perl/perl5/commit/70e03d048418b95e14c282f0ba4661d73dee5e16
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: a76953de52833bd202330aa29226877a353f7e34
https://github.com/Perl/perl5/commit/a76953de52833bd202330aa29226877a353f7e34
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: ab10359b23673c6441b2cb1e8dca021a5ccab66a
https://github.com/Perl/perl5/commit/ab10359b23673c6441b2cb1e8dca021a5ccab66a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: f7b2d033dac35658e3195e9ea003de8c2afed89a
https://github.com/Perl/perl5/commit/f7b2d033dac35658e3195e9ea003de8c2afed89a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: d61397fd23eae1ffb0301491b420d3186fa757a5
https://github.com/Perl/perl5/commit/d61397fd23eae1ffb0301491b420d3186fa757a5
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 049ce3c0563413a5b3fecef1b8cd0682b0b06594
https://github.com/Perl/perl5/commit/049ce3c0563413a5b3fecef1b8cd0682b0b06594
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 8bec8e10c725d5e5c37ff63c09cf51e2e0b9e682
https://github.com/Perl/perl5/commit/8bec8e10c725d5e5c37ff63c09cf51e2e0b9e682
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: fab650460b755333ef8aef68093a97a7a0e524b5
https://github.com/Perl/perl5/commit/fab650460b755333ef8aef68093a97a7a0e524b5
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: b960b2460ccbebe8812474095501a0b051518246
https://github.com/Perl/perl5/commit/b960b2460ccbebe8812474095501a0b051518246
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 0bf620273c536a7d0bcfd95f2bec6d3c891b7198
https://github.com/Perl/perl5/commit/0bf620273c536a7d0bcfd95f2bec6d3c891b7198
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 47abfe139282a37dc01371a4a6719baa72dc5a2f
https://github.com/Perl/perl5/commit/47abfe139282a37dc01371a4a6719baa72dc5a2f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 306b87393a17698866c0ffd6c250b22eea23ce02
https://github.com/Perl/perl5/commit/306b87393a17698866c0ffd6c250b22eea23ce02
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 4608b0592b75757d44bb79b21c0523b44819da13
https://github.com/Perl/perl5/commit/4608b0592b75757d44bb79b21c0523b44819da13
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: fbf90e2460a23cf899bbf33b5b705c570dcdd754
https://github.com/Perl/perl5/commit/fbf90e2460a23cf899bbf33b5b705c570dcdd754
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 7d3311b07659a719bef9362d266b069083afd19c
https://github.com/Perl/perl5/commit/7d3311b07659a719bef9362d266b069083afd19c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: d8f88f18d852c97c1e3deba00d4face8bbd853cf
https://github.com/Perl/perl5/commit/d8f88f18d852c97c1e3deba00d4face8bbd853cf
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: ea36a21c4d1eaaad93fdae141ca78e12852a92db
https://github.com/Perl/perl5/commit/ea36a21c4d1eaaad93fdae141ca78e12852a92db
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 4b617812b1453bd9a8b03be4a922de5aa18f0e3f
https://github.com/Perl/perl5/commit/4b617812b1453bd9a8b03be4a922de5aa18f0e3f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 697ffe1011195ee4fa9a92b04d68c79c7199f81b
https://github.com/Perl/perl5/commit/697ffe1011195ee4fa9a92b04d68c79c7199f81b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 6d5783dace86d7cb10474121e5984e5f76325aba
https://github.com/Perl/perl5/commit/6d5783dace86d7cb10474121e5984e5f76325aba
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 86715854a6db64199d30cc931d0ad1258195280f
https://github.com/Perl/perl5/commit/86715854a6db64199d30cc931d0ad1258195280f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 3fdcc28e43feef03a2470d0a4d13e7c65b5882ef
https://github.com/Perl/perl5/commit/3fdcc28e43feef03a2470d0a4d13e7c65b5882ef
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 23678cc9d9cca6e0ef0a88e58c382bec5cd36fb5
https://github.com/Perl/perl5/commit/23678cc9d9cca6e0ef0a88e58c382bec5cd36fb5
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 1c67fff4028702c854c735cabfe75d8c285a558c
https://github.com/Perl/perl5/commit/1c67fff4028702c854c735cabfe75d8c285a558c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: d4fa98e5f7b14c48526e678e5adcc9e3d54cc2ac
https://github.com/Perl/perl5/commit/d4fa98e5f7b14c48526e678e5adcc9e3d54cc2ac
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 18279442bc221619502c5af913a0c6a5fe6bb0e4
https://github.com/Perl/perl5/commit/18279442bc221619502c5af913a0c6a5fe6bb0e4
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 42bfc6b3bfb55a6deb772a90a6ca28a7a3da59d9
https://github.com/Perl/perl5/commit/42bfc6b3bfb55a6deb772a90a6ca28a7a3da59d9
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: ae55dcae1a88ce0a17274cf830467569b482c45c
https://github.com/Perl/perl5/commit/ae55dcae1a88ce0a17274cf830467569b482c45c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: b9755c17f0b2864a128112ab0a6cc41e122746e3
https://github.com/Perl/perl5/commit/b9755c17f0b2864a128112ab0a6cc41e122746e3
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: c106d5a876eb0d5dd3badd0fd3eaa691ec8107bb
https://github.com/Perl/perl5/commit/c106d5a876eb0d5dd3badd0fd3eaa691ec8107bb
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 28d557cc3bc5238f947b940093033569efc7ed96
https://github.com/Perl/perl5/commit/28d557cc3bc5238f947b940093033569efc7ed96
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 05b2ce8c030f48c65e0f317406193680205588e0
https://github.com/Perl/perl5/commit/05b2ce8c030f48c65e0f317406193680205588e0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: fc4d2acc927d95ed4f58f37fdafb1559936db77a
https://github.com/Perl/perl5/commit/fc4d2acc927d95ed4f58f37fdafb1559936db77a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 3b38e7e9cd84d620a05f23b6ac74684b9713a375
https://github.com/Perl/perl5/commit/3b38e7e9cd84d620a05f23b6ac74684b9713a375
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: e7ef015e727b8dd7e8272f9cd9e97a6a049c0610
https://github.com/Perl/perl5/commit/e7ef015e727b8dd7e8272f9cd9e97a6a049c0610
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 224feac04b1b7b99558d38e6f8814ab51441a1cb
https://github.com/Perl/perl5/commit/224feac04b1b7b99558d38e6f8814ab51441a1cb
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: efbcae0804b7559a4ce9278cea3fd9cb4f9b91a1
https://github.com/Perl/perl5/commit/efbcae0804b7559a4ce9278cea3fd9cb4f9b91a1
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: b6f0ce7bb8ab447d9247d8c37d191229afb01172
https://github.com/Perl/perl5/commit/b6f0ce7bb8ab447d9247d8c37d191229afb01172
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 4087c78ac8201c2f1a824516c8a999b54342c508
https://github.com/Perl/perl5/commit/4087c78ac8201c2f1a824516c8a999b54342c508
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: cfc2f547d7ac09d9ca892fba893878633c46d30f
https://github.com/Perl/perl5/commit/cfc2f547d7ac09d9ca892fba893878633c46d30f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: d42bafb772c9e7ed494005bfc4c3948a6f848990
https://github.com/Perl/perl5/commit/d42bafb772c9e7ed494005bfc4c3948a6f848990
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 5bb51f05a91d1c625d1d06128b5c4312b21dd61c
https://github.com/Perl/perl5/commit/5bb51f05a91d1c625d1d06128b5c4312b21dd61c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: a3432ab70e67b572396284ed057d0943028265b5
https://github.com/Perl/perl5/commit/a3432ab70e67b572396284ed057d0943028265b5
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 9f3b73534c2b9f498d94afa878b1b17a78a696af
https://github.com/Perl/perl5/commit/9f3b73534c2b9f498d94afa878b1b17a78a696af
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 43ac238e1d9a6a3d5f3148f5ed22379a4b1da1e0
https://github.com/Perl/perl5/commit/43ac238e1d9a6a3d5f3148f5ed22379a4b1da1e0
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 586ebb8b5d174f6e4ce6d4f9819494d1a522a978
https://github.com/Perl/perl5/commit/586ebb8b5d174f6e4ce6d4f9819494d1a522a978
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: c4da9a2d8f86b4a02bf13c0dd12959653abc241f
https://github.com/Perl/perl5/commit/c4da9a2d8f86b4a02bf13c0dd12959653abc241f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: e07b1a9a69268b8e7d29803e2aa7b36013e44be6
https://github.com/Perl/perl5/commit/e07b1a9a69268b8e7d29803e2aa7b36013e44be6
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 0367f1a72c6bfffe3a7433eb8d5b88e6905e5e9c
https://github.com/Perl/perl5/commit/0367f1a72c6bfffe3a7433eb8d5b88e6905e5e9c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 6321603c1d2d3bba714a727d1647ddf63a2922b3
https://github.com/Perl/perl5/commit/6321603c1d2d3bba714a727d1647ddf63a2922b3
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 29d1753cecaf65968594887e405b89d59786f0a4
https://github.com/Perl/perl5/commit/29d1753cecaf65968594887e405b89d59786f0a4
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 66a202059120cb38f7c42c4c6b6407f4146dbfaa
https://github.com/Perl/perl5/commit/66a202059120cb38f7c42c4c6b6407f4146dbfaa
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 593db87cce68b385469e1cfe7f99038b34e1269c
https://github.com/Perl/perl5/commit/593db87cce68b385469e1cfe7f99038b34e1269c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: da8567d3499d99273e522d78f20b0240a2b5537c
https://github.com/Perl/perl5/commit/da8567d3499d99273e522d78f20b0240a2b5537c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 3fa48530925ee23cfc194d9f4b4bcab791737f48
https://github.com/Perl/perl5/commit/3fa48530925ee23cfc194d9f4b4bcab791737f48
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 0223c9d2e9b75996587944f7341ca848b2b1c81a
https://github.com/Perl/perl5/commit/0223c9d2e9b75996587944f7341ca848b2b1c81a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 2dbe6728516aed54a0e4418a3adec602c3f910cc
https://github.com/Perl/perl5/commit/2dbe6728516aed54a0e4418a3adec602c3f910cc
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: ee2ebf055b94e2bd7395da44c252ee5cd026b114
https://github.com/Perl/perl5/commit/ee2ebf055b94e2bd7395da44c252ee5cd026b114
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 54b80367e2d086d859070ca394afa2643fbdc08b
https://github.com/Perl/perl5/commit/54b80367e2d086d859070ca394afa2643fbdc08b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: c0679ac1232939ee08d3cfdec218531b7a1f31c7
https://github.com/Perl/perl5/commit/c0679ac1232939ee08d3cfdec218531b7a1f31c7
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: ac29fa1bfef7cf76fe3ce84c0a0f0505a665266d
https://github.com/Perl/perl5/commit/ac29fa1bfef7cf76fe3ce84c0a0f0505a665266d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 921625d173d67746e5b72e0cbdadd87d873aac24
https://github.com/Perl/perl5/commit/921625d173d67746e5b72e0cbdadd87d873aac24
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: cc73a2f3399b309453b76dbdba50761331cdba77
https://github.com/Perl/perl5/commit/cc73a2f3399b309453b76dbdba50761331cdba77
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 5857c89e2114dd45853f5101136edbe50029a728
https://github.com/Perl/perl5/commit/5857c89e2114dd45853f5101136edbe50029a728
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: ac84514b861d8165eb93031322b2cd178d587e9c
https://github.com/Perl/perl5/commit/ac84514b861d8165eb93031322b2cd178d587e9c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d632ed2c384d3bbd83af217927f66e5673af1eb3
https://github.com/Perl/perl5/commit/d632ed2c384d3bbd83af217927f66e5673af1eb3
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: f617f8972ba5fbdbc52c0c71a8c5449c47bf8026
https://github.com/Perl/perl5/commit/f617f8972ba5fbdbc52c0c71a8c5449c47bf8026
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 0f9c90115e71f266153a86dfb4642e5c7ba53a7d
https://github.com/Perl/perl5/commit/0f9c90115e71f266153a86dfb4642e5c7ba53a7d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 0c1fea814e2a0da6fe3b20b5bea9614e27dc9c0d
https://github.com/Perl/perl5/commit/0c1fea814e2a0da6fe3b20b5bea9614e27dc9c0d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: fa21102970c11e2cd4af0314ce3fd83076e88d0b
https://github.com/Perl/perl5/commit/fa21102970c11e2cd4af0314ce3fd83076e88d0b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0d29599b24f7b1feadbc9d45f5a55c50fd8988d7
https://github.com/Perl/perl5/commit/0d29599b24f7b1feadbc9d45f5a55c50fd8988d7
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 1fcdb622b1f31b1b0dae533eeb76135d18fbb3cf
https://github.com/Perl/perl5/commit/1fcdb622b1f31b1b0dae533eeb76135d18fbb3cf
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 0553b82067abbc4d0aad24355e1680924b6e4bd2
https://github.com/Perl/perl5/commit/0553b82067abbc4d0aad24355e1680924b6e4bd2
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 680b31d333053d2a96f65498e6455d8ddaf12236
https://github.com/Perl/perl5/commit/680b31d333053d2a96f65498e6455d8ddaf12236
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: fc4f9c4607f668cc8eee15f63a77d678125e2f2e
https://github.com/Perl/perl5/commit/fc4f9c4607f668cc8eee15f63a77d678125e2f2e
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 5eceb47f22917e2c377b5fad7a5ca1d5c32df88c
https://github.com/Perl/perl5/commit/5eceb47f22917e2c377b5fad7a5ca1d5c32df88c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 3791c2ee1683688a2fd0f1337a8459da69c47d7b
https://github.com/Perl/perl5/commit/3791c2ee1683688a2fd0f1337a8459da69c47d7b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5e20be352add50a359383ff93aea3a1ea5655d7f
https://github.com/Perl/perl5/commit/5e20be352add50a359383ff93aea3a1ea5655d7f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: d55e5c3f214725f0d48d97543d506004f2392699
https://github.com/Perl/perl5/commit/d55e5c3f214725f0d48d97543d506004f2392699
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 6afc53eada78db9be784d5845e784799b3fb69b6
https://github.com/Perl/perl5/commit/6afc53eada78db9be784d5845e784799b3fb69b6
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 91928bd894514626ba02e4bd806ffd2697061f27
https://github.com/Perl/perl5/commit/91928bd894514626ba02e4bd806ffd2697061f27
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: e1934743848c8c545b9371a603340ce564d801be
https://github.com/Perl/perl5/commit/e1934743848c8c545b9371a603340ce564d801be
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 9f7ff1101520c6b6b631334118115d81e0dece6b
https://github.com/Perl/perl5/commit/9f7ff1101520c6b6b631334118115d81e0dece6b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: fd0dd8b381a226d87e98f731c110ade0e1eedb42
https://github.com/Perl/perl5/commit/fd0dd8b381a226d87e98f731c110ade0e1eedb42
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 7d3aadb90945cad25ee1cfe01bda4bbf271a8d2b
https://github.com/Perl/perl5/commit/7d3aadb90945cad25ee1cfe01bda4bbf271a8d2b
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: b3215f4ac135e29bb1bb3df66ee032976920f997
https://github.com/Perl/perl5/commit/b3215f4ac135e29bb1bb3df66ee032976920f997
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 2c39b8b5e9c60339a801eece1d56dc4111af674f
https://github.com/Perl/perl5/commit/2c39b8b5e9c60339a801eece1d56dc4111af674f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 7855e185a2df314e48b3d77ab0bb766173b28d24
https://github.com/Perl/perl5/commit/7855e185a2df314e48b3d77ab0bb766173b28d24
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: bf31d9a99a933342a307351bd7521f44ce55a16d
https://github.com/Perl/perl5/commit/bf31d9a99a933342a307351bd7521f44ce55a16d
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 0df3bab2054d2a313fd93c4bdd9365db0b50176c
https://github.com/Perl/perl5/commit/0df3bab2054d2a313fd93c4bdd9365db0b50176c
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 6e4e2f2a51040b747797bd34df013811de741574
https://github.com/Perl/perl5/commit/6e4e2f2a51040b747797bd34df013811de741574
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 53e10dee7c5ca8d79b9142afa7379dd20900e4a5
https://github.com/Perl/perl5/commit/53e10dee7c5ca8d79b9142afa7379dd20900e4a5
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 07670ad6299a1f3ec66e3f47d83e80bd65b47999
https://github.com/Perl/perl5/commit/07670ad6299a1f3ec66e3f47d83e80bd65b47999
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: ab93b5322cb079802685d990661c386d96fa8a0f
https://github.com/Perl/perl5/commit/ab93b5322cb079802685d990661c386d96fa8a0f
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: cdb5f6ea0f96e68b6c5a78f68ebb4f0b52a042ba
https://github.com/Perl/perl5/commit/cdb5f6ea0f96e68b6c5a78f68ebb4f0b52a042ba
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 540b5cb749a2fd698706d35c3b554a8ef83a93f6
https://github.com/Perl/perl5/commit/540b5cb749a2fd698706d35c3b554a8ef83a93f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: bb98cdd2be1f5769dde6cf18d15740caf99caea7
https://github.com/Perl/perl5/commit/bb98cdd2be1f5769dde6cf18d15740caf99caea7
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 7f2b339e361412b8199d7f2c11182fc8a41760ff
https://github.com/Perl/perl5/commit/7f2b339e361412b8199d7f2c11182fc8a41760ff
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5c1dd569451a5aaa7f45f29528ddab51b9aef936
https://github.com/Perl/perl5/commit/5c1dd569451a5aaa7f45f29528ddab51b9aef936
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c2edff49c53bbb041d35620e55eab16685e5ecd8
https://github.com/Perl/perl5/commit/c2edff49c53bbb041d35620e55eab16685e5ecd8
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 9ab18043768c589eaf45c33e690018dcdf9c34ae
https://github.com/Perl/perl5/commit/9ab18043768c589eaf45c33e690018dcdf9c34ae
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 271e0048b6d0e35e84680b595f9d66524f83fdd3
https://github.com/Perl/perl5/commit/271e0048b6d0e35e84680b595f9d66524f83fdd3
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 64653e39ae9a17dacf32bcf013dfc2a53b89c389
https://github.com/Perl/perl5/commit/64653e39ae9a17dacf32bcf013dfc2a53b89c389
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 35cc5e8aa70ecabc8631f2c4abb58fa03abb8bb7
https://github.com/Perl/perl5/commit/35cc5e8aa70ecabc8631f2c4abb58fa03abb8bb7
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 77b97b34aaa5511c7fae7d8e3bb3b0e9bc1885f8
https://github.com/Perl/perl5/commit/77b97b34aaa5511c7fae7d8e3bb3b0e9bc1885f8
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: cbbc35c84ed0363e3b4fc15bf78e17649a76b2f2
https://github.com/Perl/perl5/commit/cbbc35c84ed0363e3b4fc15bf78e17649a76b2f2
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 41009327c52675422b9ecefc3bc6527185cd5d7a
https://github.com/Perl/perl5/commit/41009327c52675422b9ecefc3bc6527185cd5d7a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 28c1d0186a03ce154e9d682ee90a3c637cfe4cbd
https://github.com/Perl/perl5/commit/28c1d0186a03ce154e9d682ee90a3c637cfe4cbd
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 3aa4dbd9393e8d06b129075d5e16422d74a47a12
https://github.com/Perl/perl5/commit/3aa4dbd9393e8d06b129075d5e16422d74a47a12
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 7fa8c5a62f517a398fe51daaaecff49f18d5c915
https://github.com/Perl/perl5/commit/7fa8c5a62f517a398fe51daaaecff49f18d5c915
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 1bcef08e2040d5ab587e09cf368c66026d017e66
https://github.com/Perl/perl5/commit/1bcef08e2040d5ab587e09cf368c66026d017e66
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 5c8fb8f732af7493bb51932f1eb802c75cd156aa
https://github.com/Perl/perl5/commit/5c8fb8f732af7493bb51932f1eb802c75cd156aa
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
run/locale.t temp win
Commit: e12a6a8a51984c7d2cffa490aae1957b0c83e909
https://github.com/Perl/perl5/commit/e12a6a8a51984c7d2cffa490aae1957b0c83e909
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 22c7ebc9332c3b4a773b025463e080c98d006eb1
https://github.com/Perl/perl5/commit/22c7ebc9332c3b4a773b025463e080c98d006eb1
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Change tabs to blanks; Fix indentation
Remove some unneeded blank lines
Commit: 75444048f5e36e189c057462b216b1717a3bbec7
https://github.com/Perl/perl5/commit/75444048f5e36e189c057462b216b1717a3bbec7
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil
Commit: 766a27199b67533c078ee01ede97221ebe8ca15a
https://github.com/Perl/perl5/commit/766a27199b67533c078ee01ede97221ebe8ca15a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: e425c2db3005a8438158622d2261dae6ede8d809
https://github.com/Perl/perl5/commit/e425c2db3005a8438158622d2261dae6ede8d809
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
loc_tools: debug, white space
Commit: a762c6fbc46e70bb45e2fb497f15c11ded67b8cf
https://github.com/Perl/perl5/commit/a762c6fbc46e70bb45e2fb497f15c11ded67b8cf
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 090e005cf431d95cb62ec77beb78312184f7962a
https://github.com/Perl/perl5/commit/090e005cf431d95cb62ec77beb78312184f7962a
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 611c4e00707c035d88b262b4d2e213af1beb27c4
https://github.com/Perl/perl5/commit/611c4e00707c035d88b262b4d2e213af1beb27c4
Author: Karl Williamson <[email protected]>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy
Compare: https://github.com/Perl/perl5/compare/92d88ebec4b0...611c4e00707c
