Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 2972614d491a926738dc6217cc9fa17fe037837c
https://github.com/Perl/perl5/commit/2972614d491a926738dc6217cc9fa17fe037837c
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: d6b706f329ff58c8d34d0b3e8e0e87d1f11aaa01
https://github.com/Perl/perl5/commit/d6b706f329ff58c8d34d0b3e8e0e87d1f11aaa01
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 57122409c7a5da9b82c6fc138ac0044674fac1fb
https://github.com/Perl/perl5/commit/57122409c7a5da9b82c6fc138ac0044674fac1fb
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 810af393f26dabefb54aa0122fae3b6856449d93
https://github.com/Perl/perl5/commit/810af393f26dabefb54aa0122fae3b6856449d93
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 61efe86475244b38553ba381d6a9c68c86be0010
https://github.com/Perl/perl5/commit/61efe86475244b38553ba381d6a9c68c86be0010
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 569b71558b7a7c8f1431a0c73e8891a260f5d20b
https://github.com/Perl/perl5/commit/569b71558b7a7c8f1431a0c73e8891a260f5d20b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 80728a5011e18c4bf75018d8f1604b3a13618434
https://github.com/Perl/perl5/commit/80728a5011e18c4bf75018d8f1604b3a13618434
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: a67c3431dd638ced461643af5a74d4452c668b35
https://github.com/Perl/perl5/commit/a67c3431dd638ced461643af5a74d4452c668b35
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: e86c73aeb46abb45df90c9ecb4acfa4259030242
https://github.com/Perl/perl5/commit/e86c73aeb46abb45df90c9ecb4acfa4259030242
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: eb33e402021d29587ed66b454154ec87bbb156b5
https://github.com/Perl/perl5/commit/eb33e402021d29587ed66b454154ec87bbb156b5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: da47b04952c4b3bcc86cb59fa4ae8d1816de4fe8
https://github.com/Perl/perl5/commit/da47b04952c4b3bcc86cb59fa4ae8d1816de4fe8
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 28315fb55f9fb607d5ffbb48dadf9254ea2f148e
https://github.com/Perl/perl5/commit/28315fb55f9fb607d5ffbb48dadf9254ea2f148e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 3f88f3d325832ad7006917d126772af83f403e38
https://github.com/Perl/perl5/commit/3f88f3d325832ad7006917d126772af83f403e38
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 1b3db0ee0cf4477e26d3236bc0ca6620a6242eb7
https://github.com/Perl/perl5/commit/1b3db0ee0cf4477e26d3236bc0ca6620a6242eb7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 4ad6785b89dbfedcd4e23789527fe148f6267989
https://github.com/Perl/perl5/commit/4ad6785b89dbfedcd4e23789527fe148f6267989
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 31c3b629913389e6d3c343352754680337ebe505
https://github.com/Perl/perl5/commit/31c3b629913389e6d3c343352754680337ebe505
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: d0d39af6aa6d1324021af07fb15fb3a9375131a4
https://github.com/Perl/perl5/commit/d0d39af6aa6d1324021af07fb15fb3a9375131a4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5dea2f8ef837b992eaa2066ad229b7ae4cc9a2ca
https://github.com/Perl/perl5/commit/5dea2f8ef837b992eaa2066ad229b7ae4cc9a2ca
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 8bd3d4cff24e3b671d282f199c4226e355039df4
https://github.com/Perl/perl5/commit/8bd3d4cff24e3b671d282f199c4226e355039df4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: f9bbe8027e2c45a6c2adc7b930949eccdfaae133
https://github.com/Perl/perl5/commit/f9bbe8027e2c45a6c2adc7b930949eccdfaae133
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 6ae71ef22b6a5ad9ee1c2e5fc8913d28dc715ced
https://github.com/Perl/perl5/commit/6ae71ef22b6a5ad9ee1c2e5fc8913d28dc715ced
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: a55e89a7175b98b5ccaa823eba16f32f88c53a09
https://github.com/Perl/perl5/commit/a55e89a7175b98b5ccaa823eba16f32f88c53a09
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 4b1f33d8638f4f9c29b2c44534ab066a248dd4ce
https://github.com/Perl/perl5/commit/4b1f33d8638f4f9c29b2c44534ab066a248dd4ce
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 6ebeb0e97abb756686556fca3ae83359ccf6262a
https://github.com/Perl/perl5/commit/6ebeb0e97abb756686556fca3ae83359ccf6262a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 8b72f7bf00789637b5cbec5104dc5683e1401a7c
https://github.com/Perl/perl5/commit/8b72f7bf00789637b5cbec5104dc5683e1401a7c
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 1518e6316f2dc3312f4309c0901e461e5e4cbe2c
https://github.com/Perl/perl5/commit/1518e6316f2dc3312f4309c0901e461e5e4cbe2c
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 17f74a08160266f404bd60ac0febd1f0790cdb96
https://github.com/Perl/perl5/commit/17f74a08160266f404bd60ac0febd1f0790cdb96
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: afd1e1178b2aa95e8948499a9a927efe767078e9
https://github.com/Perl/perl5/commit/afd1e1178b2aa95e8948499a9a927efe767078e9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: b7071be1e2f912582d6ff227da4411f07e5708e7
https://github.com/Perl/perl5/commit/b7071be1e2f912582d6ff227da4411f07e5708e7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 7adbc21257b39817f69566334a07996fd6187a78
https://github.com/Perl/perl5/commit/7adbc21257b39817f69566334a07996fd6187a78
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 6cc2d70a422a1f417b396d4cef618528a96a3eba
https://github.com/Perl/perl5/commit/6cc2d70a422a1f417b396d4cef618528a96a3eba
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 5cfafd7f52384a982392732e5cff19ffdee7cb32
https://github.com/Perl/perl5/commit/5cfafd7f52384a982392732e5cff19ffdee7cb32
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 8187b6469c951538c14e317e19fea5e543777bc0
https://github.com/Perl/perl5/commit/8187b6469c951538c14e317e19fea5e543777bc0
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 3eb20eaed8007d9cf7a50c602f0a9c54a95be1c4
https://github.com/Perl/perl5/commit/3eb20eaed8007d9cf7a50c602f0a9c54a95be1c4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: d9dfe22552b775b283282ba0d3bafe4bc736d4be
https://github.com/Perl/perl5/commit/d9dfe22552b775b283282ba0d3bafe4bc736d4be
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 371112f7a2322bd4d433cb4df18fa75f9791723d
https://github.com/Perl/perl5/commit/371112f7a2322bd4d433cb4df18fa75f9791723d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 7f26c63990b544dc8152596648ec8fea6ece5f7b
https://github.com/Perl/perl5/commit/7f26c63990b544dc8152596648ec8fea6ece5f7b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 33e859128b5623b4920b862f1d4f988f44554265
https://github.com/Perl/perl5/commit/33e859128b5623b4920b862f1d4f988f44554265
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 960960226de3effa56d127a8d43258cd141b1901
https://github.com/Perl/perl5/commit/960960226de3effa56d127a8d43258cd141b1901
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 34bc59c08bbb396b29ca478f7cb64ef0809a2ea3
https://github.com/Perl/perl5/commit/34bc59c08bbb396b29ca478f7cb64ef0809a2ea3
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 501526ba69181357dbc7cceaff48fc700e5ce66e
https://github.com/Perl/perl5/commit/501526ba69181357dbc7cceaff48fc700e5ce66e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 4b5aa002c69ba6ff5a4c35a6da7187b4d94dc15d
https://github.com/Perl/perl5/commit/4b5aa002c69ba6ff5a4c35a6da7187b4d94dc15d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 8efbebf3cc09d2938419fdcf219b017e454a9bab
https://github.com/Perl/perl5/commit/8efbebf3cc09d2938419fdcf219b017e454a9bab
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 54209287970ce23354a580617b61a4fc96b2c182
https://github.com/Perl/perl5/commit/54209287970ce23354a580617b61a4fc96b2c182
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: c396f4282022db93b0037b6306ecab21b53e7289
https://github.com/Perl/perl5/commit/c396f4282022db93b0037b6306ecab21b53e7289
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 6393be48dc61f72e607e66d6c151f94dcd10dcca
https://github.com/Perl/perl5/commit/6393be48dc61f72e607e66d6c151f94dcd10dcca
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 9b4215445550ae50858ff3141cde61c13596b9ec
https://github.com/Perl/perl5/commit/9b4215445550ae50858ff3141cde61c13596b9ec
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: e235f01572777178085af57ea1a7c80884514c63
https://github.com/Perl/perl5/commit/e235f01572777178085af57ea1a7c80884514c63
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 799c6c4dc4e90b9c651a27bb04a0282d497482c9
https://github.com/Perl/perl5/commit/799c6c4dc4e90b9c651a27bb04a0282d497482c9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 12671385fac3643e60ba972534df1252b04881ff
https://github.com/Perl/perl5/commit/12671385fac3643e60ba972534df1252b04881ff
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 5a82f3b092b918a423f1a56a1a088974a7048b82
https://github.com/Perl/perl5/commit/5a82f3b092b918a423f1a56a1a088974a7048b82
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 18c95a6da7e0110d9625d19ebd22dc8b851310ba
https://github.com/Perl/perl5/commit/18c95a6da7e0110d9625d19ebd22dc8b851310ba
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 2fbd227fe3cac3ca39324947d718d2b2fa1e84e9
https://github.com/Perl/perl5/commit/2fbd227fe3cac3ca39324947d718d2b2fa1e84e9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 921c6d645892e180c369bbd5c748fa845e115a51
https://github.com/Perl/perl5/commit/921c6d645892e180c369bbd5c748fa845e115a51
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: bb54011c5b7226940fa5e21e6415d7bc28f74d3f
https://github.com/Perl/perl5/commit/bb54011c5b7226940fa5e21e6415d7bc28f74d3f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: bcf604a7e1c337f209edd54f196891db4f08e60d
https://github.com/Perl/perl5/commit/bcf604a7e1c337f209edd54f196891db4f08e60d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 433ab9b9307a0c881667d82567e52089ac4d605b
https://github.com/Perl/perl5/commit/433ab9b9307a0c881667d82567e52089ac4d605b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 79e3f41bfdb08854001abc8745a741438ead7877
https://github.com/Perl/perl5/commit/79e3f41bfdb08854001abc8745a741438ead7877
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 6710f046d5e80b350a50b532761a361a66a014d2
https://github.com/Perl/perl5/commit/6710f046d5e80b350a50b532761a361a66a014d2
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 8777573efd18b42c8dd16f733a132c295bc9b074
https://github.com/Perl/perl5/commit/8777573efd18b42c8dd16f733a132c295bc9b074
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: c9fed7a75bc804099e1510c067a5dc50909bf732
https://github.com/Perl/perl5/commit/c9fed7a75bc804099e1510c067a5dc50909bf732
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 48845aecd838ee57686c696949cb6cf6af462e45
https://github.com/Perl/perl5/commit/48845aecd838ee57686c696949cb6cf6af462e45
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1c7cc15ecc6bf83af0fcad82cc3fadaab65c17ef
https://github.com/Perl/perl5/commit/1c7cc15ecc6bf83af0fcad82cc3fadaab65c17ef
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 63cbe467fb31486c4e9dbe06f85bc14f47623867
https://github.com/Perl/perl5/commit/63cbe467fb31486c4e9dbe06f85bc14f47623867
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 2bac84a5582bb0a45cba366a6cfe41fe4e5b0848
https://github.com/Perl/perl5/commit/2bac84a5582bb0a45cba366a6cfe41fe4e5b0848
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d0cb58a8d1bc8192096f23ea17cc018eb61d490c
https://github.com/Perl/perl5/commit/d0cb58a8d1bc8192096f23ea17cc018eb61d490c
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: e97484618f00a52fc2824047c4c036c178f79a81
https://github.com/Perl/perl5/commit/e97484618f00a52fc2824047c4c036c178f79a81
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: f74b3e30434c50d6d284647c86e133d3bedce50a
https://github.com/Perl/perl5/commit/f74b3e30434c50d6d284647c86e133d3bedce50a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 61bc960f2653ab00d637ac27aba1b0fd1ba334d0
https://github.com/Perl/perl5/commit/61bc960f2653ab00d637ac27aba1b0fd1ba334d0
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e0300a22d9363ac8ae3ba1942788505b2c0c1ac1
https://github.com/Perl/perl5/commit/e0300a22d9363ac8ae3ba1942788505b2c0c1ac1
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 64d22c558f5297ed2567ac88fac0d4e41db52742
https://github.com/Perl/perl5/commit/64d22c558f5297ed2567ac88fac0d4e41db52742
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 510ab9275719f64e5f1a650ac88002b83764a55e
https://github.com/Perl/perl5/commit/510ab9275719f64e5f1a650ac88002b83764a55e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 58763a4834f60ec4b0496e241d8bdecf091f714a
https://github.com/Perl/perl5/commit/58763a4834f60ec4b0496e241d8bdecf091f714a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 44052bf2fd79f5f9a61da824f690c7d29f60cfab
https://github.com/Perl/perl5/commit/44052bf2fd79f5f9a61da824f690c7d29f60cfab
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: c147c4cbdd43ed4090ac8881485793cf664af7b4
https://github.com/Perl/perl5/commit/c147c4cbdd43ed4090ac8881485793cf664af7b4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: a670534a91b1be2e4e511b5936709c6e908b5689
https://github.com/Perl/perl5/commit/a670534a91b1be2e4e511b5936709c6e908b5689
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: f21ac63a1bf9f3bb01867e51a6c091e66b118bc0
https://github.com/Perl/perl5/commit/f21ac63a1bf9f3bb01867e51a6c091e66b118bc0
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 96aa33b9337c6b16e468557a86084610e6afe3c7
https://github.com/Perl/perl5/commit/96aa33b9337c6b16e468557a86084610e6afe3c7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 330bdc05fb07cc8cce6f16349050fffb86c9e4e0
https://github.com/Perl/perl5/commit/330bdc05fb07cc8cce6f16349050fffb86c9e4e0
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: a1741e181f42a81a6862818cd54c588e66b687f1
https://github.com/Perl/perl5/commit/a1741e181f42a81a6862818cd54c588e66b687f1
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 3f653daee8da76d8f2891cb799b1bd9143a391cd
https://github.com/Perl/perl5/commit/3f653daee8da76d8f2891cb799b1bd9143a391cd
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 21456c3866e51de70371df9fc2bf8f00964311ec
https://github.com/Perl/perl5/commit/21456c3866e51de70371df9fc2bf8f00964311ec
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 5907d165c982cf5aed92c8161a758badcf20b795
https://github.com/Perl/perl5/commit/5907d165c982cf5aed92c8161a758badcf20b795
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: d198db2a4f29693cad0907e2c6ba7737ccaae18e
https://github.com/Perl/perl5/commit/d198db2a4f29693cad0907e2c6ba7737ccaae18e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 544e3a97c2f8ab3b30e6ad5ab709247e7381e936
https://github.com/Perl/perl5/commit/544e3a97c2f8ab3b30e6ad5ab709247e7381e936
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 2bb9c47e9375095e39e441f6565bbc6b7e26f28b
https://github.com/Perl/perl5/commit/2bb9c47e9375095e39e441f6565bbc6b7e26f28b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: ea850a73503422029761811d20469424477abc86
https://github.com/Perl/perl5/commit/ea850a73503422029761811d20469424477abc86
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: d3ce02beff938da9e64e96ca040e2aa49e409018
https://github.com/Perl/perl5/commit/d3ce02beff938da9e64e96ca040e2aa49e409018
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: f0d15f297526a8835bd556f5065f3c0bc967ef5a
https://github.com/Perl/perl5/commit/f0d15f297526a8835bd556f5065f3c0bc967ef5a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 825692e3080be16075013c7ddede50088201ae7b
https://github.com/Perl/perl5/commit/825692e3080be16075013c7ddede50088201ae7b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 17469de9f209b72da1f1ba236ae7e3fff9a35933
https://github.com/Perl/perl5/commit/17469de9f209b72da1f1ba236ae7e3fff9a35933
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 87978ef958dae2ae5af3da851f0aadc9560c6211
https://github.com/Perl/perl5/commit/87978ef958dae2ae5af3da851f0aadc9560c6211
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 4025b9f7aa9e77dc119efee00f72a402fbcbbe3f
https://github.com/Perl/perl5/commit/4025b9f7aa9e77dc119efee00f72a402fbcbbe3f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 1000c86aa794002c86ee6a39772e24484d209b56
https://github.com/Perl/perl5/commit/1000c86aa794002c86ee6a39772e24484d209b56
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 8e5a7d99a86614d3f725bd738220af60eb2422f6
https://github.com/Perl/perl5/commit/8e5a7d99a86614d3f725bd738220af60eb2422f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9135a8b429c4b999298ea29151672f459095835f
https://github.com/Perl/perl5/commit/9135a8b429c4b999298ea29151672f459095835f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 16fe572cc092404a25e75ba32a2d9b1589e4a0b1
https://github.com/Perl/perl5/commit/16fe572cc092404a25e75ba32a2d9b1589e4a0b1
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: a4b03bb04ff2ca01a2c0b7f907d7ed8effd93993
https://github.com/Perl/perl5/commit/a4b03bb04ff2ca01a2c0b7f907d7ed8effd93993
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 23b31b9788691e6ffbdb024d9ed6ad9c0d3e60a5
https://github.com/Perl/perl5/commit/23b31b9788691e6ffbdb024d9ed6ad9c0d3e60a5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: f4c0c6fdcb29a74bef6ceff9b2b2d5064c3c1dba
https://github.com/Perl/perl5/commit/f4c0c6fdcb29a74bef6ceff9b2b2d5064c3c1dba
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 0c068aeac91949aec1504fcabdf7f7d7608a4a19
https://github.com/Perl/perl5/commit/0c068aeac91949aec1504fcabdf7f7d7608a4a19
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: ec4be6f13c83804b0e72e1990eec1aa9bd6d9aeb
https://github.com/Perl/perl5/commit/ec4be6f13c83804b0e72e1990eec1aa9bd6d9aeb
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 0bd730e7540d177820ba552778306ae95a803446
https://github.com/Perl/perl5/commit/0bd730e7540d177820ba552778306ae95a803446
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: e2cf36c3625bafae90a31c7ec449b6e423f35f10
https://github.com/Perl/perl5/commit/e2cf36c3625bafae90a31c7ec449b6e423f35f10
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: b5c340e68f4736e7ca08246ed5800f436cfb3807
https://github.com/Perl/perl5/commit/b5c340e68f4736e7ca08246ed5800f436cfb3807
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 11f37ab8bbba5f1a32c84b406afa7d1931bb7dfa
https://github.com/Perl/perl5/commit/11f37ab8bbba5f1a32c84b406afa7d1931bb7dfa
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 3395baa19160e1833238ad8ef0d88be1ee107f4a
https://github.com/Perl/perl5/commit/3395baa19160e1833238ad8ef0d88be1ee107f4a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 50b574ae5db6a5d4f1c87ef50a0b159b279a4b8e
https://github.com/Perl/perl5/commit/50b574ae5db6a5d4f1c87ef50a0b159b279a4b8e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 1f7c93b8cf98eb2bed84770e92829915a6e25ecc
https://github.com/Perl/perl5/commit/1f7c93b8cf98eb2bed84770e92829915a6e25ecc
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 9f76e6fb9ce55fdc3e6a48bb4536b643d3c46808
https://github.com/Perl/perl5/commit/9f76e6fb9ce55fdc3e6a48bb4536b643d3c46808
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 3cc02611c9a38334193c892375160c60eb4193c7
https://github.com/Perl/perl5/commit/3cc02611c9a38334193c892375160c60eb4193c7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 7666e697b1288ab01f7ff1a6d7189a962d4b4bb3
https://github.com/Perl/perl5/commit/7666e697b1288ab01f7ff1a6d7189a962d4b4bb3
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 44dd6aa024806454cd7367f403d96184a03698e3
https://github.com/Perl/perl5/commit/44dd6aa024806454cd7367f403d96184a03698e3
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: dd29437402b6b3c2aa8a800eb3db91f236bd661f
https://github.com/Perl/perl5/commit/dd29437402b6b3c2aa8a800eb3db91f236bd661f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: f9f0fdcf3fac911fb3e2952fdb065fb78ab90caf
https://github.com/Perl/perl5/commit/f9f0fdcf3fac911fb3e2952fdb065fb78ab90caf
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 5831600d8b833615366ede685ffe3f1310fb0093
https://github.com/Perl/perl5/commit/5831600d8b833615366ede685ffe3f1310fb0093
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 913fd80c287913211bd2b46b2840cd38e7e5d843
https://github.com/Perl/perl5/commit/913fd80c287913211bd2b46b2840cd38e7e5d843
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: f18db28b3220581a9ad4c5eb4c9eb25d73427dd6
https://github.com/Perl/perl5/commit/f18db28b3220581a9ad4c5eb4c9eb25d73427dd6
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: b4ef0a6405a24cc12e9a52a834bcbf915c31bbfe
https://github.com/Perl/perl5/commit/b4ef0a6405a24cc12e9a52a834bcbf915c31bbfe
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 08a851923951628d77fa6e6862e9f9d0d5daa258
https://github.com/Perl/perl5/commit/08a851923951628d77fa6e6862e9f9d0d5daa258
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 84c187633130630590a572a3cfc672427e17ccdb
https://github.com/Perl/perl5/commit/84c187633130630590a572a3cfc672427e17ccdb
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: fc05966899d828470b158511f73e7ad4e0f34f16
https://github.com/Perl/perl5/commit/fc05966899d828470b158511f73e7ad4e0f34f16
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 72a169cded6bc238aa2658f2ef243bb88b8b1396
https://github.com/Perl/perl5/commit/72a169cded6bc238aa2658f2ef243bb88b8b1396
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: d293ef488cc96432b63fcc4709dccbeb6dac230e
https://github.com/Perl/perl5/commit/d293ef488cc96432b63fcc4709dccbeb6dac230e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: ca530f581daf75fdffe2dd79a9ae46c14d720260
https://github.com/Perl/perl5/commit/ca530f581daf75fdffe2dd79a9ae46c14d720260
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: d4bd0e40df3a73bdadad749925c9ddc3fd1b59ec
https://github.com/Perl/perl5/commit/d4bd0e40df3a73bdadad749925c9ddc3fd1b59ec
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 6440ea5b338dfe0762c694ef5a3b681f967d1796
https://github.com/Perl/perl5/commit/6440ea5b338dfe0762c694ef5a3b681f967d1796
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: af3f51fa10ffba7a445a053408e5147c929597ab
https://github.com/Perl/perl5/commit/af3f51fa10ffba7a445a053408e5147c929597ab
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: d17fa13ab043cdac34963c72d29c6deb559622ca
https://github.com/Perl/perl5/commit/d17fa13ab043cdac34963c72d29c6deb559622ca
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 4b787cd238a6e3725c43b44d446dd651ebe72085
https://github.com/Perl/perl5/commit/4b787cd238a6e3725c43b44d446dd651ebe72085
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 29c564ab48b4935e996f1ed1b472d4f8abb3fa0b
https://github.com/Perl/perl5/commit/29c564ab48b4935e996f1ed1b472d4f8abb3fa0b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 5e9781d01c07a4d8874925b4327a63e2b0792607
https://github.com/Perl/perl5/commit/5e9781d01c07a4d8874925b4327a63e2b0792607
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 793a600d93672f4c38da953a0c9d0b79717eeb0d
https://github.com/Perl/perl5/commit/793a600d93672f4c38da953a0c9d0b79717eeb0d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 57732effaabf099cc56f894300ff6a5923527ed0
https://github.com/Perl/perl5/commit/57732effaabf099cc56f894300ff6a5923527ed0
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: dcdc6e6e9f3b4236f70b9013b9afacc63797d20f
https://github.com/Perl/perl5/commit/dcdc6e6e9f3b4236f70b9013b9afacc63797d20f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: b7d7ca2dbaf46bee83bced01b89cba47ab13e689
https://github.com/Perl/perl5/commit/b7d7ca2dbaf46bee83bced01b89cba47ab13e689
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: a4ea7986ec93b5cabc947e5bc5d1cf5bf4f79715
https://github.com/Perl/perl5/commit/a4ea7986ec93b5cabc947e5bc5d1cf5bf4f79715
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 688846d5f666a375f3e344b0e0cbfb2d2f911e5b
https://github.com/Perl/perl5/commit/688846d5f666a375f3e344b0e0cbfb2d2f911e5b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: bfb1760133697c82a8b477339bf9acd9c6fae63d
https://github.com/Perl/perl5/commit/bfb1760133697c82a8b477339bf9acd9c6fae63d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 7ad6f1de741f06dfe3563e4c379097c3d71d25d4
https://github.com/Perl/perl5/commit/7ad6f1de741f06dfe3563e4c379097c3d71d25d4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 62753b026cf494d2628f950168cc7ac39f1b2f10
https://github.com/Perl/perl5/commit/62753b026cf494d2628f950168cc7ac39f1b2f10
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 0de4772caaa40100ebdcdb9a17731016a1264201
https://github.com/Perl/perl5/commit/0de4772caaa40100ebdcdb9a17731016a1264201
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d904a936bfb0694aa4538b751b9d1653aef323b7
https://github.com/Perl/perl5/commit/d904a936bfb0694aa4538b751b9d1653aef323b7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 21f9fbea922cfe532dbf405a01bdb9312f1a267a
https://github.com/Perl/perl5/commit/21f9fbea922cfe532dbf405a01bdb9312f1a267a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 0cf65d265cdc0714b8eec4128df1c496b1ba4089
https://github.com/Perl/perl5/commit/0cf65d265cdc0714b8eec4128df1c496b1ba4089
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: d7890b6da26d69f26d112e063c7725968c7f206d
https://github.com/Perl/perl5/commit/d7890b6da26d69f26d112e063c7725968c7f206d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: cccdf997faafe5ae8b1ded93161b7bd84613574e
https://github.com/Perl/perl5/commit/cccdf997faafe5ae8b1ded93161b7bd84613574e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 85245a732fd1d0a18289530cca7362329c19a736
https://github.com/Perl/perl5/commit/85245a732fd1d0a18289530cca7362329c19a736
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 01a743cae11c2aa9631f88c77e653715b2abd011
https://github.com/Perl/perl5/commit/01a743cae11c2aa9631f88c77e653715b2abd011
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: fcb9e404c085cad540cc68d41dafc6334665ae65
https://github.com/Perl/perl5/commit/fcb9e404c085cad540cc68d41dafc6334665ae65
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 317bce4c5ca7364236ce55ab01f0dd8c00038b65
https://github.com/Perl/perl5/commit/317bce4c5ca7364236ce55ab01f0dd8c00038b65
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: dbe47bbb7583a183d0f4e589dfb39362d34a271a
https://github.com/Perl/perl5/commit/dbe47bbb7583a183d0f4e589dfb39362d34a271a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: b19019e0c5c51e62dd5aef4671328df9ff566797
https://github.com/Perl/perl5/commit/b19019e0c5c51e62dd5aef4671328df9ff566797
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 15bac74d705dfb29334afe2a7240319b81a673dc
https://github.com/Perl/perl5/commit/15bac74d705dfb29334afe2a7240319b81a673dc
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: bc37fc9d1574a3052bada57226e8e15979f06470
https://github.com/Perl/perl5/commit/bc37fc9d1574a3052bada57226e8e15979f06470
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 1fbb56db959ac3525c4166aaa49661cb4c882b66
https://github.com/Perl/perl5/commit/1fbb56db959ac3525c4166aaa49661cb4c882b66
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: de1c2bb7532112e037ce444d0f159ada4697b820
https://github.com/Perl/perl5/commit/de1c2bb7532112e037ce444d0f159ada4697b820
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 33c1fa93571c8f663df50215624b0396f021c4d1
https://github.com/Perl/perl5/commit/33c1fa93571c8f663df50215624b0396f021c4d1
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: e9e85c7c7eedce6ba20bd0d98724f23737eef7e8
https://github.com/Perl/perl5/commit/e9e85c7c7eedce6ba20bd0d98724f23737eef7e8
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 16b3cb1f29d4e45007442414dc450b4b247700b7
https://github.com/Perl/perl5/commit/16b3cb1f29d4e45007442414dc450b4b247700b7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 91a88708b728246cf5a47f20d4aba15d0987b6e5
https://github.com/Perl/perl5/commit/91a88708b728246cf5a47f20d4aba15d0987b6e5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 0e7d69b2bb519eaa46a8d64dd8facd3d1d29472a
https://github.com/Perl/perl5/commit/0e7d69b2bb519eaa46a8d64dd8facd3d1d29472a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 0a4eb4ed8c674fb00b7ceb522355741d5619152c
https://github.com/Perl/perl5/commit/0a4eb4ed8c674fb00b7ceb522355741d5619152c
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: d8f82e230d1e1b858c6dd3af5c7a03eef25a79f6
https://github.com/Perl/perl5/commit/d8f82e230d1e1b858c6dd3af5c7a03eef25a79f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 114775b01f48485edff8aaee6f2855ec11ffc5d7
https://github.com/Perl/perl5/commit/114775b01f48485edff8aaee6f2855ec11ffc5d7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 3e70aba3a023174a3eea606790b8bf663b252ffe
https://github.com/Perl/perl5/commit/3e70aba3a023174a3eea606790b8bf663b252ffe
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 0d04082a0263e6dec55ab362944b7722d64c7c42
https://github.com/Perl/perl5/commit/0d04082a0263e6dec55ab362944b7722d64c7c42
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: ee9107d8c096c3ce71f35b8d2ce67abbb4db99c5
https://github.com/Perl/perl5/commit/ee9107d8c096c3ce71f35b8d2ce67abbb4db99c5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 245e9e429449c20edda73c7040418ac520c0a243
https://github.com/Perl/perl5/commit/245e9e429449c20edda73c7040418ac520c0a243
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: ed268d45e96d7ec9f568d5fc067d3790eebacab9
https://github.com/Perl/perl5/commit/ed268d45e96d7ec9f568d5fc067d3790eebacab9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 8c33ac0dca676adea27069d6318559ea5cf9acc2
https://github.com/Perl/perl5/commit/8c33ac0dca676adea27069d6318559ea5cf9acc2
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 1686d9b1317a5e2358714dcd7ac2fc45005d7a65
https://github.com/Perl/perl5/commit/1686d9b1317a5e2358714dcd7ac2fc45005d7a65
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: b416cb7d368c921627a6aefec9531a0ac6f14cf6
https://github.com/Perl/perl5/commit/b416cb7d368c921627a6aefec9531a0ac6f14cf6
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 40ccdacb72f561dbc2dc1a37b3e2b18135d909ea
https://github.com/Perl/perl5/commit/40ccdacb72f561dbc2dc1a37b3e2b18135d909ea
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: fa4b647b638c0adf4d6d326dca6b74cb43e85b7a
https://github.com/Perl/perl5/commit/fa4b647b638c0adf4d6d326dca6b74cb43e85b7a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 81307055167e1ae2af56c7ba79aa597c38ec7ef6
https://github.com/Perl/perl5/commit/81307055167e1ae2af56c7ba79aa597c38ec7ef6
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: a4d2214ca115b77a277e45cdf21f4b7b50e3f8f8
https://github.com/Perl/perl5/commit/a4d2214ca115b77a277e45cdf21f4b7b50e3f8f8
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 59128a5e86cb445fe84b183a5d702f18d46fd7ab
https://github.com/Perl/perl5/commit/59128a5e86cb445fe84b183a5d702f18d46fd7ab
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 109821373f900950a6beb0b7bfcb1358b5fa9a54
https://github.com/Perl/perl5/commit/109821373f900950a6beb0b7bfcb1358b5fa9a54
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 212d4f73d59bfaa264f3e46e37d0b6a3625c3fcd
https://github.com/Perl/perl5/commit/212d4f73d59bfaa264f3e46e37d0b6a3625c3fcd
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 4b4a3ddc676705b120abac1b2ff2021b97c03632
https://github.com/Perl/perl5/commit/4b4a3ddc676705b120abac1b2ff2021b97c03632
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 3e9a570712e05a466396006aebb264397f6fe606
https://github.com/Perl/perl5/commit/3e9a570712e05a466396006aebb264397f6fe606
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 3b4f3c30ad32bf354e78c875132ff41990291247
https://github.com/Perl/perl5/commit/3b4f3c30ad32bf354e78c875132ff41990291247
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: d444ed823b54daa3870ef16182537e30e97ba9d4
https://github.com/Perl/perl5/commit/d444ed823b54daa3870ef16182537e30e97ba9d4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 28b6a11ef57c6d52521e201332285ded731c6404
https://github.com/Perl/perl5/commit/28b6a11ef57c6d52521e201332285ded731c6404
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 2d0a06a6bbc433833796451f56622e0020f26b4b
https://github.com/Perl/perl5/commit/2d0a06a6bbc433833796451f56622e0020f26b4b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 060684af7d532a60887b79f905a160f6b6c87cb7
https://github.com/Perl/perl5/commit/060684af7d532a60887b79f905a160f6b6c87cb7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 2aaad5f7358829812164f92673dec11939eee0e7
https://github.com/Perl/perl5/commit/2aaad5f7358829812164f92673dec11939eee0e7
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 52a894a56a93827b7eb61e6922af279067a26ba9
https://github.com/Perl/perl5/commit/52a894a56a93827b7eb61e6922af279067a26ba9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 64c8d8b06a985ff698bd75d17260800caf1fb508
https://github.com/Perl/perl5/commit/64c8d8b06a985ff698bd75d17260800caf1fb508
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 6891d186975e53904f10d0a6a50d88bd3459b63b
https://github.com/Perl/perl5/commit/6891d186975e53904f10d0a6a50d88bd3459b63b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: cac1ca7ed2c68c42d154eafed6207f4128a9183b
https://github.com/Perl/perl5/commit/cac1ca7ed2c68c42d154eafed6207f4128a9183b
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 68d671ce8c1486a66d028b9143ebb1d60cf7ef0e
https://github.com/Perl/perl5/commit/68d671ce8c1486a66d028b9143ebb1d60cf7ef0e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: d5afa102981adb03bcb0fae6d43d2b658cbe310a
https://github.com/Perl/perl5/commit/d5afa102981adb03bcb0fae6d43d2b658cbe310a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 7c83e6474299aabe2e45b512e412e9cba1e3714a
https://github.com/Perl/perl5/commit/7c83e6474299aabe2e45b512e412e9cba1e3714a
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 59b4ac8e58df1f451a65ece62fc064c72c089c25
https://github.com/Perl/perl5/commit/59b4ac8e58df1f451a65ece62fc064c72c089c25
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: a68ca12a48ef23ad40fe285c2cd1b49d71fb0f80
https://github.com/Perl/perl5/commit/a68ca12a48ef23ad40fe285c2cd1b49d71fb0f80
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 04a25d80a19dd9665e792c87b0cdd0b714227162
https://github.com/Perl/perl5/commit/04a25d80a19dd9665e792c87b0cdd0b714227162
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 5b1902d6acf1294a780141e55dcc9e9e9bc38b1f
https://github.com/Perl/perl5/commit/5b1902d6acf1294a780141e55dcc9e9e9bc38b1f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 745b83b1fd0c3d694b554b08cc28cbe68476139e
https://github.com/Perl/perl5/commit/745b83b1fd0c3d694b554b08cc28cbe68476139e
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 58276024dffbc7da0ac5922da1cd76ec17dd2753
https://github.com/Perl/perl5/commit/58276024dffbc7da0ac5922da1cd76ec17dd2753
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 96cc2f29584eaf53c7685569aca75f5a378eb35f
https://github.com/Perl/perl5/commit/96cc2f29584eaf53c7685569aca75f5a378eb35f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 93b6ed07442edc7678a96df5da4fd9cacc6f98f5
https://github.com/Perl/perl5/commit/93b6ed07442edc7678a96df5da4fd9cacc6f98f5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 6dafa736f9df64b897ae81af766a21076653b6f2
https://github.com/Perl/perl5/commit/6dafa736f9df64b897ae81af766a21076653b6f2
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 80cb8e7d4bce3a59d839ebc50dbe019f495a91f5
https://github.com/Perl/perl5/commit/80cb8e7d4bce3a59d839ebc50dbe019f495a91f5
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 36ad7c8f7a52f744130c34f898671aaa9d04e868
https://github.com/Perl/perl5/commit/36ad7c8f7a52f744130c34f898671aaa9d04e868
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: fa3aa21c316d82a47f2919f866c6942ab7d240aa
https://github.com/Perl/perl5/commit/fa3aa21c316d82a47f2919f866c6942ab7d240aa
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 2f69bc66c97215103aa1c4720e830800c22c5642
https://github.com/Perl/perl5/commit/2f69bc66c97215103aa1c4720e830800c22c5642
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 1f2d6d080259c06a3241d758870ad5461687b830
https://github.com/Perl/perl5/commit/1f2d6d080259c06a3241d758870ad5461687b830
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 222dd37885b9b83f46d62d09001f383142ed65bd
https://github.com/Perl/perl5/commit/222dd37885b9b83f46d62d09001f383142ed65bd
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Add missing SKIP: label
Commit: 10aaea660114a5e6353f671e0b703394ec701a4d
https://github.com/Perl/perl5/commit/10aaea660114a5e6353f671e0b703394ec701a4d
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Fix tests
This was misleadingly outputting an undef value, instead of just saying
it's undef
Commit: 466867c46bed27b46d17463df75273817eda1ca4
https://github.com/Perl/perl5/commit/466867c46bed27b46d17463df75273817eda1ca4
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M embed.fnc
M ext/XS-APItest/t/locale.t
M lib/locale.t
M lib/locale_threads.t
M locale.c
M proto.h
Log Message:
-----------
f
Commit: 7c2b4220f438660d8caa383de2f536261353b801
https://github.com/Perl/perl5/commit/7c2b4220f438660d8caa383de2f536261353b801
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 9a485a89a46598dc4f0e525a38dee98dbe6286e9
https://github.com/Perl/perl5/commit/9a485a89a46598dc4f0e525a38dee98dbe6286e9
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale.t
M lib/locale_threads.t
M locale.c
Log Message:
-----------
yet more
Commit: 7072e00ea70ba0afa60e21b8e0d938eb5b2dfb4f
https://github.com/Perl/perl5/commit/7072e00ea70ba0afa60e21b8e0d938eb5b2dfb4f
Author: Karl Williamson <[email protected]>
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M lib/locale.t
M lib/locale_threads.t
Log Message:
-----------
more2
Compare: https://github.com/Perl/perl5/compare/4d21b273ba8a...7072e00ea70b
