Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 954d50fe14647a71681c9801dcca366dd8a3af87
https://github.com/Perl/perl5/commit/954d50fe14647a71681c9801dcca366dd8a3af87
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 32981598119ee53bf125da8e8b39ec498234239b
https://github.com/Perl/perl5/commit/32981598119ee53bf125da8e8b39ec498234239b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: d436269da36b394ee0bd85b4d8c4a422bb0f7ec9
https://github.com/Perl/perl5/commit/d436269da36b394ee0bd85b4d8c4a422bb0f7ec9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: f51bf8e601547b22124e09a6c552e3a9b5c3a10f
https://github.com/Perl/perl5/commit/f51bf8e601547b22124e09a6c552e3a9b5c3a10f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 15d86c85dce6767862f3aba6c45e2702ea6a5730
https://github.com/Perl/perl5/commit/15d86c85dce6767862f3aba6c45e2702ea6a5730
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: f1c64b21b41f7e05ab4250595983cb86e93ffbc9
https://github.com/Perl/perl5/commit/f1c64b21b41f7e05ab4250595983cb86e93ffbc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: ef9a4b32c0a9a750daf84f5fe0bffc676bd72ae1
https://github.com/Perl/perl5/commit/ef9a4b32c0a9a750daf84f5fe0bffc676bd72ae1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: b4e51edd23fe3cdb97b6f10de75d30cc330f6385
https://github.com/Perl/perl5/commit/b4e51edd23fe3cdb97b6f10de75d30cc330f6385
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 5339f28336b55ca024bb04b1dd941874efc20e3e
https://github.com/Perl/perl5/commit/5339f28336b55ca024bb04b1dd941874efc20e3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 8da04544c7156cc32405321150e1c72816087d20
https://github.com/Perl/perl5/commit/8da04544c7156cc32405321150e1c72816087d20
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 9858015a01fe73d1d9f6ecf5e8d9e67d962597b0
https://github.com/Perl/perl5/commit/9858015a01fe73d1d9f6ecf5e8d9e67d962597b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: a0a1f52b3e28b5f12a14d43ce8f75b86494ebadc
https://github.com/Perl/perl5/commit/a0a1f52b3e28b5f12a14d43ce8f75b86494ebadc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 00e9b84455009870114a97ac032c4441e5d52516
https://github.com/Perl/perl5/commit/00e9b84455009870114a97ac032c4441e5d52516
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: acf5bb090fbb6ba4880638f3b7536828a1ce434d
https://github.com/Perl/perl5/commit/acf5bb090fbb6ba4880638f3b7536828a1ce434d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 731806f291cb0b1163e3ebe85df42e0a7acbeeee
https://github.com/Perl/perl5/commit/731806f291cb0b1163e3ebe85df42e0a7acbeeee
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 074141c88daecec24b957b565acad539032ddce9
https://github.com/Perl/perl5/commit/074141c88daecec24b957b565acad539032ddce9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 1c4e5b66b1bcf5b711c3a8c0701bc9a7de5da2e5
https://github.com/Perl/perl5/commit/1c4e5b66b1bcf5b711c3a8c0701bc9a7de5da2e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 6e4d53ec419ef6e9ff94985bafba206e3c93f863
https://github.com/Perl/perl5/commit/6e4d53ec419ef6e9ff94985bafba206e3c93f863
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: fdb24599bab9233a125a7a35a8f34363783c39bd
https://github.com/Perl/perl5/commit/fdb24599bab9233a125a7a35a8f34363783c39bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 02db6045cd507726df44a28990aefdb0cd95d508
https://github.com/Perl/perl5/commit/02db6045cd507726df44a28990aefdb0cd95d508
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 23fa0db24402d5359c6b38269dfc41afef8b223f
https://github.com/Perl/perl5/commit/23fa0db24402d5359c6b38269dfc41afef8b223f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 11dd90b531117fab1d86e1848e2c0b379348f077
https://github.com/Perl/perl5/commit/11dd90b531117fab1d86e1848e2c0b379348f077
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 6daa09fe9c3bcf13ceb02cf124039a659cb16edc
https://github.com/Perl/perl5/commit/6daa09fe9c3bcf13ceb02cf124039a659cb16edc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 17fd17630d228f67d1f39db73efcd9dabe0649ed
https://github.com/Perl/perl5/commit/17fd17630d228f67d1f39db73efcd9dabe0649ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 40ee53603ba6a925eaee119718b0c2230436fa66
https://github.com/Perl/perl5/commit/40ee53603ba6a925eaee119718b0c2230436fa66
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: fbc53bb22f1bb0852c304562bd3cf29f6b3905cf
https://github.com/Perl/perl5/commit/fbc53bb22f1bb0852c304562bd3cf29f6b3905cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 72b7f6ba6e86851fa4a063b774839361174eb1c7
https://github.com/Perl/perl5/commit/72b7f6ba6e86851fa4a063b774839361174eb1c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 597c9ee0ab954010c5f397282149a8ef7ba16580
https://github.com/Perl/perl5/commit/597c9ee0ab954010c5f397282149a8ef7ba16580
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: bdbe809bcdcf115e459bdd004800486187078b73
https://github.com/Perl/perl5/commit/bdbe809bcdcf115e459bdd004800486187078b73
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 9e8e83ac158f71f8c001ce7fd7430f5e69152fe2
https://github.com/Perl/perl5/commit/9e8e83ac158f71f8c001ce7fd7430f5e69152fe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: a38f818a260fb206bc5d1977814ea153c550020d
https://github.com/Perl/perl5/commit/a38f818a260fb206bc5d1977814ea153c550020d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 401d2ca90a16827809066c5c6728beb89f8ed625
https://github.com/Perl/perl5/commit/401d2ca90a16827809066c5c6728beb89f8ed625
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 5d6b6c4bd049ce6acd25837bbbf2e45c3db2fcf7
https://github.com/Perl/perl5/commit/5d6b6c4bd049ce6acd25837bbbf2e45c3db2fcf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: de747f794459d7623d8e3cb58dd1f3f54ae3c614
https://github.com/Perl/perl5/commit/de747f794459d7623d8e3cb58dd1f3f54ae3c614
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: fb2eb0af80c3d3761baaa8f458816ba7dbbe9b0d
https://github.com/Perl/perl5/commit/fb2eb0af80c3d3761baaa8f458816ba7dbbe9b0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: aee256fd5c1e279958f5125ca485a92b79740095
https://github.com/Perl/perl5/commit/aee256fd5c1e279958f5125ca485a92b79740095
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: d35b223782cefc17d9adb8e1b2a1b691ec096cdf
https://github.com/Perl/perl5/commit/d35b223782cefc17d9adb8e1b2a1b691ec096cdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: fc47e97efbdbc0f5316664d6750aba8c038fe83c
https://github.com/Perl/perl5/commit/fc47e97efbdbc0f5316664d6750aba8c038fe83c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 57bd1ef5f286b8f1a35f2834c174da3d7b7b04b2
https://github.com/Perl/perl5/commit/57bd1ef5f286b8f1a35f2834c174da3d7b7b04b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 5018a374e207df52d843191914d23fdb7b4829d0
https://github.com/Perl/perl5/commit/5018a374e207df52d843191914d23fdb7b4829d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 1890c4d402966d0a33da185f04adbd84512573bc
https://github.com/Perl/perl5/commit/1890c4d402966d0a33da185f04adbd84512573bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 8b297202a1d88838dbea4787b2a4181c43797079
https://github.com/Perl/perl5/commit/8b297202a1d88838dbea4787b2a4181c43797079
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 4a6a585f12a8fcfe40c315859d7f69a5157c5218
https://github.com/Perl/perl5/commit/4a6a585f12a8fcfe40c315859d7f69a5157c5218
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: e817e8ca3f92e814119fe44078b4a7e113771760
https://github.com/Perl/perl5/commit/e817e8ca3f92e814119fe44078b4a7e113771760
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 66a97271c686126ba15582f5f36d10bacd5f6880
https://github.com/Perl/perl5/commit/66a97271c686126ba15582f5f36d10bacd5f6880
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: b551221efa8b7ced9c1a6333fed6ea26a33318b5
https://github.com/Perl/perl5/commit/b551221efa8b7ced9c1a6333fed6ea26a33318b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 6353dc3b18c22606964696119b86b090b034f583
https://github.com/Perl/perl5/commit/6353dc3b18c22606964696119b86b090b034f583
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 2f449591db184ae3eb056587402cf14c0a29deb6
https://github.com/Perl/perl5/commit/2f449591db184ae3eb056587402cf14c0a29deb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 524d4b0f76244379a2bf10c9211e2afd65bb546b
https://github.com/Perl/perl5/commit/524d4b0f76244379a2bf10c9211e2afd65bb546b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: e107759942f98a08fbb9ff2395350ada3f3e6421
https://github.com/Perl/perl5/commit/e107759942f98a08fbb9ff2395350ada3f3e6421
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 62b8c198757b7f4490865f419e91ab7d7109344d
https://github.com/Perl/perl5/commit/62b8c198757b7f4490865f419e91ab7d7109344d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 17c6302959d8049064e8ef1df6fb4bc043b46524
https://github.com/Perl/perl5/commit/17c6302959d8049064e8ef1df6fb4bc043b46524
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 21e38057d04eeda3e659f37ebf359bd90589e675
https://github.com/Perl/perl5/commit/21e38057d04eeda3e659f37ebf359bd90589e675
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 274e1d0562f193f554ba74b4704350400787bf7a
https://github.com/Perl/perl5/commit/274e1d0562f193f554ba74b4704350400787bf7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 883fdf093d1acae720752b72704694d29dbca697
https://github.com/Perl/perl5/commit/883fdf093d1acae720752b72704694d29dbca697
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: bc6922a524c7cecf0254ad25f9d4683c4965521d
https://github.com/Perl/perl5/commit/bc6922a524c7cecf0254ad25f9d4683c4965521d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 39ef45a5b436f606d3fd3266c54e2c70c5cf37b7
https://github.com/Perl/perl5/commit/39ef45a5b436f606d3fd3266c54e2c70c5cf37b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 1113196fa9a2cf11c711b0ede8d12586fe1226c6
https://github.com/Perl/perl5/commit/1113196fa9a2cf11c711b0ede8d12586fe1226c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: e5fb0abc04ea099126466aea05cd941861c543b9
https://github.com/Perl/perl5/commit/e5fb0abc04ea099126466aea05cd941861c543b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: f8c50989d5f9d925987ea2740d5dca15c7d804ab
https://github.com/Perl/perl5/commit/f8c50989d5f9d925987ea2740d5dca15c7d804ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: e2d8b5f9601f272155efeb3b3a6b05f3f5eae845
https://github.com/Perl/perl5/commit/e2d8b5f9601f272155efeb3b3a6b05f3f5eae845
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 4f5df97dd3c949fc7d9e27867be208b9fa62d0b7
https://github.com/Perl/perl5/commit/4f5df97dd3c949fc7d9e27867be208b9fa62d0b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: b046a3514fdd0b8266017b403d87931e804f8481
https://github.com/Perl/perl5/commit/b046a3514fdd0b8266017b403d87931e804f8481
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: f247e243d21604ca5d81797ed7a0550b7187342a
https://github.com/Perl/perl5/commit/f247e243d21604ca5d81797ed7a0550b7187342a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 220fe0596a77d03c612b832048f0deb38912548c
https://github.com/Perl/perl5/commit/220fe0596a77d03c612b832048f0deb38912548c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: fe6de33ce9ded96010f717df80ebb006fecd20b4
https://github.com/Perl/perl5/commit/fe6de33ce9ded96010f717df80ebb006fecd20b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 1f5e8b551044e63f63e46239a9d927ab5e898fb1
https://github.com/Perl/perl5/commit/1f5e8b551044e63f63e46239a9d927ab5e898fb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 331f93d7197cc48de7e6b5e0c477b56a1656ca04
https://github.com/Perl/perl5/commit/331f93d7197cc48de7e6b5e0c477b56a1656ca04
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: b808f52688db6f7606c8c2229e92f27a8cae9222
https://github.com/Perl/perl5/commit/b808f52688db6f7606c8c2229e92f27a8cae9222
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 4d6961a6e15a7f03f761b1f0834e8dac12d2bf89
https://github.com/Perl/perl5/commit/4d6961a6e15a7f03f761b1f0834e8dac12d2bf89
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: de80d0fe9b91d89213c6e2f5808282fd55a0519e
https://github.com/Perl/perl5/commit/de80d0fe9b91d89213c6e2f5808282fd55a0519e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: f89e0bf4462456eb1e99ee4ee6ade5448586b0aa
https://github.com/Perl/perl5/commit/f89e0bf4462456eb1e99ee4ee6ade5448586b0aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: ae757a1d6af35d2ccc17c12b4b0b30dc419abf97
https://github.com/Perl/perl5/commit/ae757a1d6af35d2ccc17c12b4b0b30dc419abf97
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: c65239ccd6d577cd421f40eb002327868f66a945
https://github.com/Perl/perl5/commit/c65239ccd6d577cd421f40eb002327868f66a945
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: a63e2394fd9298842420f7d438ba03349a7b3c34
https://github.com/Perl/perl5/commit/a63e2394fd9298842420f7d438ba03349a7b3c34
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 07aa0d5576ce72b734f808c42e0d475eb3f0cc08
https://github.com/Perl/perl5/commit/07aa0d5576ce72b734f808c42e0d475eb3f0cc08
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 33162d62a83e5dafc65009648f2f16419a420b82
https://github.com/Perl/perl5/commit/33162d62a83e5dafc65009648f2f16419a420b82
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 753164c87394558ebd5798e04b5a1eda06e7312e
https://github.com/Perl/perl5/commit/753164c87394558ebd5798e04b5a1eda06e7312e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: e8d37563f29649721c4d8459ff93ef33a919ca4c
https://github.com/Perl/perl5/commit/e8d37563f29649721c4d8459ff93ef33a919ca4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: faa6e804e553f2fd6999dd64572a759d0b67277b
https://github.com/Perl/perl5/commit/faa6e804e553f2fd6999dd64572a759d0b67277b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: d89b4df8a4d1765eb0323c77c398061998127713
https://github.com/Perl/perl5/commit/d89b4df8a4d1765eb0323c77c398061998127713
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 0f894620d7f8cb8567b054105a2fc51a6f71d2a2
https://github.com/Perl/perl5/commit/0f894620d7f8cb8567b054105a2fc51a6f71d2a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 1a87dec2352ff75e0340235cc409c528c29c77d8
https://github.com/Perl/perl5/commit/1a87dec2352ff75e0340235cc409c528c29c77d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 46ceeae81121b2973955946fa23c030147d46d0d
https://github.com/Perl/perl5/commit/46ceeae81121b2973955946fa23c030147d46d0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: a5a9173ce293add35fcecf4a622650da7546e4a4
https://github.com/Perl/perl5/commit/a5a9173ce293add35fcecf4a622650da7546e4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 3b547cc950ee96243d5dc70f10cbe016e4294cc2
https://github.com/Perl/perl5/commit/3b547cc950ee96243d5dc70f10cbe016e4294cc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: f3ab0ec7082d5aad950f98edfc25c0540af9418a
https://github.com/Perl/perl5/commit/f3ab0ec7082d5aad950f98edfc25c0540af9418a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: c877a245cc70360720cea29d484c4a42fb48b582
https://github.com/Perl/perl5/commit/c877a245cc70360720cea29d484c4a42fb48b582
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 08db53786a5c238aa7baeec8fe208c297fb3b513
https://github.com/Perl/perl5/commit/08db53786a5c238aa7baeec8fe208c297fb3b513
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: af317238de9a388c278295de2eaab32a9ef502c6
https://github.com/Perl/perl5/commit/af317238de9a388c278295de2eaab32a9ef502c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 3763efa241a357123651c22d0c99bfb645e25a0c
https://github.com/Perl/perl5/commit/3763efa241a357123651c22d0c99bfb645e25a0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 6645028d0baf97256f0ea0cf3f43d7bc3a4ae144
https://github.com/Perl/perl5/commit/6645028d0baf97256f0ea0cf3f43d7bc3a4ae144
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: ef9aae047227b31a6e22542440cfa2b56f71d313
https://github.com/Perl/perl5/commit/ef9aae047227b31a6e22542440cfa2b56f71d313
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 406cf32ac15c2585a718ea491836acb5868fd496
https://github.com/Perl/perl5/commit/406cf32ac15c2585a718ea491836acb5868fd496
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 0de4b3e907f2187490498ed353373e463edf0647
https://github.com/Perl/perl5/commit/0de4b3e907f2187490498ed353373e463edf0647
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: e5c26f78a34d650b2cff014a3aa64ba720aebcf6
https://github.com/Perl/perl5/commit/e5c26f78a34d650b2cff014a3aa64ba720aebcf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 906d6682a8dd26aea5930d6004f05245ced18220
https://github.com/Perl/perl5/commit/906d6682a8dd26aea5930d6004f05245ced18220
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: daa4a3908b8b4b422af6b1d45b06b1a44d762f0c
https://github.com/Perl/perl5/commit/daa4a3908b8b4b422af6b1d45b06b1a44d762f0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 5b597f24e54c37f1aec1cf359e4311a70b511630
https://github.com/Perl/perl5/commit/5b597f24e54c37f1aec1cf359e4311a70b511630
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 86a45bb17878b854aa5447c89e8f3adbc36b59b7
https://github.com/Perl/perl5/commit/86a45bb17878b854aa5447c89e8f3adbc36b59b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: f92c1c91bb7e60072631e52f9d72398f00b5025e
https://github.com/Perl/perl5/commit/f92c1c91bb7e60072631e52f9d72398f00b5025e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 435d1eb8f3aeea27a4cc33da51dcf0170beef474
https://github.com/Perl/perl5/commit/435d1eb8f3aeea27a4cc33da51dcf0170beef474
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 608d3c86c829f855cd657e10417f0c89876b8e70
https://github.com/Perl/perl5/commit/608d3c86c829f855cd657e10417f0c89876b8e70
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 5b993318c64a1ceaf191f5b3e9096f87358485bc
https://github.com/Perl/perl5/commit/5b993318c64a1ceaf191f5b3e9096f87358485bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 02c8a7f9fb5e72caad70394bda0cfd93e81e509e
https://github.com/Perl/perl5/commit/02c8a7f9fb5e72caad70394bda0cfd93e81e509e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: d48b746cd98145b58d45f450377185f6f5490169
https://github.com/Perl/perl5/commit/d48b746cd98145b58d45f450377185f6f5490169
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 8429a2bd687c539ce8b6b30fdee6b0cd68d07da2
https://github.com/Perl/perl5/commit/8429a2bd687c539ce8b6b30fdee6b0cd68d07da2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 499aa94a34e2031de77fa8258b18586b65adf5d4
https://github.com/Perl/perl5/commit/499aa94a34e2031de77fa8258b18586b65adf5d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: d8162aad75b54196ac4cc805cc3fa8776245320f
https://github.com/Perl/perl5/commit/d8162aad75b54196ac4cc805cc3fa8776245320f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: a65a5052bca1c68d82f9f4addf1679b1115f00b1
https://github.com/Perl/perl5/commit/a65a5052bca1c68d82f9f4addf1679b1115f00b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 507517ed609112077354adbb5022991951d2591d
https://github.com/Perl/perl5/commit/507517ed609112077354adbb5022991951d2591d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: f475e6c00c9e31f1c4bcdfc86f4347e4bc2bff38
https://github.com/Perl/perl5/commit/f475e6c00c9e31f1c4bcdfc86f4347e4bc2bff38
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 66187b38f8f61d2661c6ab2e6fdc713b2912be81
https://github.com/Perl/perl5/commit/66187b38f8f61d2661c6ab2e6fdc713b2912be81
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 128318bf245053ecb646cf8516e04466c2df0bca
https://github.com/Perl/perl5/commit/128318bf245053ecb646cf8516e04466c2df0bca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: a7598491ae11cd8dfee65c60eea6353deca94739
https://github.com/Perl/perl5/commit/a7598491ae11cd8dfee65c60eea6353deca94739
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 6ca4b123ab703caadfbb2b60dd6425fee26016f1
https://github.com/Perl/perl5/commit/6ca4b123ab703caadfbb2b60dd6425fee26016f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: e0c31107d1fa8390d925b8dcd808cfafb7871393
https://github.com/Perl/perl5/commit/e0c31107d1fa8390d925b8dcd808cfafb7871393
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: e48970c358efa89c5165b04418396edc568b4cd4
https://github.com/Perl/perl5/commit/e48970c358efa89c5165b04418396edc568b4cd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: b25e093f749ca3e6821e5295978543c1f3455375
https://github.com/Perl/perl5/commit/b25e093f749ca3e6821e5295978543c1f3455375
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 4fb393e6e9293704aed8cd20d38ae3d90e6a57c3
https://github.com/Perl/perl5/commit/4fb393e6e9293704aed8cd20d38ae3d90e6a57c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: bf72188a187cac6bbf7c0605f729dd3ad4ea4890
https://github.com/Perl/perl5/commit/bf72188a187cac6bbf7c0605f729dd3ad4ea4890
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 6df7a5f0988a461c654d2b066eda45bd9ded260d
https://github.com/Perl/perl5/commit/6df7a5f0988a461c654d2b066eda45bd9ded260d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: e4392ebc6b3cbd31526d0e24ecc4e97dc574575f
https://github.com/Perl/perl5/commit/e4392ebc6b3cbd31526d0e24ecc4e97dc574575f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 1e381d0098f60f78b00bab0de8336ca20a6e7ae6
https://github.com/Perl/perl5/commit/1e381d0098f60f78b00bab0de8336ca20a6e7ae6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 715402cc0d23a46ee3b94abc0f35de3c6dadda13
https://github.com/Perl/perl5/commit/715402cc0d23a46ee3b94abc0f35de3c6dadda13
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 2db72f440093a0cf1616d7d30620c96a4ccdacc8
https://github.com/Perl/perl5/commit/2db72f440093a0cf1616d7d30620c96a4ccdacc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: ba4e858342cf076897093f17368f4a6fdf80e84a
https://github.com/Perl/perl5/commit/ba4e858342cf076897093f17368f4a6fdf80e84a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 70ce433e0474bb22216d3d046bff37feb88a3ba8
https://github.com/Perl/perl5/commit/70ce433e0474bb22216d3d046bff37feb88a3ba8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: c19c99391bad9eb56998f6039c84ffe83f423bc6
https://github.com/Perl/perl5/commit/c19c99391bad9eb56998f6039c84ffe83f423bc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 14c3d1c8bdc28ce013df7b6b46bf352eba1f043a
https://github.com/Perl/perl5/commit/14c3d1c8bdc28ce013df7b6b46bf352eba1f043a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 1ae9817240e25fda7ef63de64f94dcab1f9af66e
https://github.com/Perl/perl5/commit/1ae9817240e25fda7ef63de64f94dcab1f9af66e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 006d934202ad8925774f0fe86799a9ff2b2b4d41
https://github.com/Perl/perl5/commit/006d934202ad8925774f0fe86799a9ff2b2b4d41
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: d930892a23f2067984a37167f87137b03b1488b5
https://github.com/Perl/perl5/commit/d930892a23f2067984a37167f87137b03b1488b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 2f7b18c4286d9984b0d422d72a1aa346ea8df288
https://github.com/Perl/perl5/commit/2f7b18c4286d9984b0d422d72a1aa346ea8df288
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 6eaa4bff5e4d121ffe9e2b197c14d6eab6aa00a0
https://github.com/Perl/perl5/commit/6eaa4bff5e4d121ffe9e2b197c14d6eab6aa00a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 6ceffdb4b85699309c51892b33f75b7c63833cb2
https://github.com/Perl/perl5/commit/6ceffdb4b85699309c51892b33f75b7c63833cb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 7e58cb91b0f84da5f410d1d66ec650a3f77823c0
https://github.com/Perl/perl5/commit/7e58cb91b0f84da5f410d1d66ec650a3f77823c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 7fd01fe77bdd3719f6ba970f62f6e5d633fd6bf2
https://github.com/Perl/perl5/commit/7fd01fe77bdd3719f6ba970f62f6e5d633fd6bf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 47e6382146e05ebabb47bdf056fb83aacd20a6b2
https://github.com/Perl/perl5/commit/47e6382146e05ebabb47bdf056fb83aacd20a6b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 4b2d25ead8947342cfabf015841a185fb7545bcd
https://github.com/Perl/perl5/commit/4b2d25ead8947342cfabf015841a185fb7545bcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 36a52a1f17c7b1563733c7629f7144b9ae040a1a
https://github.com/Perl/perl5/commit/36a52a1f17c7b1563733c7629f7144b9ae040a1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a14e02ba0efa915c16e7ff64c278c834c4ec3353
https://github.com/Perl/perl5/commit/a14e02ba0efa915c16e7ff64c278c834c4ec3353
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 4972aa58e6cd2668f393f5f71638e907de46c9ff
https://github.com/Perl/perl5/commit/4972aa58e6cd2668f393f5f71638e907de46c9ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: b7f1fa655cf050c0132a4b66bf90f84d02cd79f9
https://github.com/Perl/perl5/commit/b7f1fa655cf050c0132a4b66bf90f84d02cd79f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: c61c6189ae269291c0196620eba4f7287e8a2a0b
https://github.com/Perl/perl5/commit/c61c6189ae269291c0196620eba4f7287e8a2a0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 59b1f77465f5d69989007d3b227d55ac37442756
https://github.com/Perl/perl5/commit/59b1f77465f5d69989007d3b227d55ac37442756
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 8bb97fc7a8ad40af2b54124a0d01e1aaf9034c1d
https://github.com/Perl/perl5/commit/8bb97fc7a8ad40af2b54124a0d01e1aaf9034c1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 69bb1156c4673df4ef5e813bf1d2fd910da76958
https://github.com/Perl/perl5/commit/69bb1156c4673df4ef5e813bf1d2fd910da76958
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 204fbe3ccc13d5438c175dafce5478448787b719
https://github.com/Perl/perl5/commit/204fbe3ccc13d5438c175dafce5478448787b719
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: c3ef133556886688112e8431613c71fb61c35a90
https://github.com/Perl/perl5/commit/c3ef133556886688112e8431613c71fb61c35a90
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 42822e4bd130e1da41d6ad6997ffea265d60f59c
https://github.com/Perl/perl5/commit/42822e4bd130e1da41d6ad6997ffea265d60f59c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 25169b21205514afcbce858115ea429317b8f7a0
https://github.com/Perl/perl5/commit/25169b21205514afcbce858115ea429317b8f7a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 248d015779517c9dacb7494735b002834a6f5832
https://github.com/Perl/perl5/commit/248d015779517c9dacb7494735b002834a6f5832
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 2878d87505d152284b88830113df5d917d2bdf9e
https://github.com/Perl/perl5/commit/2878d87505d152284b88830113df5d917d2bdf9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 50bb95e5e230a2d994c526325aeada70485db03d
https://github.com/Perl/perl5/commit/50bb95e5e230a2d994c526325aeada70485db03d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 4ce21596abaa35fc203174a823dc9162bc841d5e
https://github.com/Perl/perl5/commit/4ce21596abaa35fc203174a823dc9162bc841d5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 4464f36e2516c35ae720ec4ada2a48218d5acdd4
https://github.com/Perl/perl5/commit/4464f36e2516c35ae720ec4ada2a48218d5acdd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: bad95f43579ccf287665ce8cee5d852bd75f2784
https://github.com/Perl/perl5/commit/bad95f43579ccf287665ce8cee5d852bd75f2784
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 528f9098c2f56fd63c0f5967e92c8b53f131bff0
https://github.com/Perl/perl5/commit/528f9098c2f56fd63c0f5967e92c8b53f131bff0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 07f727b0fdb3844feabfc179c5e4ce4f0bd4846e
https://github.com/Perl/perl5/commit/07f727b0fdb3844feabfc179c5e4ce4f0bd4846e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: a0b4c2346b4357bfc5b85747208631712c3742cf
https://github.com/Perl/perl5/commit/a0b4c2346b4357bfc5b85747208631712c3742cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 7b21c4c960fbbc8d08a93671e46be7da0099206c
https://github.com/Perl/perl5/commit/7b21c4c960fbbc8d08a93671e46be7da0099206c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: fd2b5dc6e51f07a6cb827fe239a0d6f125bd9048
https://github.com/Perl/perl5/commit/fd2b5dc6e51f07a6cb827fe239a0d6f125bd9048
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 911098660a04824d0c80d71a7a865b42baf95806
https://github.com/Perl/perl5/commit/911098660a04824d0c80d71a7a865b42baf95806
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 6714727ab6acaba40871d58f89d91185a1f7deb7
https://github.com/Perl/perl5/commit/6714727ab6acaba40871d58f89d91185a1f7deb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: e02c3ccb5dbc472042d2d22efaba0165e579754a
https://github.com/Perl/perl5/commit/e02c3ccb5dbc472042d2d22efaba0165e579754a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 8b55925083ae6ae95f152fde023e5b0e8925eb1b
https://github.com/Perl/perl5/commit/8b55925083ae6ae95f152fde023e5b0e8925eb1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 7cec4707e586497abbc1f714aa00d251b453fe77
https://github.com/Perl/perl5/commit/7cec4707e586497abbc1f714aa00d251b453fe77
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 1ac7cba64227aeb627b9abeeb103f66a39cf2a5d
https://github.com/Perl/perl5/commit/1ac7cba64227aeb627b9abeeb103f66a39cf2a5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 26d668d4d1fa0fa6c2cbdf3f7f62e09b5236c9a0
https://github.com/Perl/perl5/commit/26d668d4d1fa0fa6c2cbdf3f7f62e09b5236c9a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: bc7effd13ef81f5aed3c440c53d905558045c338
https://github.com/Perl/perl5/commit/bc7effd13ef81f5aed3c440c53d905558045c338
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: dc8cc8ea87a440996b8d1a1532c1745417043a70
https://github.com/Perl/perl5/commit/dc8cc8ea87a440996b8d1a1532c1745417043a70
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 5342d6540666bfbbb4361b3aa94136f547564ccc
https://github.com/Perl/perl5/commit/5342d6540666bfbbb4361b3aa94136f547564ccc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: cea051016bd94c4101451c9033b6f9965309c183
https://github.com/Perl/perl5/commit/cea051016bd94c4101451c9033b6f9965309c183
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 74b68c27310bd487c499a5bfd65ce8c9e38a1170
https://github.com/Perl/perl5/commit/74b68c27310bd487c499a5bfd65ce8c9e38a1170
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5a991bb2535067245e5842bf6afff7aa36a89ed2
https://github.com/Perl/perl5/commit/5a991bb2535067245e5842bf6afff7aa36a89ed2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3f3a04ae560d291094ef471b98b0b88e7aac301d
https://github.com/Perl/perl5/commit/3f3a04ae560d291094ef471b98b0b88e7aac301d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 217b54bdad0431c594a78919196541dc8aac6ea0
https://github.com/Perl/perl5/commit/217b54bdad0431c594a78919196541dc8aac6ea0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 83c5c2dc694167a2819968462b9c7c1c3f4ed425
https://github.com/Perl/perl5/commit/83c5c2dc694167a2819968462b9c7c1c3f4ed425
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: a918b3f9e7f80f91322bad0803af19908253006d
https://github.com/Perl/perl5/commit/a918b3f9e7f80f91322bad0803af19908253006d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: ba8f69884193ae61551ea9abae77af7a91013ac5
https://github.com/Perl/perl5/commit/ba8f69884193ae61551ea9abae77af7a91013ac5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: d9f8495896f68d3f360908651d8047029d3140cb
https://github.com/Perl/perl5/commit/d9f8495896f68d3f360908651d8047029d3140cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 973ecfc14f070be4aa9a3d2bbf018fbd9e213ff8
https://github.com/Perl/perl5/commit/973ecfc14f070be4aa9a3d2bbf018fbd9e213ff8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: d1bc76cfb06d8336550c4bf09dd4212227c07055
https://github.com/Perl/perl5/commit/d1bc76cfb06d8336550c4bf09dd4212227c07055
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: bd7f187f57925aafeffdbc70c67dad60a2a264de
https://github.com/Perl/perl5/commit/bd7f187f57925aafeffdbc70c67dad60a2a264de
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 05f6b5c4908cd7f0c9cf96a9915e54ac1ed0f664
https://github.com/Perl/perl5/commit/05f6b5c4908cd7f0c9cf96a9915e54ac1ed0f664
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 4a17f72af7acc42567626f807844b5a6f5c17435
https://github.com/Perl/perl5/commit/4a17f72af7acc42567626f807844b5a6f5c17435
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 474be0e5361eafdf18a763fa6cb561e402bd2617
https://github.com/Perl/perl5/commit/474be0e5361eafdf18a763fa6cb561e402bd2617
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 980650e952671b58a3ca2e7b3c8d99ec4e8da4f6
https://github.com/Perl/perl5/commit/980650e952671b58a3ca2e7b3c8d99ec4e8da4f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 3da5f3eaa146f3700e54d9cf3752bbbc5974469c
https://github.com/Perl/perl5/commit/3da5f3eaa146f3700e54d9cf3752bbbc5974469c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: e69a4ba715317fdae7cb357fd019ba08e1e18120
https://github.com/Perl/perl5/commit/e69a4ba715317fdae7cb357fd019ba08e1e18120
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 50346458906deb742c27592f29abaa05f8754420
https://github.com/Perl/perl5/commit/50346458906deb742c27592f29abaa05f8754420
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 8e0a2dd0905bde3101fb9de6712abe916cac43e9
https://github.com/Perl/perl5/commit/8e0a2dd0905bde3101fb9de6712abe916cac43e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 6f768966a627f753b5fec57ad0d117255ae54ade
https://github.com/Perl/perl5/commit/6f768966a627f753b5fec57ad0d117255ae54ade
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 4788f68970af85eb5285f7ab9f3195d48e29cec9
https://github.com/Perl/perl5/commit/4788f68970af85eb5285f7ab9f3195d48e29cec9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a4f549c1fe16505c15ad3bc11c4eda4f758c7017
https://github.com/Perl/perl5/commit/a4f549c1fe16505c15ad3bc11c4eda4f758c7017
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 9d674a21b3ed26064d3fcb889f66f1ced0047478
https://github.com/Perl/perl5/commit/9d674a21b3ed26064d3fcb889f66f1ced0047478
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 06ea80c097f9192331184b5abea247848e361f6c
https://github.com/Perl/perl5/commit/06ea80c097f9192331184b5abea247848e361f6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 0e7c687785416dd91f79ec6a4a5a44adb7be6801
https://github.com/Perl/perl5/commit/0e7c687785416dd91f79ec6a4a5a44adb7be6801
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 5146c5177631be73d8a56a1ed778d13ced16be96
https://github.com/Perl/perl5/commit/5146c5177631be73d8a56a1ed778d13ced16be96
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 0cee6537049a55bf20649911ac05248c1777ca14
https://github.com/Perl/perl5/commit/0cee6537049a55bf20649911ac05248c1777ca14
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: ab005f26dcfb9fabf222233369dca05ec1cb3cec
https://github.com/Perl/perl5/commit/ab005f26dcfb9fabf222233369dca05ec1cb3cec
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 7d278c81a3fe3f033244b6de3f9aceb7e6592549
https://github.com/Perl/perl5/commit/7d278c81a3fe3f033244b6de3f9aceb7e6592549
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 6e37aec29760c30632f67f382a809c2e396479d3
https://github.com/Perl/perl5/commit/6e37aec29760c30632f67f382a809c2e396479d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: c675303105db9c95928ee5f8d62241a2a42ace70
https://github.com/Perl/perl5/commit/c675303105db9c95928ee5f8d62241a2a42ace70
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: d6e9bddaa27b9b952a494063abc2ef5abef3549f
https://github.com/Perl/perl5/commit/d6e9bddaa27b9b952a494063abc2ef5abef3549f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 65c539e8bd21e18a69923958197bcf6b89ae8e9b
https://github.com/Perl/perl5/commit/65c539e8bd21e18a69923958197bcf6b89ae8e9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 0895ec8b774851eed4ecbe8181d8632b12db6ace
https://github.com/Perl/perl5/commit/0895ec8b774851eed4ecbe8181d8632b12db6ace
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 9ad20834353f9a1c8c98e243238bd46c284d99d1
https://github.com/Perl/perl5/commit/9ad20834353f9a1c8c98e243238bd46c284d99d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 583a8a0a8d366c2b500103a8dbb3efbfebefd4f7
https://github.com/Perl/perl5/commit/583a8a0a8d366c2b500103a8dbb3efbfebefd4f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: bfa90bd2bd805f121a94fa4cb5c603c253897565
https://github.com/Perl/perl5/commit/bfa90bd2bd805f121a94fa4cb5c603c253897565
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 4b5bc97602e6d59848a9bd457196268a9628bed5
https://github.com/Perl/perl5/commit/4b5bc97602e6d59848a9bd457196268a9628bed5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: fdfff55a0cc07a57f3cfc3d6e9d7e671daf8a3e0
https://github.com/Perl/perl5/commit/fdfff55a0cc07a57f3cfc3d6e9d7e671daf8a3e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more19
Compare: https://github.com/Perl/perl5/compare/73440f4663d4...fdfff55a0cc0
