Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 686bc90e5bf38f178a582603a826b65ac5a961ab
https://github.com/Perl/perl5/commit/686bc90e5bf38f178a582603a826b65ac5a961ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 13988e21223852e33f15fce0a2dde6997164db13
https://github.com/Perl/perl5/commit/13988e21223852e33f15fce0a2dde6997164db13
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 709dbbbe93997668ded7f1f57fd333c1dd455c40
https://github.com/Perl/perl5/commit/709dbbbe93997668ded7f1f57fd333c1dd455c40
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 90357c2cbbdc01f7da3fa5a24a302bdfad1b3124
https://github.com/Perl/perl5/commit/90357c2cbbdc01f7da3fa5a24a302bdfad1b3124
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 0343909a64200c725526c1c2fc5d71b40cd242ed
https://github.com/Perl/perl5/commit/0343909a64200c725526c1c2fc5d71b40cd242ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: db60a678939e6a1c4959099465085deee7e6821a
https://github.com/Perl/perl5/commit/db60a678939e6a1c4959099465085deee7e6821a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: d09188c86acdb46a460606877f980d8929d55dc0
https://github.com/Perl/perl5/commit/d09188c86acdb46a460606877f980d8929d55dc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: f0b2022028ccfdb86a44f0db1dd8796f53a4032c
https://github.com/Perl/perl5/commit/f0b2022028ccfdb86a44f0db1dd8796f53a4032c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 4346616a15d0cf7b6776ad47c2ca37ee37679e10
https://github.com/Perl/perl5/commit/4346616a15d0cf7b6776ad47c2ca37ee37679e10
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: d43fe9919b1df9c07f4e497f65d26f5dc84b1f66
https://github.com/Perl/perl5/commit/d43fe9919b1df9c07f4e497f65d26f5dc84b1f66
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 4baedc36c8d2c9c174f689150f1b58ee1e01d857
https://github.com/Perl/perl5/commit/4baedc36c8d2c9c174f689150f1b58ee1e01d857
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 10c56651c61bb1a15188b12e41046f65d9c7e22e
https://github.com/Perl/perl5/commit/10c56651c61bb1a15188b12e41046f65d9c7e22e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: aa62db9899f409ccb5f70c1de0017d77517a05f9
https://github.com/Perl/perl5/commit/aa62db9899f409ccb5f70c1de0017d77517a05f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 86689d7973e71dfa68ccf29a77722eb24423a32d
https://github.com/Perl/perl5/commit/86689d7973e71dfa68ccf29a77722eb24423a32d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 03dc0c0ca2f855b449fccf0cfb0247cf022e3fae
https://github.com/Perl/perl5/commit/03dc0c0ca2f855b449fccf0cfb0247cf022e3fae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: de81f849ef6344491c2b0a207242fcfd010e11ab
https://github.com/Perl/perl5/commit/de81f849ef6344491c2b0a207242fcfd010e11ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 83052732e35b88646470d9d3656646446987683d
https://github.com/Perl/perl5/commit/83052732e35b88646470d9d3656646446987683d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 7df725d79d63612e8355c722f9ec2869b1990680
https://github.com/Perl/perl5/commit/7df725d79d63612e8355c722f9ec2869b1990680
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 05d1eb8688760121537d5f244f8ac91827377500
https://github.com/Perl/perl5/commit/05d1eb8688760121537d5f244f8ac91827377500
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: a4c4499efaf8d062ccf16207c0d35594ea307339
https://github.com/Perl/perl5/commit/a4c4499efaf8d062ccf16207c0d35594ea307339
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: c2a1ccfb5b8c67f910b3d6ad86912e653a860120
https://github.com/Perl/perl5/commit/c2a1ccfb5b8c67f910b3d6ad86912e653a860120
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 00fbacea91cfa50adf1d20c542cc2109a0cc90e7
https://github.com/Perl/perl5/commit/00fbacea91cfa50adf1d20c542cc2109a0cc90e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: ef10abf6ae0d396f4828e52292a4629ba1e65651
https://github.com/Perl/perl5/commit/ef10abf6ae0d396f4828e52292a4629ba1e65651
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 27402126b6b69b2e1052916d4b68cd37c465ace1
https://github.com/Perl/perl5/commit/27402126b6b69b2e1052916d4b68cd37c465ace1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 608a74402cc3b5b8f855b22297c78146cc948085
https://github.com/Perl/perl5/commit/608a74402cc3b5b8f855b22297c78146cc948085
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: ef9db7b04cf0c3b20e7dbb7ddc2755683143a913
https://github.com/Perl/perl5/commit/ef9db7b04cf0c3b20e7dbb7ddc2755683143a913
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 96e1dbd3e47009a75db1a3b3d2dc7057d845531e
https://github.com/Perl/perl5/commit/96e1dbd3e47009a75db1a3b3d2dc7057d845531e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 742fdd7cbb1b2f79123862dbf2d69bf06a60631c
https://github.com/Perl/perl5/commit/742fdd7cbb1b2f79123862dbf2d69bf06a60631c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 921996afb8083c9ae5fa18eed376c177a063ed6b
https://github.com/Perl/perl5/commit/921996afb8083c9ae5fa18eed376c177a063ed6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: f5f657069238cfeb8457814233c39cbd2748f352
https://github.com/Perl/perl5/commit/f5f657069238cfeb8457814233c39cbd2748f352
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: fa3702adbd25b1f9dc7eda59c990839c18de27f5
https://github.com/Perl/perl5/commit/fa3702adbd25b1f9dc7eda59c990839c18de27f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 1505cbaa90ce3bea9b42363e23cb754faf631b2c
https://github.com/Perl/perl5/commit/1505cbaa90ce3bea9b42363e23cb754faf631b2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: da3f18048cf050a041040411cc7948e4a464092c
https://github.com/Perl/perl5/commit/da3f18048cf050a041040411cc7948e4a464092c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 6f8fb4e456bc6a9d62b35abe9a024df6d34563e1
https://github.com/Perl/perl5/commit/6f8fb4e456bc6a9d62b35abe9a024df6d34563e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 42a903b53031c8d34c7f92c8f303852b0f0570b6
https://github.com/Perl/perl5/commit/42a903b53031c8d34c7f92c8f303852b0f0570b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: fd29d011d6b718ca01b3fb5cdedad66a972645b1
https://github.com/Perl/perl5/commit/fd29d011d6b718ca01b3fb5cdedad66a972645b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 9dedfa146fcf3e980578ae50ffe2b9dde4d7f7f2
https://github.com/Perl/perl5/commit/9dedfa146fcf3e980578ae50ffe2b9dde4d7f7f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: b2885967d579bc40e1fbb51617368fed76ee1ee7
https://github.com/Perl/perl5/commit/b2885967d579bc40e1fbb51617368fed76ee1ee7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 341185675dec556478fb2fffc9e2887c163ffc90
https://github.com/Perl/perl5/commit/341185675dec556478fb2fffc9e2887c163ffc90
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 7062ed4faed0244399ecfb8adfe9e2c3ab684b6b
https://github.com/Perl/perl5/commit/7062ed4faed0244399ecfb8adfe9e2c3ab684b6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: dce3de76087f773fcbbada6b5446a081dd9eb85c
https://github.com/Perl/perl5/commit/dce3de76087f773fcbbada6b5446a081dd9eb85c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: a64ec426994fdaaeb3097c7f2293914fc884b9ce
https://github.com/Perl/perl5/commit/a64ec426994fdaaeb3097c7f2293914fc884b9ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 8faf68881f97d9d8d808c411f4918e555cf8ca9a
https://github.com/Perl/perl5/commit/8faf68881f97d9d8d808c411f4918e555cf8ca9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 3ea5cc098c0eb4bfdd1b0826272852b64aea4b21
https://github.com/Perl/perl5/commit/3ea5cc098c0eb4bfdd1b0826272852b64aea4b21
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 7f6a74890c2af4dcf75eff800a101b0a2c506238
https://github.com/Perl/perl5/commit/7f6a74890c2af4dcf75eff800a101b0a2c506238
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 8bed3379b3ab3fbf510000e0e569f3c817050cfb
https://github.com/Perl/perl5/commit/8bed3379b3ab3fbf510000e0e569f3c817050cfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: acebe666e178324ea59ad3599c99fec188e570d8
https://github.com/Perl/perl5/commit/acebe666e178324ea59ad3599c99fec188e570d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 83d1f514da827e0215cb5ecbe728a2d528ea6afb
https://github.com/Perl/perl5/commit/83d1f514da827e0215cb5ecbe728a2d528ea6afb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 9a3e43925467b3b4184b5fca3b7e6c1576f5fe46
https://github.com/Perl/perl5/commit/9a3e43925467b3b4184b5fca3b7e6c1576f5fe46
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: f828dad66d6d614fb677ad577e4837d6f1690d50
https://github.com/Perl/perl5/commit/f828dad66d6d614fb677ad577e4837d6f1690d50
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 79ba9f605793e4fafc30a6844d76bdcefcaed966
https://github.com/Perl/perl5/commit/79ba9f605793e4fafc30a6844d76bdcefcaed966
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 390373cd362426578a22c42e46fa34e4012e8516
https://github.com/Perl/perl5/commit/390373cd362426578a22c42e46fa34e4012e8516
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: f88dc46078d4d696642fee619538159ed143e10c
https://github.com/Perl/perl5/commit/f88dc46078d4d696642fee619538159ed143e10c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: e64536904478a3988e3e2c78d36359956e75c62e
https://github.com/Perl/perl5/commit/e64536904478a3988e3e2c78d36359956e75c62e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: c9462e0d1cdd8d91133a2eb4ecfbafe37c8b40ca
https://github.com/Perl/perl5/commit/c9462e0d1cdd8d91133a2eb4ecfbafe37c8b40ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: d58b8b1ff29e6b17f025f1e57f35a0a1aabcf2dd
https://github.com/Perl/perl5/commit/d58b8b1ff29e6b17f025f1e57f35a0a1aabcf2dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 4bc533a25388873e4be18ba4a8350ea41221c2e0
https://github.com/Perl/perl5/commit/4bc533a25388873e4be18ba4a8350ea41221c2e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 5573b313e4df6aae72dd3c07bdc6cf7e4df1617c
https://github.com/Perl/perl5/commit/5573b313e4df6aae72dd3c07bdc6cf7e4df1617c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
f
Commit: e8d0f339c497e70bafd16acbc60d28415fef3b0f
https://github.com/Perl/perl5/commit/e8d0f339c497e70bafd16acbc60d28415fef3b0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: a03ad59e1820e7a04fa1ce5355a20cbd109facae
https://github.com/Perl/perl5/commit/a03ad59e1820e7a04fa1ce5355a20cbd109facae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 7af99b7b90a55c78990ec0a6e55355fb1c0402d4
https://github.com/Perl/perl5/commit/7af99b7b90a55c78990ec0a6e55355fb1c0402d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 864717943688bd763d7c90a8fe67a0e30ed71ae1
https://github.com/Perl/perl5/commit/864717943688bd763d7c90a8fe67a0e30ed71ae1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: f069a337c078859d55e18c21b9c4b0893a0a6480
https://github.com/Perl/perl5/commit/f069a337c078859d55e18c21b9c4b0893a0a6480
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 2969c7a08cec3561938d0b90528347ee1115837e
https://github.com/Perl/perl5/commit/2969c7a08cec3561938d0b90528347ee1115837e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 3820437bad22b5192a36049f73a69a03b67b4f8b
https://github.com/Perl/perl5/commit/3820437bad22b5192a36049f73a69a03b67b4f8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 4e92ea1ce4db2995c0333392fcc0ef4bb0d079b9
https://github.com/Perl/perl5/commit/4e92ea1ce4db2995c0333392fcc0ef4bb0d079b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 94fb2c28e33d6fce276aecc1a7ea1dcd41ea81e1
https://github.com/Perl/perl5/commit/94fb2c28e33d6fce276aecc1a7ea1dcd41ea81e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 50da64f10a0c6b728fdc59fbdb6cc1b6f67c1111
https://github.com/Perl/perl5/commit/50da64f10a0c6b728fdc59fbdb6cc1b6f67c1111
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 5fb0ccc87d355d9d2ba5dcbfd3657400a0266116
https://github.com/Perl/perl5/commit/5fb0ccc87d355d9d2ba5dcbfd3657400a0266116
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 973404bd6c71cc2a86ec44336b9c4c6abd3f6057
https://github.com/Perl/perl5/commit/973404bd6c71cc2a86ec44336b9c4c6abd3f6057
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 6d591b80cae5ca3179022f031b797a4b91a32633
https://github.com/Perl/perl5/commit/6d591b80cae5ca3179022f031b797a4b91a32633
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 3e765d5babd179323472b6482585b4e38e2a64c3
https://github.com/Perl/perl5/commit/3e765d5babd179323472b6482585b4e38e2a64c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 4e69ea7f468209f0358361df894a3d077b8b8b67
https://github.com/Perl/perl5/commit/4e69ea7f468209f0358361df894a3d077b8b8b67
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 22459d6d3ba333468d09088737e30707c8910125
https://github.com/Perl/perl5/commit/22459d6d3ba333468d09088737e30707c8910125
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 6c04c6ee2a19f78d301b2673c8dbc2b049d9796e
https://github.com/Perl/perl5/commit/6c04c6ee2a19f78d301b2673c8dbc2b049d9796e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 511137ffa8434bce8773f04e57cdb91278277b27
https://github.com/Perl/perl5/commit/511137ffa8434bce8773f04e57cdb91278277b27
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: df6b653dd6683cce002ae7d5a722e09bc638b471
https://github.com/Perl/perl5/commit/df6b653dd6683cce002ae7d5a722e09bc638b471
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 0457318db3c2c908340e1049246fa010be000bb0
https://github.com/Perl/perl5/commit/0457318db3c2c908340e1049246fa010be000bb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: d45509ba4a34df4a8cff34eb98dc46507cee66f5
https://github.com/Perl/perl5/commit/d45509ba4a34df4a8cff34eb98dc46507cee66f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 3e0480d29291fd3cc8aa2ee02de020ce2345f6a0
https://github.com/Perl/perl5/commit/3e0480d29291fd3cc8aa2ee02de020ce2345f6a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 78dee3d27c453b5a4818e91f25cc28a3d489af75
https://github.com/Perl/perl5/commit/78dee3d27c453b5a4818e91f25cc28a3d489af75
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 644f82f5692bead44b579a4920b13c3f7c4c56e3
https://github.com/Perl/perl5/commit/644f82f5692bead44b579a4920b13c3f7c4c56e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: e302d0ecdf5ac522ca38cb322566e784b0a50218
https://github.com/Perl/perl5/commit/e302d0ecdf5ac522ca38cb322566e784b0a50218
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 60fb7813c5e77acfcec5e66bf89b422090d5c84a
https://github.com/Perl/perl5/commit/60fb7813c5e77acfcec5e66bf89b422090d5c84a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: d10e18fba8e9279023b08ac22f5efc20ab11145a
https://github.com/Perl/perl5/commit/d10e18fba8e9279023b08ac22f5efc20ab11145a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 346b5df780dbd31505a7c01c3690f3b84ac147ec
https://github.com/Perl/perl5/commit/346b5df780dbd31505a7c01c3690f3b84ac147ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 5a7cc0d3c1b66e8c1013bf1d6f5029c126a58b5b
https://github.com/Perl/perl5/commit/5a7cc0d3c1b66e8c1013bf1d6f5029c126a58b5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: f1b726c3fe23a1a44936693e9eea48a87b633f60
https://github.com/Perl/perl5/commit/f1b726c3fe23a1a44936693e9eea48a87b633f60
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 75e2cf0f45a6b5be29d7ea5d95151fab96803d02
https://github.com/Perl/perl5/commit/75e2cf0f45a6b5be29d7ea5d95151fab96803d02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 5aa9aa883ca684becc1f5e9049da3af8c5c8f4ca
https://github.com/Perl/perl5/commit/5aa9aa883ca684becc1f5e9049da3af8c5c8f4ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 0a805a2a9d23a6d7e0e7e4fa9f09ece0f00b0041
https://github.com/Perl/perl5/commit/0a805a2a9d23a6d7e0e7e4fa9f09ece0f00b0041
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 02e4ca0ae5bf493b8cc189b4235018691aa646e1
https://github.com/Perl/perl5/commit/02e4ca0ae5bf493b8cc189b4235018691aa646e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: bff6666ec78b48dffed4787e0f881919058252c8
https://github.com/Perl/perl5/commit/bff6666ec78b48dffed4787e0f881919058252c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: f8c33a09b22a90ed9b8b2e37e4bfc72ca9f4e270
https://github.com/Perl/perl5/commit/f8c33a09b22a90ed9b8b2e37e4bfc72ca9f4e270
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 0eae481050448b496d096244f9bb5699867cc09e
https://github.com/Perl/perl5/commit/0eae481050448b496d096244f9bb5699867cc09e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 9587cc0f71a35e0eae5334ec0087251a95dafbde
https://github.com/Perl/perl5/commit/9587cc0f71a35e0eae5334ec0087251a95dafbde
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 710c20f0e356773e9682914747f70ac64a6fe1ba
https://github.com/Perl/perl5/commit/710c20f0e356773e9682914747f70ac64a6fe1ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 7787442ff0e35b821e228056dcb50c46d43be9df
https://github.com/Perl/perl5/commit/7787442ff0e35b821e228056dcb50c46d43be9df
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 3f611de43d49d8c666e56beddff89b569f95e468
https://github.com/Perl/perl5/commit/3f611de43d49d8c666e56beddff89b569f95e468
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: b27853363cea38821b2cc23eca09667af7d5216f
https://github.com/Perl/perl5/commit/b27853363cea38821b2cc23eca09667af7d5216f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 43533d4cfe3b5d95cb4b06a335b29ecf5c244c45
https://github.com/Perl/perl5/commit/43533d4cfe3b5d95cb4b06a335b29ecf5c244c45
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 99339b925a1cd6537675512ab3704186bf41feb3
https://github.com/Perl/perl5/commit/99339b925a1cd6537675512ab3704186bf41feb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 4378ef0f16bca0ed927eb1cf9c802afbe89aec2c
https://github.com/Perl/perl5/commit/4378ef0f16bca0ed927eb1cf9c802afbe89aec2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 377d87bb5b2006104d463217030a4858a8e46c03
https://github.com/Perl/perl5/commit/377d87bb5b2006104d463217030a4858a8e46c03
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 3115568a0db9b976bdcb7a5da8d4429e00d19fd0
https://github.com/Perl/perl5/commit/3115568a0db9b976bdcb7a5da8d4429e00d19fd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 2c6b544ff95ce3e89a09932a36ed3670441f584c
https://github.com/Perl/perl5/commit/2c6b544ff95ce3e89a09932a36ed3670441f584c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 140a1abd9ae4867fde8e049126687ca6466e1aae
https://github.com/Perl/perl5/commit/140a1abd9ae4867fde8e049126687ca6466e1aae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: e8b0313a9bc36d8f9e6cca80ed34fa57c2fd28ca
https://github.com/Perl/perl5/commit/e8b0313a9bc36d8f9e6cca80ed34fa57c2fd28ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: e9a8be7b80a5ec84e94cf5c11c3645c8d8968354
https://github.com/Perl/perl5/commit/e9a8be7b80a5ec84e94cf5c11c3645c8d8968354
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 62bdc3dd56f59ff2e8d1791c13db059687e7cb71
https://github.com/Perl/perl5/commit/62bdc3dd56f59ff2e8d1791c13db059687e7cb71
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 9fb2c83d74372ae1727e475121399737c257cb30
https://github.com/Perl/perl5/commit/9fb2c83d74372ae1727e475121399737c257cb30
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 5f258c3ec179410a1cb69a9c10155422f59913ba
https://github.com/Perl/perl5/commit/5f258c3ec179410a1cb69a9c10155422f59913ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 54d01eb198b7f658f4d133eb718cda93e188d1e9
https://github.com/Perl/perl5/commit/54d01eb198b7f658f4d133eb718cda93e188d1e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: d04d0f5e4fa8f5e0803c490b4b19e95fbb814f6b
https://github.com/Perl/perl5/commit/d04d0f5e4fa8f5e0803c490b4b19e95fbb814f6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 6b5952a6956bd2aabffe4207e2d9f58ea2a17325
https://github.com/Perl/perl5/commit/6b5952a6956bd2aabffe4207e2d9f58ea2a17325
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: b71c507c7ecdd6be771d84c07ac1845f34f7de7d
https://github.com/Perl/perl5/commit/b71c507c7ecdd6be771d84c07ac1845f34f7de7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 9dd275246f065ac23ca9615b83f452537e91f868
https://github.com/Perl/perl5/commit/9dd275246f065ac23ca9615b83f452537e91f868
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 5dcba0d401d42b34e22228d85b3a1ad7986c895d
https://github.com/Perl/perl5/commit/5dcba0d401d42b34e22228d85b3a1ad7986c895d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 21f2521337ff4142bb59fda6f4be94916af6e548
https://github.com/Perl/perl5/commit/21f2521337ff4142bb59fda6f4be94916af6e548
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 99362526a9d8f003ab5bc1a8c612b951e61b43a9
https://github.com/Perl/perl5/commit/99362526a9d8f003ab5bc1a8c612b951e61b43a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 251240ed7abef10d3509563c88663980cb1ea6b7
https://github.com/Perl/perl5/commit/251240ed7abef10d3509563c88663980cb1ea6b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: be52bf3ef5430389bbe505fa80869ea774011791
https://github.com/Perl/perl5/commit/be52bf3ef5430389bbe505fa80869ea774011791
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: aa1c7d24d7a1888251319593cae8b9945cbda66e
https://github.com/Perl/perl5/commit/aa1c7d24d7a1888251319593cae8b9945cbda66e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 28defa7b2ec5d65d1838a4309b2c707ad78aa9cc
https://github.com/Perl/perl5/commit/28defa7b2ec5d65d1838a4309b2c707ad78aa9cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 9251056900998b2d8f52c12905061a514c707b5f
https://github.com/Perl/perl5/commit/9251056900998b2d8f52c12905061a514c707b5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0c506461a8f03ffc53a7cb0a29a404c69c7e094e
https://github.com/Perl/perl5/commit/0c506461a8f03ffc53a7cb0a29a404c69c7e094e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: b88b70f1080491fa6b1f559a7eb0e1cefff909fd
https://github.com/Perl/perl5/commit/b88b70f1080491fa6b1f559a7eb0e1cefff909fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: f174e7b1e9b441b9323424d37291e3d34760d7f3
https://github.com/Perl/perl5/commit/f174e7b1e9b441b9323424d37291e3d34760d7f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: b2a11e8ec82d2677caa6a58b51e048e36fa3a4dc
https://github.com/Perl/perl5/commit/b2a11e8ec82d2677caa6a58b51e048e36fa3a4dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 9cc2d3a877b1174314cedfa3af22b99ea02157af
https://github.com/Perl/perl5/commit/9cc2d3a877b1174314cedfa3af22b99ea02157af
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 6670dee46bd2d23c89cb81c23434ead20bbe90f8
https://github.com/Perl/perl5/commit/6670dee46bd2d23c89cb81c23434ead20bbe90f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 4a2e1b073b86689425fc7ed7085065b7f6b20b73
https://github.com/Perl/perl5/commit/4a2e1b073b86689425fc7ed7085065b7f6b20b73
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 1e95487f1d852729f917e96f06b450769b29c8ff
https://github.com/Perl/perl5/commit/1e95487f1d852729f917e96f06b450769b29c8ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 02b56e6b5942d45ef9bf75173d270049158e76a4
https://github.com/Perl/perl5/commit/02b56e6b5942d45ef9bf75173d270049158e76a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 3be31848126f260f924de6127d8e9ac7b1cf234c
https://github.com/Perl/perl5/commit/3be31848126f260f924de6127d8e9ac7b1cf234c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: aeb55778e3b3a6f8d7b6eccf676a68703c9b5308
https://github.com/Perl/perl5/commit/aeb55778e3b3a6f8d7b6eccf676a68703c9b5308
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: ff95ec0516b4cf0e46c1eea842021831d45f0007
https://github.com/Perl/perl5/commit/ff95ec0516b4cf0e46c1eea842021831d45f0007
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 7e73c91dd3d16fef6dab31f91fdca8d6bef90c02
https://github.com/Perl/perl5/commit/7e73c91dd3d16fef6dab31f91fdca8d6bef90c02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 1c99437d96fd9e119e70edbecff1ec0dc34e465a
https://github.com/Perl/perl5/commit/1c99437d96fd9e119e70edbecff1ec0dc34e465a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: e06004b063903a5c9c8ca4cdb500ec7eaf4f6e9f
https://github.com/Perl/perl5/commit/e06004b063903a5c9c8ca4cdb500ec7eaf4f6e9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 52b2e7b2b8a07946135aee3f7c1a0efebee1360b
https://github.com/Perl/perl5/commit/52b2e7b2b8a07946135aee3f7c1a0efebee1360b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 130f3132295d64352987547023e3ab3c1fc49ddf
https://github.com/Perl/perl5/commit/130f3132295d64352987547023e3ab3c1fc49ddf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 6805ca99606280c27068049a5876dd84990cd63e
https://github.com/Perl/perl5/commit/6805ca99606280c27068049a5876dd84990cd63e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 34c851a98e76747fe41d871a640324c79e80cd65
https://github.com/Perl/perl5/commit/34c851a98e76747fe41d871a640324c79e80cd65
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: b38922f090b0c8aecd105cea6f3211f544b0cc5f
https://github.com/Perl/perl5/commit/b38922f090b0c8aecd105cea6f3211f544b0cc5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: b971abd9c3ffaf02a8195211d7c5738b57318b43
https://github.com/Perl/perl5/commit/b971abd9c3ffaf02a8195211d7c5738b57318b43
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: be6f38574f8af78c863a9b4ae4ced83355945ad0
https://github.com/Perl/perl5/commit/be6f38574f8af78c863a9b4ae4ced83355945ad0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 52142546c8fec6bc61242b2a1e43466f8cfde1d2
https://github.com/Perl/perl5/commit/52142546c8fec6bc61242b2a1e43466f8cfde1d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: d5bc4dfd13731c894bb79d6c41b80682f2f2ca32
https://github.com/Perl/perl5/commit/d5bc4dfd13731c894bb79d6c41b80682f2f2ca32
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 0b7f4c46605550acba072665d73f3a08a8374b71
https://github.com/Perl/perl5/commit/0b7f4c46605550acba072665d73f3a08a8374b71
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 1434460827d069fb9328109f1da21d89c060c873
https://github.com/Perl/perl5/commit/1434460827d069fb9328109f1da21d89c060c873
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 32d3c735eba5929bbca136f2cf2d2fec21d7bb7d
https://github.com/Perl/perl5/commit/32d3c735eba5929bbca136f2cf2d2fec21d7bb7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 4c2aed7b86d1d7e38f83730e7c90c4af8d99241b
https://github.com/Perl/perl5/commit/4c2aed7b86d1d7e38f83730e7c90c4af8d99241b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5233cddd18c26b8aad29e6376955bcdf16d1430b
https://github.com/Perl/perl5/commit/5233cddd18c26b8aad29e6376955bcdf16d1430b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: e81091f622dcef24e4bcd9188aae80ddab3ff99f
https://github.com/Perl/perl5/commit/e81091f622dcef24e4bcd9188aae80ddab3ff99f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 3ad59a71cbb58b333de836249fe94d5991e4a61f
https://github.com/Perl/perl5/commit/3ad59a71cbb58b333de836249fe94d5991e4a61f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 65ab8e83df75a6157c9ec654cda9735ecc5c59d2
https://github.com/Perl/perl5/commit/65ab8e83df75a6157c9ec654cda9735ecc5c59d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: d82aca30ec1323c6a829b0a95dec2d73f2ce8fa1
https://github.com/Perl/perl5/commit/d82aca30ec1323c6a829b0a95dec2d73f2ce8fa1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: a1d018713297a4124984e3cd5dd1e3be0c3af09e
https://github.com/Perl/perl5/commit/a1d018713297a4124984e3cd5dd1e3be0c3af09e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: f6331c015b3f9036c65f10ec57e06bc036414732
https://github.com/Perl/perl5/commit/f6331c015b3f9036c65f10ec57e06bc036414732
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 7d209b1d8538988dcf1e628b332649720bdbb0ca
https://github.com/Perl/perl5/commit/7d209b1d8538988dcf1e628b332649720bdbb0ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 88021d2ec82af024f2e0c563afa4bae5ba25bc94
https://github.com/Perl/perl5/commit/88021d2ec82af024f2e0c563afa4bae5ba25bc94
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 16834228ee2452231eeb54b71bceea3dcdf2f9f6
https://github.com/Perl/perl5/commit/16834228ee2452231eeb54b71bceea3dcdf2f9f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 877685263da4be7cc10194ca01f4a160e788e004
https://github.com/Perl/perl5/commit/877685263da4be7cc10194ca01f4a160e788e004
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: d3f9987fae481a6b61c30154c75205fcda449631
https://github.com/Perl/perl5/commit/d3f9987fae481a6b61c30154c75205fcda449631
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 87fe1e311d6e5e81a7e1a75e27d0376f2dd0fb07
https://github.com/Perl/perl5/commit/87fe1e311d6e5e81a7e1a75e27d0376f2dd0fb07
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 0b8caf6c21fe7457f65003b7beb55fc257e28302
https://github.com/Perl/perl5/commit/0b8caf6c21fe7457f65003b7beb55fc257e28302
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 2ee9e5c96006879528923be05e9b4e0a81da61aa
https://github.com/Perl/perl5/commit/2ee9e5c96006879528923be05e9b4e0a81da61aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: e76ed9311fc966d5bf693a7d0bb2b214b03c3f88
https://github.com/Perl/perl5/commit/e76ed9311fc966d5bf693a7d0bb2b214b03c3f88
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 43a9d0ef559d9824dd13fc6b7a8816912a047cd3
https://github.com/Perl/perl5/commit/43a9d0ef559d9824dd13fc6b7a8816912a047cd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 4d8749b7d8d1a5d55e75aa001a23975d07f16fe9
https://github.com/Perl/perl5/commit/4d8749b7d8d1a5d55e75aa001a23975d07f16fe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: f5399952f37c7a59290cab8e0c14197e90800f02
https://github.com/Perl/perl5/commit/f5399952f37c7a59290cab8e0c14197e90800f02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 0242bbbc256f14a5e8e7aacbfdca49aff5a6a8f5
https://github.com/Perl/perl5/commit/0242bbbc256f14a5e8e7aacbfdca49aff5a6a8f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 8ad948bc45ec748af30b5535ecf99a175d0324f2
https://github.com/Perl/perl5/commit/8ad948bc45ec748af30b5535ecf99a175d0324f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 4a863e9246fb38afbf7dd1fedf574a5cb715378e
https://github.com/Perl/perl5/commit/4a863e9246fb38afbf7dd1fedf574a5cb715378e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: f0ab1729725a3759c664f732d71b1d4be873fbe0
https://github.com/Perl/perl5/commit/f0ab1729725a3759c664f732d71b1d4be873fbe0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: c981c7fcfbde3642138244b8b32505cbf0cca6fb
https://github.com/Perl/perl5/commit/c981c7fcfbde3642138244b8b32505cbf0cca6fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 1c3e859686147e3cc04d33b11a2d27511dc51bb1
https://github.com/Perl/perl5/commit/1c3e859686147e3cc04d33b11a2d27511dc51bb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 33e1fd4b3ab7c8efa3d28533cbef5facd0eb102e
https://github.com/Perl/perl5/commit/33e1fd4b3ab7c8efa3d28533cbef5facd0eb102e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 437c6072ad612c14070901f45aa58ed59277fb5f
https://github.com/Perl/perl5/commit/437c6072ad612c14070901f45aa58ed59277fb5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: c515a0df632286b461cd8cb222c97ab2bfa5da02
https://github.com/Perl/perl5/commit/c515a0df632286b461cd8cb222c97ab2bfa5da02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 1116f36800aa643c81e6e18fcb819a42e7cbf9ae
https://github.com/Perl/perl5/commit/1116f36800aa643c81e6e18fcb819a42e7cbf9ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 589d2c29df0dc156e924ce58634c639acfa52b14
https://github.com/Perl/perl5/commit/589d2c29df0dc156e924ce58634c639acfa52b14
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: d7cc22775b17079653025f28ff01d4e262a796bb
https://github.com/Perl/perl5/commit/d7cc22775b17079653025f28ff01d4e262a796bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 65a376c362dca3cb2738d303a471d0c5c010777b
https://github.com/Perl/perl5/commit/65a376c362dca3cb2738d303a471d0c5c010777b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: be806fa1907b9386b90adae9cdd8160110cc2892
https://github.com/Perl/perl5/commit/be806fa1907b9386b90adae9cdd8160110cc2892
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 983c8f692d534f7329451b9b1ce83edfb42d73e8
https://github.com/Perl/perl5/commit/983c8f692d534f7329451b9b1ce83edfb42d73e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b8b5bc5978dbf36b2d61a65aa58ecd1a7893366e
https://github.com/Perl/perl5/commit/b8b5bc5978dbf36b2d61a65aa58ecd1a7893366e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 5cc78a0a084f0257455e7586928e2ed8519edee6
https://github.com/Perl/perl5/commit/5cc78a0a084f0257455e7586928e2ed8519edee6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: e05299d8ca787ec2676f92f60273aca6a2ed3dad
https://github.com/Perl/perl5/commit/e05299d8ca787ec2676f92f60273aca6a2ed3dad
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: c843cb1bfe221265548299bc6ec502512dd93cec
https://github.com/Perl/perl5/commit/c843cb1bfe221265548299bc6ec502512dd93cec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: f9be8e646c54cd5146c2fa5763d1b3b0d04a86fa
https://github.com/Perl/perl5/commit/f9be8e646c54cd5146c2fa5763d1b3b0d04a86fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 6b0631fb2416f560801ac26a8bcce9f96e651a03
https://github.com/Perl/perl5/commit/6b0631fb2416f560801ac26a8bcce9f96e651a03
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 880e460d0a38eaa7f61e227bacff6b33b1924561
https://github.com/Perl/perl5/commit/880e460d0a38eaa7f61e227bacff6b33b1924561
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 8a8ee6b3ea9b67c2ba538c5aff113121deae7b9a
https://github.com/Perl/perl5/commit/8a8ee6b3ea9b67c2ba538c5aff113121deae7b9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 354d9c243c2c39b399dbebf302432695490bf89a
https://github.com/Perl/perl5/commit/354d9c243c2c39b399dbebf302432695490bf89a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: d1e139abea6c18654fe612bf6f20c745fdfadadc
https://github.com/Perl/perl5/commit/d1e139abea6c18654fe612bf6f20c745fdfadadc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 8b21e2c5170fe3137b9b71fd7ac964b7988442b2
https://github.com/Perl/perl5/commit/8b21e2c5170fe3137b9b71fd7ac964b7988442b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 410fea5318dcc4eefb3f8878ad0eb7fd67616c26
https://github.com/Perl/perl5/commit/410fea5318dcc4eefb3f8878ad0eb7fd67616c26
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 23176f910f694f68087e19b01f08230b99b5d1ac
https://github.com/Perl/perl5/commit/23176f910f694f68087e19b01f08230b99b5d1ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: e2b1228dbc75d40b8fa3de780b55c7c5b8097d85
https://github.com/Perl/perl5/commit/e2b1228dbc75d40b8fa3de780b55c7c5b8097d85
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: feaf12f97bf7153dfa63465d6ab50df658ff12b8
https://github.com/Perl/perl5/commit/feaf12f97bf7153dfa63465d6ab50df658ff12b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 30a34f33b7476962550963b26142ac58909e31c0
https://github.com/Perl/perl5/commit/30a34f33b7476962550963b26142ac58909e31c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 16b1d3d27784019b9e72f2c8ccc66d468ceae207
https://github.com/Perl/perl5/commit/16b1d3d27784019b9e72f2c8ccc66d468ceae207
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 75a6b174ed76ab6fc556e501960475fbff607ed6
https://github.com/Perl/perl5/commit/75a6b174ed76ab6fc556e501960475fbff607ed6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 02d71ed1b183b1a6b91ad291ff412e78f2b33d97
https://github.com/Perl/perl5/commit/02d71ed1b183b1a6b91ad291ff412e78f2b33d97
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 355102515691a853e9e5113b624b7c7d52a51940
https://github.com/Perl/perl5/commit/355102515691a853e9e5113b624b7c7d52a51940
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: cd762d156c15b4953622fbc4d75f4411a74a4040
https://github.com/Perl/perl5/commit/cd762d156c15b4953622fbc4d75f4411a74a4040
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 8277e17ff5859d90d89fbea3cdee5c807a18eae9
https://github.com/Perl/perl5/commit/8277e17ff5859d90d89fbea3cdee5c807a18eae9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 2534db15f088734ee0135e3dcc3b67166eb927b2
https://github.com/Perl/perl5/commit/2534db15f088734ee0135e3dcc3b67166eb927b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 75c675cec1acc3d0f5653c9d12f4b242c65e0fad
https://github.com/Perl/perl5/commit/75c675cec1acc3d0f5653c9d12f4b242c65e0fad
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: d3d097317f639ac3bdb6d3563eb8b8c25cdaf3c1
https://github.com/Perl/perl5/commit/d3d097317f639ac3bdb6d3563eb8b8c25cdaf3c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: f94ca0a9909b7c3d15152b17bb40b9b90941af6a
https://github.com/Perl/perl5/commit/f94ca0a9909b7c3d15152b17bb40b9b90941af6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
28
Compare: https://github.com/Perl/perl5/compare/0913629a528e...f94ca0a9909b
