Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: d698e7bc9573fe0eca404fbefaf49854950bd69d
https://github.com/Perl/perl5/commit/d698e7bc9573fe0eca404fbefaf49854950bd69d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 945de98d4a32e5252d5778b4288a8c345cf3c939
https://github.com/Perl/perl5/commit/945de98d4a32e5252d5778b4288a8c345cf3c939
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: b0292e31556dedf476d01cb52e32337decdb157c
https://github.com/Perl/perl5/commit/b0292e31556dedf476d01cb52e32337decdb157c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: e81c69a1856bda9ea62df28c26f80619e60e27de
https://github.com/Perl/perl5/commit/e81c69a1856bda9ea62df28c26f80619e60e27de
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 9a190d2dd0895b7ec4a87a1b117e966535917d10
https://github.com/Perl/perl5/commit/9a190d2dd0895b7ec4a87a1b117e966535917d10
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: aaf89d7fbf5dd6e479bb518342f7add5efbd114d
https://github.com/Perl/perl5/commit/aaf89d7fbf5dd6e479bb518342f7add5efbd114d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: a1471914ae42e50ab3c000024826ccd3d0ef59b9
https://github.com/Perl/perl5/commit/a1471914ae42e50ab3c000024826ccd3d0ef59b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: a8007fd8e5971509658ace1788cea928a310d015
https://github.com/Perl/perl5/commit/a8007fd8e5971509658ace1788cea928a310d015
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 61b1f43dd0a5ad9f7006e0fd8ffabf4961fdeb06
https://github.com/Perl/perl5/commit/61b1f43dd0a5ad9f7006e0fd8ffabf4961fdeb06
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 1f8429f0f807eaa6daea762fdd2612d07ed00f4c
https://github.com/Perl/perl5/commit/1f8429f0f807eaa6daea762fdd2612d07ed00f4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 0395a159120bc1b40580f92b2f1f102fda949dc6
https://github.com/Perl/perl5/commit/0395a159120bc1b40580f92b2f1f102fda949dc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 9100c144563ad541cddcafaf7e74ba3a1fe7546e
https://github.com/Perl/perl5/commit/9100c144563ad541cddcafaf7e74ba3a1fe7546e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 07fc5b0ba3963fecb2fc1975724062b3cc1f8257
https://github.com/Perl/perl5/commit/07fc5b0ba3963fecb2fc1975724062b3cc1f8257
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 2541152ff3ad3b5d3218eb0bfc8f3e64d5a5fd65
https://github.com/Perl/perl5/commit/2541152ff3ad3b5d3218eb0bfc8f3e64d5a5fd65
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 5615ac7e687effe955c3d0f93ea77f9bdfdb9921
https://github.com/Perl/perl5/commit/5615ac7e687effe955c3d0f93ea77f9bdfdb9921
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: e0553e238afa49bca65051b552b00c2776bc03b7
https://github.com/Perl/perl5/commit/e0553e238afa49bca65051b552b00c2776bc03b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: ac5588beddebf25b5f33b2027df77a8a2ffeabbb
https://github.com/Perl/perl5/commit/ac5588beddebf25b5f33b2027df77a8a2ffeabbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: dc1b6fbd40829cced071c2ec956d20bd0347d853
https://github.com/Perl/perl5/commit/dc1b6fbd40829cced071c2ec956d20bd0347d853
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 7f9067687fa76cb74d8a374cb9cc37cbf2822111
https://github.com/Perl/perl5/commit/7f9067687fa76cb74d8a374cb9cc37cbf2822111
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 9b1d7507e446714e283ae8d0a3b9e7e7d17a855a
https://github.com/Perl/perl5/commit/9b1d7507e446714e283ae8d0a3b9e7e7d17a855a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 154185a2e3373ab60a6c7d90c43f8b98e91fb685
https://github.com/Perl/perl5/commit/154185a2e3373ab60a6c7d90c43f8b98e91fb685
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: a5e6a3f2e2998bd29ecdcecb4dd4892827d4e10b
https://github.com/Perl/perl5/commit/a5e6a3f2e2998bd29ecdcecb4dd4892827d4e10b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: fa9c31297cdb8907d36a4e98662f0081ffb9634d
https://github.com/Perl/perl5/commit/fa9c31297cdb8907d36a4e98662f0081ffb9634d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 623c508f7cf0b60b7f2747c953f0de63a4060326
https://github.com/Perl/perl5/commit/623c508f7cf0b60b7f2747c953f0de63a4060326
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 69103d9864dc5205801efbc8c7886c37a42096df
https://github.com/Perl/perl5/commit/69103d9864dc5205801efbc8c7886c37a42096df
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 17a4031480edb968d9cd7d2e1b4ee1d5d9ddd950
https://github.com/Perl/perl5/commit/17a4031480edb968d9cd7d2e1b4ee1d5d9ddd950
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: af02dabd5973c30e2e44522ed5fbd8f78f686336
https://github.com/Perl/perl5/commit/af02dabd5973c30e2e44522ed5fbd8f78f686336
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 10ac2677b673ba103e397d9a39588ddd2cab44f5
https://github.com/Perl/perl5/commit/10ac2677b673ba103e397d9a39588ddd2cab44f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: c8fbfa2484139fab6847a54f149ccdde7a6b6e3a
https://github.com/Perl/perl5/commit/c8fbfa2484139fab6847a54f149ccdde7a6b6e3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: ce7b285c486d72d07c97b7f42e9daa4a547bc9a3
https://github.com/Perl/perl5/commit/ce7b285c486d72d07c97b7f42e9daa4a547bc9a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 7a5f54c787bfc6088fe00b08c165972949b0e7bd
https://github.com/Perl/perl5/commit/7a5f54c787bfc6088fe00b08c165972949b0e7bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 0b840e858c8802206d2853d0b9392c948560243c
https://github.com/Perl/perl5/commit/0b840e858c8802206d2853d0b9392c948560243c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: f90bda484bfa469733b0fb7d6fbc04a974dc3e43
https://github.com/Perl/perl5/commit/f90bda484bfa469733b0fb7d6fbc04a974dc3e43
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: ab261c81a833f0e898ed44e39ede0d5c4e72d28b
https://github.com/Perl/perl5/commit/ab261c81a833f0e898ed44e39ede0d5c4e72d28b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: f65fad88a86b9e71857bee2fc3d0d4dbcafe613e
https://github.com/Perl/perl5/commit/f65fad88a86b9e71857bee2fc3d0d4dbcafe613e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 96b3337ee36825e9f50372d25638e689ee75a97c
https://github.com/Perl/perl5/commit/96b3337ee36825e9f50372d25638e689ee75a97c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 8808a677cefdfbddf949f44a3ce93983190ec2d3
https://github.com/Perl/perl5/commit/8808a677cefdfbddf949f44a3ce93983190ec2d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: ef3ad95d60a48b5663b382593d279f9eb344db0d
https://github.com/Perl/perl5/commit/ef3ad95d60a48b5663b382593d279f9eb344db0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 95dad2971a27278f4d3ca1b99700e76699a401bc
https://github.com/Perl/perl5/commit/95dad2971a27278f4d3ca1b99700e76699a401bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: fa001b442ca4950e8c9c12b26ee4e4e8b9e82cbb
https://github.com/Perl/perl5/commit/fa001b442ca4950e8c9c12b26ee4e4e8b9e82cbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 6de945cbdc8204401e2dbae5df13493fc29a88b4
https://github.com/Perl/perl5/commit/6de945cbdc8204401e2dbae5df13493fc29a88b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 79ddf1d4f609809b926e9a7a416c8a78e314a529
https://github.com/Perl/perl5/commit/79ddf1d4f609809b926e9a7a416c8a78e314a529
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 796646fd6e9e1e3c7fa3d60f47d9ddd3422d5c7f
https://github.com/Perl/perl5/commit/796646fd6e9e1e3c7fa3d60f47d9ddd3422d5c7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 3c9c0fd877ec979d7a8839af6355f62b5b3f1da9
https://github.com/Perl/perl5/commit/3c9c0fd877ec979d7a8839af6355f62b5b3f1da9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: dc81a2435e64ccb85d47cd7576ce97734f956f00
https://github.com/Perl/perl5/commit/dc81a2435e64ccb85d47cd7576ce97734f956f00
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 22b63230054dbf1f07e219b7ba89a12feaceecb4
https://github.com/Perl/perl5/commit/22b63230054dbf1f07e219b7ba89a12feaceecb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 2d0cb7506e39c885a57ab587fcf1990efa20d69c
https://github.com/Perl/perl5/commit/2d0cb7506e39c885a57ab587fcf1990efa20d69c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: f84c609f4099deddb44eb8ea970ba26180997b8e
https://github.com/Perl/perl5/commit/f84c609f4099deddb44eb8ea970ba26180997b8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 87099bdbd047724268850a970b85a6af52a9cda2
https://github.com/Perl/perl5/commit/87099bdbd047724268850a970b85a6af52a9cda2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 5df78ca92dbd06bdb184c0887dfe102bcdcaf5dc
https://github.com/Perl/perl5/commit/5df78ca92dbd06bdb184c0887dfe102bcdcaf5dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 9bb313854cd6abd320ad4eb45bc454b9acd63fbb
https://github.com/Perl/perl5/commit/9bb313854cd6abd320ad4eb45bc454b9acd63fbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 9d7ba91db4ce7f1b560593cbccd3c9cc4c69a17f
https://github.com/Perl/perl5/commit/9d7ba91db4ce7f1b560593cbccd3c9cc4c69a17f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 8ce657f326f35612675e7672b1c93990069f0934
https://github.com/Perl/perl5/commit/8ce657f326f35612675e7672b1c93990069f0934
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 2ed31c5a2e1cb145c0095512c1eb80565b68c225
https://github.com/Perl/perl5/commit/2ed31c5a2e1cb145c0095512c1eb80565b68c225
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: eb26201bb8a0e061bcd93806e1269da772b2a6d1
https://github.com/Perl/perl5/commit/eb26201bb8a0e061bcd93806e1269da772b2a6d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 201154a820109d3ce36fd59c55969b517d280570
https://github.com/Perl/perl5/commit/201154a820109d3ce36fd59c55969b517d280570
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: c409c3ddc3bab789efd9eebc6c8550180a9cd20d
https://github.com/Perl/perl5/commit/c409c3ddc3bab789efd9eebc6c8550180a9cd20d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 729015771ce9c426db859b027f8be0ea1af797f2
https://github.com/Perl/perl5/commit/729015771ce9c426db859b027f8be0ea1af797f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: f18050b45e04c85aeff1e51227674719bd08aa0b
https://github.com/Perl/perl5/commit/f18050b45e04c85aeff1e51227674719bd08aa0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 40cb9ff9d5a03b3999f78820ffeb0d5d2b6e5c06
https://github.com/Perl/perl5/commit/40cb9ff9d5a03b3999f78820ffeb0d5d2b6e5c06
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: ebf2053e81a658ca3682f3227a1a52eda1c6d3c9
https://github.com/Perl/perl5/commit/ebf2053e81a658ca3682f3227a1a52eda1c6d3c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 32c07108c997064616e22169ea6158840685032c
https://github.com/Perl/perl5/commit/32c07108c997064616e22169ea6158840685032c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 3c1f5b4fc36ba623393ed0efa7261d64fc31bef2
https://github.com/Perl/perl5/commit/3c1f5b4fc36ba623393ed0efa7261d64fc31bef2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 92ef2683fb5a2ab19835f5bb6c5b00c55e160de1
https://github.com/Perl/perl5/commit/92ef2683fb5a2ab19835f5bb6c5b00c55e160de1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: e28e25c2fd9cce12ca8d58c86f2d20645189f496
https://github.com/Perl/perl5/commit/e28e25c2fd9cce12ca8d58c86f2d20645189f496
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d0ec270237b4156c80893b8fc405e1020aea9f26
https://github.com/Perl/perl5/commit/d0ec270237b4156c80893b8fc405e1020aea9f26
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: bd2dd5b8e8b94745bb408d0eff3fd50fcabff888
https://github.com/Perl/perl5/commit/bd2dd5b8e8b94745bb408d0eff3fd50fcabff888
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 4469d417195dcddc2b4bf0993a620fbd2890e1c4
https://github.com/Perl/perl5/commit/4469d417195dcddc2b4bf0993a620fbd2890e1c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 6c18bde11f8a3af7bd109cff57f4e07d4ec03f0b
https://github.com/Perl/perl5/commit/6c18bde11f8a3af7bd109cff57f4e07d4ec03f0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 8292c44a0660a7779dd4d779f8808a1851e7a7af
https://github.com/Perl/perl5/commit/8292c44a0660a7779dd4d779f8808a1851e7a7af
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 042cd90febe41dbe94bac93e07ab3ff76db66eac
https://github.com/Perl/perl5/commit/042cd90febe41dbe94bac93e07ab3ff76db66eac
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 5f4c6cdcee279a9321b7628510fc4f1fb17cc667
https://github.com/Perl/perl5/commit/5f4c6cdcee279a9321b7628510fc4f1fb17cc667
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e6a7dc394e0a7b6c3ff17841f22064587aa3ea3d
https://github.com/Perl/perl5/commit/e6a7dc394e0a7b6c3ff17841f22064587aa3ea3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 2759447fbdb829b90f4aaf0cf8308d6d67e28c90
https://github.com/Perl/perl5/commit/2759447fbdb829b90f4aaf0cf8308d6d67e28c90
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: d30a19f544d76fe93d7cd1a8a1f383ea8641e5bd
https://github.com/Perl/perl5/commit/d30a19f544d76fe93d7cd1a8a1f383ea8641e5bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 50997db6910e02d49554140795816c397f7cd2b9
https://github.com/Perl/perl5/commit/50997db6910e02d49554140795816c397f7cd2b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 340c9ae9823b239a1875f877c6ccc8ef9a3d31df
https://github.com/Perl/perl5/commit/340c9ae9823b239a1875f877c6ccc8ef9a3d31df
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 996c4f797510d37bb0d3bd705f3af6d1059dcf51
https://github.com/Perl/perl5/commit/996c4f797510d37bb0d3bd705f3af6d1059dcf51
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 80b63e8a7ae4159c6115a43941d7cbe376a2526b
https://github.com/Perl/perl5/commit/80b63e8a7ae4159c6115a43941d7cbe376a2526b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: b3544f0a14f95098c3cadd45927b34e9e3caab8e
https://github.com/Perl/perl5/commit/b3544f0a14f95098c3cadd45927b34e9e3caab8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 5309450d12af7821fffd5a2e418826137ec56e6f
https://github.com/Perl/perl5/commit/5309450d12af7821fffd5a2e418826137ec56e6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 90c40223512cb89b01a1d97f4f9ffb8cd51b5c25
https://github.com/Perl/perl5/commit/90c40223512cb89b01a1d97f4f9ffb8cd51b5c25
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: ac845325dacc6026b67eab16875035bb2119d031
https://github.com/Perl/perl5/commit/ac845325dacc6026b67eab16875035bb2119d031
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 0e4938924a6e1b051df1b7970a9825693c1fd8e4
https://github.com/Perl/perl5/commit/0e4938924a6e1b051df1b7970a9825693c1fd8e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 59dbdf69619a46d8b4cf2654ccb172b215695cb2
https://github.com/Perl/perl5/commit/59dbdf69619a46d8b4cf2654ccb172b215695cb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 29af75fe6133ef8d1d3b7e4bb94e35114641f6d1
https://github.com/Perl/perl5/commit/29af75fe6133ef8d1d3b7e4bb94e35114641f6d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 91504668c58ea44b722253c130238a7d67e8b44c
https://github.com/Perl/perl5/commit/91504668c58ea44b722253c130238a7d67e8b44c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: b6a90cf8f188c3e0386cb22776150dc3b6351c46
https://github.com/Perl/perl5/commit/b6a90cf8f188c3e0386cb22776150dc3b6351c46
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 8ed4e915591b87eda9d4c507c4920ced3f9e508e
https://github.com/Perl/perl5/commit/8ed4e915591b87eda9d4c507c4920ced3f9e508e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 18ca33b14e6e43b55d6ec2e7faf8d61025b98090
https://github.com/Perl/perl5/commit/18ca33b14e6e43b55d6ec2e7faf8d61025b98090
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 26a7953ef00c9ac7da4f93901a26d454fd3459ee
https://github.com/Perl/perl5/commit/26a7953ef00c9ac7da4f93901a26d454fd3459ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: c5ee8061d02970fa6621958974a2ee9d6e5b8242
https://github.com/Perl/perl5/commit/c5ee8061d02970fa6621958974a2ee9d6e5b8242
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: f2a97edb1c50e0593b07e4e6cf2e033d1a2f839d
https://github.com/Perl/perl5/commit/f2a97edb1c50e0593b07e4e6cf2e033d1a2f839d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 60c84bb23dcd6a01501a08b6409d261515091505
https://github.com/Perl/perl5/commit/60c84bb23dcd6a01501a08b6409d261515091505
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: dc9ad4a0c99cd0c74cb56e6a3b3feb73fbe3bc98
https://github.com/Perl/perl5/commit/dc9ad4a0c99cd0c74cb56e6a3b3feb73fbe3bc98
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: a68b3a50987b74b7fb02d680288e1b7879042c75
https://github.com/Perl/perl5/commit/a68b3a50987b74b7fb02d680288e1b7879042c75
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 9f1868ca8aeecb46c1b3b264bbaf4606686fe4c2
https://github.com/Perl/perl5/commit/9f1868ca8aeecb46c1b3b264bbaf4606686fe4c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: fe238aa1ba36198b1bfd10d1f27e1212a4257ecb
https://github.com/Perl/perl5/commit/fe238aa1ba36198b1bfd10d1f27e1212a4257ecb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: a934b6eb9cb2866e5dfe59c24a7bf6cf0fda327a
https://github.com/Perl/perl5/commit/a934b6eb9cb2866e5dfe59c24a7bf6cf0fda327a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 545999ca646526cb361a24ef5c15444ccb733567
https://github.com/Perl/perl5/commit/545999ca646526cb361a24ef5c15444ccb733567
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 693d8c4d61e0b912f9f6c0cf4ee790ffd7cbb41a
https://github.com/Perl/perl5/commit/693d8c4d61e0b912f9f6c0cf4ee790ffd7cbb41a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: e26dda947cf1f91a55235a477b96317344a41c51
https://github.com/Perl/perl5/commit/e26dda947cf1f91a55235a477b96317344a41c51
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 70a6321c9929dcbdb49bce94a741d8abc74d6c12
https://github.com/Perl/perl5/commit/70a6321c9929dcbdb49bce94a741d8abc74d6c12
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: d8e1b8dda624d9bf8d8b4be0c248bd4dd789d7f0
https://github.com/Perl/perl5/commit/d8e1b8dda624d9bf8d8b4be0c248bd4dd789d7f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 71ea02f8d65a195859b5dd6c6c5992a07d61c934
https://github.com/Perl/perl5/commit/71ea02f8d65a195859b5dd6c6c5992a07d61c934
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: aaca6779a739af6a212364fc05b8bcfb1c426506
https://github.com/Perl/perl5/commit/aaca6779a739af6a212364fc05b8bcfb1c426506
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 266682d9866ba7c418104fda2bf08ed0152248b1
https://github.com/Perl/perl5/commit/266682d9866ba7c418104fda2bf08ed0152248b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 49d4cb2ee55e550076cc81a06763bbe01288d52b
https://github.com/Perl/perl5/commit/49d4cb2ee55e550076cc81a06763bbe01288d52b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: b1497bf40bba29d9ae41b937b9fba18b945cb302
https://github.com/Perl/perl5/commit/b1497bf40bba29d9ae41b937b9fba18b945cb302
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 25f56ee4cb4a318d7e23d5665e3ce3045f9be7be
https://github.com/Perl/perl5/commit/25f56ee4cb4a318d7e23d5665e3ce3045f9be7be
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 6b72bafc5dd46215437ba82c32a5858760bf4aeb
https://github.com/Perl/perl5/commit/6b72bafc5dd46215437ba82c32a5858760bf4aeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: ae67b2b08a2e70280a463db9be1c961ced0a4fda
https://github.com/Perl/perl5/commit/ae67b2b08a2e70280a463db9be1c961ced0a4fda
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: e006ff914f5dbe369bf576a1b018e3a4fadd941b
https://github.com/Perl/perl5/commit/e006ff914f5dbe369bf576a1b018e3a4fadd941b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 9e5f0b8282700c27a63f4e0ef052a460a16bf31e
https://github.com/Perl/perl5/commit/9e5f0b8282700c27a63f4e0ef052a460a16bf31e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: b1e9b08a3785657e513e6f7a56e2d080cfb325d0
https://github.com/Perl/perl5/commit/b1e9b08a3785657e513e6f7a56e2d080cfb325d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 70a0a51348fb9368cd8575762004dd8c0c6a054f
https://github.com/Perl/perl5/commit/70a0a51348fb9368cd8575762004dd8c0c6a054f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: c5767c876205f4f564edd199b9d7656cdf05e7fc
https://github.com/Perl/perl5/commit/c5767c876205f4f564edd199b9d7656cdf05e7fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 78895321588f8ffec46973a0558782760aba82c7
https://github.com/Perl/perl5/commit/78895321588f8ffec46973a0558782760aba82c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 113fa6cbb4494ffb105ee9112fdb37ab4d4a14f2
https://github.com/Perl/perl5/commit/113fa6cbb4494ffb105ee9112fdb37ab4d4a14f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 1f22eda8fe008137c27b6398fe20392e7536f2c1
https://github.com/Perl/perl5/commit/1f22eda8fe008137c27b6398fe20392e7536f2c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: fd38a0b7980bc88e5b940f414d1f42335d459062
https://github.com/Perl/perl5/commit/fd38a0b7980bc88e5b940f414d1f42335d459062
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: b60c0b22ced7364ca5136aee5a6d45a0e5cafac8
https://github.com/Perl/perl5/commit/b60c0b22ced7364ca5136aee5a6d45a0e5cafac8
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: c0ddb3c0dec97409d7ce83547c6535bb49f07185
https://github.com/Perl/perl5/commit/c0ddb3c0dec97409d7ce83547c6535bb49f07185
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 4d41ebc8e276c2a05adaa951a79e88ea3df6eea1
https://github.com/Perl/perl5/commit/4d41ebc8e276c2a05adaa951a79e88ea3df6eea1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6c15322c84a002891b44eca2ee69462c4d4a0542
https://github.com/Perl/perl5/commit/6c15322c84a002891b44eca2ee69462c4d4a0542
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 2c6e7f314e0eb05488bf3d118b83e9caad1ca12e
https://github.com/Perl/perl5/commit/2c6e7f314e0eb05488bf3d118b83e9caad1ca12e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: ac5c7d9fcc031ae06b5c19b9a34eaf85fc362eba
https://github.com/Perl/perl5/commit/ac5c7d9fcc031ae06b5c19b9a34eaf85fc362eba
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 33399f8c22af0b6844dd277a9d726d7b7a63e4e7
https://github.com/Perl/perl5/commit/33399f8c22af0b6844dd277a9d726d7b7a63e4e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 1ae7e3472d02adaa57907c9d42372d46a73c500b
https://github.com/Perl/perl5/commit/1ae7e3472d02adaa57907c9d42372d46a73c500b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: a7b310c803472454c5e0d38f8df6e1a146b5570b
https://github.com/Perl/perl5/commit/a7b310c803472454c5e0d38f8df6e1a146b5570b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 1e00d2fc7e694a0e7444462f9b193c37ef6fac80
https://github.com/Perl/perl5/commit/1e00d2fc7e694a0e7444462f9b193c37ef6fac80
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 2765fb2c6819e2057cc7d2436a5d58ff232491d1
https://github.com/Perl/perl5/commit/2765fb2c6819e2057cc7d2436a5d58ff232491d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 9373de9f9a3cff973a3e34ceda4c05ba5a5db809
https://github.com/Perl/perl5/commit/9373de9f9a3cff973a3e34ceda4c05ba5a5db809
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 7cf412938de8cf0a2246f65d48c83214fde76f69
https://github.com/Perl/perl5/commit/7cf412938de8cf0a2246f65d48c83214fde76f69
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: e01f9439e6b7ee154ec261959cf0737b6aca8a24
https://github.com/Perl/perl5/commit/e01f9439e6b7ee154ec261959cf0737b6aca8a24
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 50b847c050a55738299a2732ab6cabc2fd1d4e93
https://github.com/Perl/perl5/commit/50b847c050a55738299a2732ab6cabc2fd1d4e93
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: ec9f851439f15eec0fc91059be1627d4402a647c
https://github.com/Perl/perl5/commit/ec9f851439f15eec0fc91059be1627d4402a647c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 5f67719b47e41964e07dd16f75dda5ddbda5e476
https://github.com/Perl/perl5/commit/5f67719b47e41964e07dd16f75dda5ddbda5e476
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: cbea93fa473e9c06a6c5468327c578da78e54921
https://github.com/Perl/perl5/commit/cbea93fa473e9c06a6c5468327c578da78e54921
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: bc3ce6a945b21a2d9d9ea7b6204287f2208d6ce8
https://github.com/Perl/perl5/commit/bc3ce6a945b21a2d9d9ea7b6204287f2208d6ce8
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 0e513f5a98aeaaf07a31ed93be83bcbbcdb008b4
https://github.com/Perl/perl5/commit/0e513f5a98aeaaf07a31ed93be83bcbbcdb008b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: b314a150f488eae828e5a558f79f90542beea033
https://github.com/Perl/perl5/commit/b314a150f488eae828e5a558f79f90542beea033
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: cc2809f7c8d6eebb8d07fb0396214ba57eb95adb
https://github.com/Perl/perl5/commit/cc2809f7c8d6eebb8d07fb0396214ba57eb95adb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: f8f1ff2f92ccc7791cabd5f499b0f11a5311fbd2
https://github.com/Perl/perl5/commit/f8f1ff2f92ccc7791cabd5f499b0f11a5311fbd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: d4ac2e1cafebf124dc9db0b42f44c07438c2d6f4
https://github.com/Perl/perl5/commit/d4ac2e1cafebf124dc9db0b42f44c07438c2d6f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: a5ea5dbd5792b5305299ade61d6bd2306d974abe
https://github.com/Perl/perl5/commit/a5ea5dbd5792b5305299ade61d6bd2306d974abe
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: eac47819bca7a84c48fb0c6e61e2d2eafdfea5ee
https://github.com/Perl/perl5/commit/eac47819bca7a84c48fb0c6e61e2d2eafdfea5ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 33225d938a295f78b711f7608de8e7095e3242ec
https://github.com/Perl/perl5/commit/33225d938a295f78b711f7608de8e7095e3242ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 3c19f6c221bc7a8e78fa7b264d17c18b9d61bc7b
https://github.com/Perl/perl5/commit/3c19f6c221bc7a8e78fa7b264d17c18b9d61bc7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 2e5ab8bec04817db5f59a2fe8ac907fe3b018807
https://github.com/Perl/perl5/commit/2e5ab8bec04817db5f59a2fe8ac907fe3b018807
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: bc2c527caafaa4bfb93d7abe436c442d23383415
https://github.com/Perl/perl5/commit/bc2c527caafaa4bfb93d7abe436c442d23383415
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 84d919321a601d359f23bd43376086ff8fdbe782
https://github.com/Perl/perl5/commit/84d919321a601d359f23bd43376086ff8fdbe782
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 9d1b9b009d2e48858c164f303c1a2128090d5357
https://github.com/Perl/perl5/commit/9d1b9b009d2e48858c164f303c1a2128090d5357
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 8345a55274e439099c1c39dda70b77779d72d0ec
https://github.com/Perl/perl5/commit/8345a55274e439099c1c39dda70b77779d72d0ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: cb6d47ca034ac76d5303f7b3e0e0b59d5decb69f
https://github.com/Perl/perl5/commit/cb6d47ca034ac76d5303f7b3e0e0b59d5decb69f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 6109b6ba861ed872cd2ea63b89992f6028918fee
https://github.com/Perl/perl5/commit/6109b6ba861ed872cd2ea63b89992f6028918fee
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: ac3b26026824e7cbbaa0892e156f11fb8098246c
https://github.com/Perl/perl5/commit/ac3b26026824e7cbbaa0892e156f11fb8098246c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 79660b53e7f08e0f5ee5884bd3b0727cbbacc5b2
https://github.com/Perl/perl5/commit/79660b53e7f08e0f5ee5884bd3b0727cbbacc5b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 985baae85b9756d6832442ad196ad3ecd9cb353b
https://github.com/Perl/perl5/commit/985baae85b9756d6832442ad196ad3ecd9cb353b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 320ec34ef8518cbdadfe0ea316e33d2d10371bae
https://github.com/Perl/perl5/commit/320ec34ef8518cbdadfe0ea316e33d2d10371bae
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 06f00462f3e57b0649801f425b6fa531e090c7a9
https://github.com/Perl/perl5/commit/06f00462f3e57b0649801f425b6fa531e090c7a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 4ae74c78381403911e0e1266ec5bef40ec27b1e2
https://github.com/Perl/perl5/commit/4ae74c78381403911e0e1266ec5bef40ec27b1e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 966322c8516d7719b0988b1cfa186c6754893fb2
https://github.com/Perl/perl5/commit/966322c8516d7719b0988b1cfa186c6754893fb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 6f4e1b7a7cc1640d47871d95da7e9c3de4617acb
https://github.com/Perl/perl5/commit/6f4e1b7a7cc1640d47871d95da7e9c3de4617acb
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: a75f6a916ca7721f02d205bf5c68f0397c064634
https://github.com/Perl/perl5/commit/a75f6a916ca7721f02d205bf5c68f0397c064634
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: e33fa4fb55a4e7b4f0ea101d1a2bf234e6bfff7a
https://github.com/Perl/perl5/commit/e33fa4fb55a4e7b4f0ea101d1a2bf234e6bfff7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: e314240334895bf7f5127edf07b3b57a4724dfd3
https://github.com/Perl/perl5/commit/e314240334895bf7f5127edf07b3b57a4724dfd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 19115782c1cd54cd66177a5234126fb0e7e7d029
https://github.com/Perl/perl5/commit/19115782c1cd54cd66177a5234126fb0e7e7d029
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 2421a87a1219592dc1248b8132f97e2c88f1ca8a
https://github.com/Perl/perl5/commit/2421a87a1219592dc1248b8132f97e2c88f1ca8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 12ace50f1b1d88697e7f0d8218f6ceebdceb3a5a
https://github.com/Perl/perl5/commit/12ace50f1b1d88697e7f0d8218f6ceebdceb3a5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: d04fa4a1fb2b5be81dafae5fef8c783c0def2f21
https://github.com/Perl/perl5/commit/d04fa4a1fb2b5be81dafae5fef8c783c0def2f21
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: d9bc5bb8867e36f22f0def89e6fb9795261a3b9b
https://github.com/Perl/perl5/commit/d9bc5bb8867e36f22f0def89e6fb9795261a3b9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 96ac64260dc98e1ee96e492e73a482c960b0969d
https://github.com/Perl/perl5/commit/96ac64260dc98e1ee96e492e73a482c960b0969d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: aacc366697bad85ecc522ede245e8731c9bea04e
https://github.com/Perl/perl5/commit/aacc366697bad85ecc522ede245e8731c9bea04e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 8e4ced49454871c489cfbd197451f3add4391eae
https://github.com/Perl/perl5/commit/8e4ced49454871c489cfbd197451f3add4391eae
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: bf811a2c4f95aaff26ba2213ab3c53ed381ef33e
https://github.com/Perl/perl5/commit/bf811a2c4f95aaff26ba2213ab3c53ed381ef33e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 16f9c1392376911446c49a222b62e8961fc57c5d
https://github.com/Perl/perl5/commit/16f9c1392376911446c49a222b62e8961fc57c5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: c82d0e8d4e9c12bda967f557871bac5b048d279d
https://github.com/Perl/perl5/commit/c82d0e8d4e9c12bda967f557871bac5b048d279d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 81c500f69160c2259d6a03c5e16914f71b9fb47b
https://github.com/Perl/perl5/commit/81c500f69160c2259d6a03c5e16914f71b9fb47b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: b86b5fc5cc0305852727765912821794d1015d12
https://github.com/Perl/perl5/commit/b86b5fc5cc0305852727765912821794d1015d12
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 86445b726b0787c2a3fca4d0ff7cddd20afafd2a
https://github.com/Perl/perl5/commit/86445b726b0787c2a3fca4d0ff7cddd20afafd2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: b6eee1bd89e6c334a85ffa4ef394bc4b649634ce
https://github.com/Perl/perl5/commit/b6eee1bd89e6c334a85ffa4ef394bc4b649634ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 93d3ce85dc9f020921ba7deccc27dde7a97753b5
https://github.com/Perl/perl5/commit/93d3ce85dc9f020921ba7deccc27dde7a97753b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: a7190fa152b4f0967a310e34acaf88729f79f39c
https://github.com/Perl/perl5/commit/a7190fa152b4f0967a310e34acaf88729f79f39c
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 0bbc01e1ce841dc1a8a7da51bf99879dc45c090a
https://github.com/Perl/perl5/commit/0bbc01e1ce841dc1a8a7da51bf99879dc45c090a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 24ac8a24439c3a762fbb6c889d1920fa29d6cdd7
https://github.com/Perl/perl5/commit/24ac8a24439c3a762fbb6c889d1920fa29d6cdd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 36fb3aed08da1bbe5bcd3a5d206ae27da5298405
https://github.com/Perl/perl5/commit/36fb3aed08da1bbe5bcd3a5d206ae27da5298405
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3a6ae7c6445d8033927e4b93516b6a27ea3dc147
https://github.com/Perl/perl5/commit/3a6ae7c6445d8033927e4b93516b6a27ea3dc147
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 351caa2c6d92c7693ee466f3fbd8a7c87b1506e9
https://github.com/Perl/perl5/commit/351caa2c6d92c7693ee466f3fbd8a7c87b1506e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 0bd864f13c4c0afde2881c52c40a1b8b7a080a40
https://github.com/Perl/perl5/commit/0bd864f13c4c0afde2881c52c40a1b8b7a080a40
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 98a1c725cd340e863a36eb9339dfc6ca70aece98
https://github.com/Perl/perl5/commit/98a1c725cd340e863a36eb9339dfc6ca70aece98
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: ad9d451f2115e5703f67835b7e22db71a913f232
https://github.com/Perl/perl5/commit/ad9d451f2115e5703f67835b7e22db71a913f232
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 1e3923f6aecbbcd72943b23e5902dd6af65bcd4f
https://github.com/Perl/perl5/commit/1e3923f6aecbbcd72943b23e5902dd6af65bcd4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 626ef42c499386bd67d7943c1d424ce9957e8b9a
https://github.com/Perl/perl5/commit/626ef42c499386bd67d7943c1d424ce9957e8b9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 74f095bf117609859f34e44be7f85514a3dcafde
https://github.com/Perl/perl5/commit/74f095bf117609859f34e44be7f85514a3dcafde
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: d33e6f11a8cffb17ceca2a85f82bf1e64882f6d1
https://github.com/Perl/perl5/commit/d33e6f11a8cffb17ceca2a85f82bf1e64882f6d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: b557d6bb85cc45919d78a00e56e7842900e20292
https://github.com/Perl/perl5/commit/b557d6bb85cc45919d78a00e56e7842900e20292
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: b42f1e1b92553575fdae0e49874e0b67f3579de5
https://github.com/Perl/perl5/commit/b42f1e1b92553575fdae0e49874e0b67f3579de5
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 210bc6aa7feb6bb94a46063519ae05dcadd576e1
https://github.com/Perl/perl5/commit/210bc6aa7feb6bb94a46063519ae05dcadd576e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: e62ee449e8b432a22972d98fb8bca69ac2fe0f29
https://github.com/Perl/perl5/commit/e62ee449e8b432a22972d98fb8bca69ac2fe0f29
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: c768e456ecae1e162c50094029f8fe3fcbbb1a1e
https://github.com/Perl/perl5/commit/c768e456ecae1e162c50094029f8fe3fcbbb1a1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: db185996981af3d9fdb4246ad9acaa6a27d3fbaa
https://github.com/Perl/perl5/commit/db185996981af3d9fdb4246ad9acaa6a27d3fbaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: d919b27d89195bd9dd9c87dcec74e0904c75efa2
https://github.com/Perl/perl5/commit/d919b27d89195bd9dd9c87dcec74e0904c75efa2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 4b44caa5eb33170b09f1744e39ff23217b4623a6
https://github.com/Perl/perl5/commit/4b44caa5eb33170b09f1744e39ff23217b4623a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 1aa068d91b9df55db1acc9c846e301a75f890ca8
https://github.com/Perl/perl5/commit/1aa068d91b9df55db1acc9c846e301a75f890ca8
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 448b87ce03152e0e24512d9076af64ea9233a7ee
https://github.com/Perl/perl5/commit/448b87ce03152e0e24512d9076af64ea9233a7ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 4303923ecaedbb6f8189e9eee674956eb522e870
https://github.com/Perl/perl5/commit/4303923ecaedbb6f8189e9eee674956eb522e870
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 8f9b1a3206f5e5f06a2e209885fcd0c61177df8b
https://github.com/Perl/perl5/commit/8f9b1a3206f5e5f06a2e209885fcd0c61177df8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 2964e40ba82b9edaa338f6d681419ac196474eaa
https://github.com/Perl/perl5/commit/2964e40ba82b9edaa338f6d681419ac196474eaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 89d240d9ff157d8f2747b0d6e2e5a1f18d3eb0a8
https://github.com/Perl/perl5/commit/89d240d9ff157d8f2747b0d6e2e5a1f18d3eb0a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: ef7217e4ddb47f6b54a39c7c5a8e720ea192bfd6
https://github.com/Perl/perl5/commit/ef7217e4ddb47f6b54a39c7c5a8e720ea192bfd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 7fa0f7616a8dcd0183cebeb0ace0f46e06c7f0b5
https://github.com/Perl/perl5/commit/7fa0f7616a8dcd0183cebeb0ace0f46e06c7f0b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 119180eb4fdab342161ba8ae98b0d0544115b3c1
https://github.com/Perl/perl5/commit/119180eb4fdab342161ba8ae98b0d0544115b3c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 599cc1fec4fc0d68069af41a9dfd087380725faf
https://github.com/Perl/perl5/commit/599cc1fec4fc0d68069af41a9dfd087380725faf
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 2503c6bc1481bd56fb9709221b042efaaf1f12f9
https://github.com/Perl/perl5/commit/2503c6bc1481bd56fb9709221b042efaaf1f12f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: a95f123830e6e00ae95bc1eaffd521af36c489a9
https://github.com/Perl/perl5/commit/a95f123830e6e00ae95bc1eaffd521af36c489a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: c1eefb77c2ab9940441089adc5e35ac934c1d8b2
https://github.com/Perl/perl5/commit/c1eefb77c2ab9940441089adc5e35ac934c1d8b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 249dfa55f131b8b91f94fd210e3a1ca592669fb4
https://github.com/Perl/perl5/commit/249dfa55f131b8b91f94fd210e3a1ca592669fb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: c34a147b11e9ce60c6ec05229625d501d3cdbb00
https://github.com/Perl/perl5/commit/c34a147b11e9ce60c6ec05229625d501d3cdbb00
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 2ec947725088cd0da4286f0526f7e8b46265b09b
https://github.com/Perl/perl5/commit/2ec947725088cd0da4286f0526f7e8b46265b09b
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 27b50e327773babd9957482f8059dff6aa35fe32
https://github.com/Perl/perl5/commit/27b50e327773babd9957482f8059dff6aa35fe32
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 5caab8944ac8192bc372a27262e474b478cde056
https://github.com/Perl/perl5/commit/5caab8944ac8192bc372a27262e474b478cde056
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: c29795dabf0a0cf1a56592256d22196102a488de
https://github.com/Perl/perl5/commit/c29795dabf0a0cf1a56592256d22196102a488de
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 38f7a47bfd11411c3c3166c948b45d56aa7586bd
https://github.com/Perl/perl5/commit/38f7a47bfd11411c3c3166c948b45d56aa7586bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 03b969fe4f7c8e4ab37d07b35e2aa623d5ead340
https://github.com/Perl/perl5/commit/03b969fe4f7c8e4ab37d07b35e2aa623d5ead340
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 9b102373ca653bf896e57143943c0a47c5502b69
https://github.com/Perl/perl5/commit/9b102373ca653bf896e57143943c0a47c5502b69
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 0d88506efd3639931fad5b864af0ce27ce3dded1
https://github.com/Perl/perl5/commit/0d88506efd3639931fad5b864af0ce27ce3dded1
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: fb8e3a18149f4d42714a979daa214b2773bafac7
https://github.com/Perl/perl5/commit/fb8e3a18149f4d42714a979daa214b2773bafac7
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: be34e0acb08824ee8f5cdcb989926ef9742a53dc
https://github.com/Perl/perl5/commit/be34e0acb08824ee8f5cdcb989926ef9742a53dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 21c66c9d326d6439f36d851ae8b8033ead38dafc
https://github.com/Perl/perl5/commit/21c66c9d326d6439f36d851ae8b8033ead38dafc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: f4668934e875f189b283706ecdf9150f0271b341
https://github.com/Perl/perl5/commit/f4668934e875f189b283706ecdf9150f0271b341
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: b85cc6cac6b6cbec6ea6c32269c0646bc6f4aaf9
https://github.com/Perl/perl5/commit/b85cc6cac6b6cbec6ea6c32269c0646bc6f4aaf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: e9c1431cd02e9e322d601a07ddf7fd0697ea71ab
https://github.com/Perl/perl5/commit/e9c1431cd02e9e322d601a07ddf7fd0697ea71ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 0d8c36ffbff9a36a58adf4848b676d31b6d71ae8
https://github.com/Perl/perl5/commit/0d8c36ffbff9a36a58adf4848b676d31b6d71ae8
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 298eaf8f15d17fd8fa06c8d7f9cf9d954941c917
https://github.com/Perl/perl5/commit/298eaf8f15d17fd8fa06c8d7f9cf9d954941c917
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: e3faabc2d07d726f2eabf7cfe20c465444516bcf
https://github.com/Perl/perl5/commit/e3faabc2d07d726f2eabf7cfe20c465444516bcf
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: f99efccb3f8231166c29243258201f7eb6b0b2b0
https://github.com/Perl/perl5/commit/f99efccb3f8231166c29243258201f7eb6b0b2b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 599f31eb85f73b1f0f1145f4543b25172265a720
https://github.com/Perl/perl5/commit/599f31eb85f73b1f0f1145f4543b25172265a720
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: a429e350bdf65023dd75a34938a749638dec6966
https://github.com/Perl/perl5/commit/a429e350bdf65023dd75a34938a749638dec6966
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 7ee9b04cb1116928b4dcd91c348786e7ab110a92
https://github.com/Perl/perl5/commit/7ee9b04cb1116928b4dcd91c348786e7ab110a92
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 9f40b1f900487d52152781ee4b5782476794c539
https://github.com/Perl/perl5/commit/9f40b1f900487d52152781ee4b5782476794c539
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 49f8f6059cb9594f9548ca01e01cecc58dd12b05
https://github.com/Perl/perl5/commit/49f8f6059cb9594f9548ca01e01cecc58dd12b05
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: a63d73e5bf46d7b1773413a7656916af4299b3dc
https://github.com/Perl/perl5/commit/a63d73e5bf46d7b1773413a7656916af4299b3dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: c15c3ec1fc887c69750e29bd47e393ba67110e85
https://github.com/Perl/perl5/commit/c15c3ec1fc887c69750e29bd47e393ba67110e85
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg Revamp sync_locale, switch_to_global_locale
Commit: dd397fdf38b810a0d2a1911c55de99c35a44030d
https://github.com/Perl/perl5/commit/dd397fdf38b810a0d2a1911c55de99c35a44030d
Author: Karl Williamson <[email protected]>
Date: 2021-04-12 (Mon, 12 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M sv.c
Log Message:
-----------
all
Compare: https://github.com/Perl/perl5/compare/75ea739caaf0...dd397fdf38b8
